From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH 1/5] drm/nouveau: Prevent RPM callback recursion in suspend/resume paths Date: Wed, 18 Jul 2018 10:25:05 +0200 Message-ID: <20180718082505.GB16072@wunner.de> References: <20180716235936.11268-1-lyude@redhat.com> <20180716235936.11268-2-lyude@redhat.com> <20180717071641.GA5411@wunner.de> <20180717182041.GA18363@wunner.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: "Rafael J. Wysocki" Cc: Linux PM , David Airlie , nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Linux Kernel Mailing List , dri-devel , Ben Skeggs List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdWwgMTgsIDIwMTggYXQgMDk6Mzg6NDFBTSArMDIwMCwgUmFmYWVsIEouIFd5c29j a2kgd3JvdGU6Cj4gT24gVHVlLCBKdWwgMTcsIDIwMTggYXQgODoyMCBQTSwgTHVrYXMgV3VubmVy IDxsdWthc0B3dW5uZXIuZGU+IHdyb3RlOgo+ID4gT2theSwgdGhlIFBDSSBkZXZpY2UgaXMgc3Vz cGVuZGluZyBhbmQgdGhlIG52a21faTJjX2F1eF9hY3F1aXJlKCkKPiA+IHdhbnRzIGl0IGluIHJl c3VtZWQgc3RhdGUsIHNvIGlzIHdhaXRpbmcgZm9yZXZlciBmb3IgdGhlIGRldmljZSB0bwo+ID4g cnVudGltZSBzdXNwZW5kIGluIG9yZGVyIHRvIHJlc3VtZSBpdCBhZ2FpbiBpbW1lZGlhdGVseSBh ZnRlcndhcmRzLgo+ID4KPiA+IFRoZSBkZWFkbG9jayBpbiB0aGUgc3RhY2sgdHJhY2UgeW91J3Zl IHBvc3RlZCBjb3VsZCBiZSByZXNvbHZlZCB1c2luZwo+ID4gdGhlIHRlY2huaXF1ZSBJIHVzZWQg aW4gZDYxYTVjMTA2MzUxIGJ5IGFkZGluZyB0aGUgZm9sbG93aW5nIHRvCj4gPiBpbmNsdWRlL2xp bnV4L3BtX3J1bnRpbWUuaDoKPiA+Cj4gPiBzdGF0aWMgaW5saW5lIGJvb2wgcG1fcnVudGltZV9z dGF0dXNfc3VzcGVuZGluZyhzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiB7Cj4gPiAgICAgICAgIHJl dHVybiBkZXYtPnBvd2VyLnJ1bnRpbWVfc3RhdHVzID09IFJQTV9TVVNQRU5ESU5HOwo+ID4gfQo+ ID4KPiA+IHN0YXRpYyBpbmxpbmUgYm9vbCBpc19wbV93b3JrKHN0cnVjdCBkZXZpY2UgKmRldikK PiA+IHsKPiA+ICAgICAgICAgc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrID0gY3VycmVudF93b3Jr KCk7Cj4gPgo+ID4gICAgICAgICByZXR1cm4gd29yayAmJiB3b3JrLT5mdW5jID09IGRldi0+cG93 ZXIud29yazsKPiA+IH0KPiA+Cj4gPiBUaGVuIGFkZGluZyB0aGlzIHRvIG52a21faTJjX2F1eF9h Y3F1aXJlKCk6Cj4gPgo+ID4gICAgICAgICBzdHJ1Y3QgZGV2aWNlICpkZXYgPSBwYWQtPmkyYy0+ c3ViZGV2LmRldmljZS0+ZGV2Owo+ID4KPiA+ICAgICAgICAgaWYgKCEoaXNfcG1fd29yayhkZXYp ICYmIHBtX3J1bnRpbWVfc3RhdHVzX3N1c3BlbmRpbmcoZGV2KSkpIHsKPiA+ICAgICAgICAgICAg ICAgICByZXQgPSBwbV9ydW50aW1lX2dldF9zeW5jKGRldik7Cj4gPiAgICAgICAgICAgICAgICAg aWYgKHJldCA8IDAgJiYgcmV0ICE9IC1FQUNDRVMpCj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICByZXR1cm4gcmV0Owo+ID4gICAgICAgICB9CltzbmlwXQo+IAo+IEZvciB0aGUgcmVjb3JkLCBJ IGRvbid0IHF1aXRlIGxpa2UgdGhpcyBhcHByb2FjaCBhcyBpdCBzZWVtcyB0byBiZQo+IHdvcmtp bmcgYXJvdW5kIGEgYnJva2VuIGRlcGVuZGVuY3kgZ3JhcGguCj4gCj4gSWYgeW91IG5lZWQgdG8g cmVzdW1lIGRldmljZSBBIGZyb20gd2l0aGluIHRoZSBydW50aW1lIHJlc3VtZSBjYWxsYmFjawo+ IG9mIGRldmljZSBCLCB0aGVuIGNsZWFybHkgQiBkZXBlbmRzIG9uIEEgYW5kIHRoZXJlIHNob3Vs ZCBiZSBhIGxpbmsKPiBiZXR3ZWVuIHRoZW0uCj4gCj4gVGhhdCBzYWlkLCBJIGRvIHJlYWxpemUg dGhhdCBpdCBtYXkgYmUgdGhlIHBhdGggb2YgbGVhc3QgcmVzaXN0YW5jZSwKPiBidXQgdGhlbiBJ IHdvbmRlciBpZiB3ZSBjYW4gZG8gYmV0dGVyIHRoYW4gdGhpcy4KClRoZSBHUFUgY29udGFpbnMg YW4gaTJjIHN1YmRldmljZSBmb3IgZWFjaCBjb25uZWN0b3Igd2l0aCBEREMgbGluZXMuCkkgYmVs aWV2ZSB0aG9zZSBhcmUgbW9kZWxsZWQgYXMgY2hpbGRyZW4gb2YgdGhlIEdQVSdzIFBDSSBkZXZp Y2UgYXMKdGhleSdyZSBhY2Nlc3NlZCB2aWEgbW1pbyBvZiB0aGUgUENJIGRldmljZS4KClRoZSBw cm9ibGVtIGhlcmUgaXMgdGhhdCB3aGVuIHRoZSBHUFUncyBQQ0kgZGV2aWNlIHJ1bnRpbWUgc3Vz cGVuZHMsCml0cyBpMmMgY2hpbGQgZGV2aWNlIG5lZWRzIHRvIGJlIHJ1bnRpbWUgYWN0aXZlIHRv IHN1c3BlbmQgdGhlIE1TVAp0b3BvbG9neS4gIENhdGNoLTIyLgoKSSBkb24ndCBrbm93IHdoZXRo ZXIgb3Igbm90IGl0J3MgbmVjZXNzYXJ5IHRvIHN1c3BlbmQgdGhlIE1TVCB0b3BvbG9neS4KSSdt IG5vdCBhbiBleHBlcnQgb24gRGlzcGxheVBvcnQgTXVsdGlTdHJlYW0gdHJhbnNwb3J0LgoKQlRX IEx5dWRlLCBpbiBwYXRjaCA0IGFuZCA1IG9mIHRoaXMgc2VyaWVzLCB5b3UncmUgcnVudGltZSBy ZXN1bWluZwpwYWQtPmkyYy0+c3ViZGV2LmRldmljZS0+ZGV2LiAgSXMgdGhpcyB0aGUgUENJIGRl dmljZSBvciBpcyBpdCB0aGUgaTJjCmRldmljZT8gIEknbSBhbHdheXMgY29uZnVzZWQgYnkgbm91 dmVhdSdzIHN0cnVjdHMuICBJbiBudmttX2kyY19idXNfY3RvcigpCkkgY2FuIHNlZSB0aGF0IHRo ZSBkZXZpY2UgeW91J3JlIHJ1bnRpbWUgcmVzdW1pbmcgaXMgdGhlIHBhcmVudCBvZiB0aGUKaTJj X2FkYXB0ZXI6CgoJc3RydWN0IG52a21fZGV2aWNlICpkZXZpY2UgPSBwYWQtPmkyYy0+c3ViZGV2 LmRldmljZTsKCVsuLi5dCglidXMtPmkyYy5kZXYucGFyZW50ID0gZGV2aWNlLT5kZXY7CgpJZiB0 aGUgaTJjX2FkYXB0ZXIgaXMgYSBjaGlsZCBvZiB0aGUgUENJIGRldmljZSwgaXQncyBzdWZmaWNp ZW50CnRvIHJ1bnRpbWUgcmVzdW1lIHRoZSBpMmNfYWRhcHRlciwgaS5lLiBidXMtPmkyYy5kZXYs IGFuZCB0aGlzIHdpbGwKaW1wbGljaXRseSBydW50aW1lIHJlc3VtZSBpdHMgcGFyZW50LgoKVGhh bmtzLAoKTHVrYXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTm91dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9ub3V2ZWF1Cg==