From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/atomic: Initialize variables in drm_atomic_helper_async_check() to make gcc happy
Date: Mon, 23 Jul 2018 16:17:58 +0200 [thread overview]
Message-ID: <20180723161758.0fdfc97b@bbrezillon> (raw)
In-Reply-To: <20180723140925.GI20359@art_vandelay>
On Mon, 23 Jul 2018 10:09:25 -0400
Sean Paul <seanpaul@chromium.org> wrote:
> On Mon, Jul 23, 2018 at 03:59:02PM +0200, Boris Brezillon wrote:
> > drm_atomic_helper_async_check() declares the plane, old_plane_state and
> > new_plane_state variables to iterate over all planes of the atomic
> > state and make sure only one plane is enabled.
> >
> > Unfortunately gcc is not smart enough to figure out that the check on
> > n_planes is enough to guarantee that plane, new_plane_state and
> > old_plane_state are initialized.
> >
> > Explicitly initialized those variables to NULL to make gcc happy.
^ initialize
And I forgot to add
Cc: stable@vger.kernel.com
Will send a v2 soon.
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
Thanks for the review.
>
> >
> > Fixes: fef9df8b5945 ("drm/atomic: initial support for asynchronous plane update")
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > ---
> > drivers/gpu/drm/drm_atomic_helper.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> > index f7ccfebd3ca8..80be74df7ba6 100644
> > --- a/drivers/gpu/drm/drm_atomic_helper.c
> > +++ b/drivers/gpu/drm/drm_atomic_helper.c
> > @@ -1538,8 +1538,9 @@ int drm_atomic_helper_async_check(struct drm_device *dev,
> > {
> > struct drm_crtc *crtc;
> > struct drm_crtc_state *crtc_state;
> > - struct drm_plane *plane;
> > - struct drm_plane_state *old_plane_state, *new_plane_state;
> > + struct drm_plane *plane = NULL;
> > + struct drm_plane_state *old_plane_state = NULL;
> > + struct drm_plane_state *new_plane_state = NULL;
> > const struct drm_plane_helper_funcs *funcs;
> > int i, n_planes = 0;
> >
> > --
> > 2.14.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-07-23 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 13:59 [PATCH] drm/atomic: Initialize variables in drm_atomic_helper_async_check() to make gcc happy Boris Brezillon
2018-07-23 14:09 ` Sean Paul
2018-07-23 14:17 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723161758.0fdfc97b@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox