From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume() Date: Tue, 31 Jul 2018 11:34:40 +0100 Message-ID: <20180731103440.GD17455@e110455-lin.cambridge.arm.com> References: <20180730190137.GA25420@jordon-HP-15-Notebook-PC> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by gabe.freedesktop.org (Postfix) with ESMTP id 297356E33C for ; Tue, 31 Jul 2018 10:34:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180730190137.GA25420@jordon-HP-15-Notebook-PC> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Souptick Joarder Cc: ajitn.linux@gmail.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, malidp@foss.arm.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org SGkgU291cHRpY2ssCgpPbiBUdWUsIEp1bCAzMSwgMjAxOCBhdCAxMjozMTozN0FNICswNTMwLCBT b3VwdGljayBKb2FyZGVyIHdyb3RlOgo+IGNvbnZlcnQgZHJtX2F0b21pY19oZWxwZXJfc3VzcGVu ZC9yZXN1bWUoKSB0byB1c2UKPiBkcm1fbW9kZV9jb25maWdfaGVscGVyX3N1c3BlbmQvcmVzdW1l KCkuCj4gCj4gV2l0aCB0aGlzIGNvbnZlcnNpb24sIGRybV9mYmRldl9jbWFfc2V0X3N1c3BlbmRf dW5sb2NrZWQoKQo+IHdpbGwgbGVmdCB3aXRoIG5vIGNvbnN1bWVyLiBTbyB0aGlzIGZ1bmN0aW9u IGNhbiBiZSByZW1vdmVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFNvdXB0aWNrIEpvYXJkZXIgPGpy ZHIubGludXhAZ21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEFqaXQgTmVnaSA8YWppdG4ubGlu dXhAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYXJtL2hkbGNkX2Rydi5jICAg ICAgIHwgMjYgKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9mYl9jbWFfaGVscGVyLmMgICB8IDE4IC0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jIHwgMjEgKystLS0tLS0tLS0tLS0tLS0tLS0tCj4g IGluY2x1ZGUvZHJtL2RybV9mYl9jbWFfaGVscGVyLmggICAgICAgfCAgMiAtLQo+ICA0IGZpbGVz IGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNjMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vaGRsY2RfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJt L2hkbGNkX2Rydi5jCj4gaW5kZXggZmVhYThiYy4uNGU2MTdlMCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vYXJtL2hkbGNkX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FybS9o ZGxjZF9kcnYuYwo+IEBAIC00MjcsMzcgKzQyNywxNSBAQCBzdGF0aWMgaW50IGhkbGNkX3JlbW92 ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICBzdGF0aWMgaW50IF9fbWF5YmVfdW51 c2VkIGhkbGNkX3BtX3N1c3BlbmQoc3RydWN0IGRldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3Qg ZHJtX2RldmljZSAqZHJtID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gLQlzdHJ1Y3QgaGRsY2Rf ZHJtX3ByaXZhdGUgKmhkbGNkID0gZHJtID8gZHJtLT5kZXZfcHJpdmF0ZSA6IE5VTEw7Cj4gIAo+ IC0JaWYgKCFoZGxjZCkKPiAtCQlyZXR1cm4gMDsKPiAtCj4gLQlkcm1fa21zX2hlbHBlcl9wb2xs X2Rpc2FibGUoZHJtKTsKPiAtCWRybV9mYmRldl9jbWFfc2V0X3N1c3BlbmRfdW5sb2NrZWQoaGRs Y2QtPmZiZGV2LCAxKTsKPiAtCj4gLQloZGxjZC0+c3RhdGUgPSBkcm1fYXRvbWljX2hlbHBlcl9z dXNwZW5kKGRybSk7Cj4gLQlpZiAoSVNfRVJSKGhkbGNkLT5zdGF0ZSkpIHsKPiAtCQlkcm1fZmJk ZXZfY21hX3NldF9zdXNwZW5kX3VubG9ja2VkKGhkbGNkLT5mYmRldiwgMCk7Cj4gLQkJZHJtX2tt c19oZWxwZXJfcG9sbF9lbmFibGUoZHJtKTsKPiAtCQlyZXR1cm4gUFRSX0VSUihoZGxjZC0+c3Rh dGUpOwo+IC0JfQo+IC0KPiAtCXJldHVybiAwOwo+ICsJcmV0dXJuIGRybV9tb2RlX2NvbmZpZ19o ZWxwZXJfc3VzcGVuZChkcm0pOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IF9fbWF5YmVfdW51c2Vk IGhkbGNkX3BtX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0cnVjdCBkcm1f ZGV2aWNlICpkcm0gPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiAtCXN0cnVjdCBoZGxjZF9kcm1f cHJpdmF0ZSAqaGRsY2QgPSBkcm0gPyBkcm0tPmRldl9wcml2YXRlIDogTlVMTDsKPiAtCj4gLQlp ZiAoIWhkbGNkKQo+IC0JCXJldHVybiAwOwo+ICAKPiAtCWRybV9hdG9taWNfaGVscGVyX3Jlc3Vt ZShkcm0sIGhkbGNkLT5zdGF0ZSk7Cj4gLQlkcm1fZmJkZXZfY21hX3NldF9zdXNwZW5kX3VubG9j a2VkKGhkbGNkLT5mYmRldiwgMCk7Cj4gLQlkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZShkcm0p Owo+IC0KPiAtCXJldHVybiAwOwo+ICsJcmV0dXJuIGRybV9tb2RlX2NvbmZpZ19oZWxwZXJfcmVz dW1lKGRybSk7Cj4gIH0KClRoaXMgcGF0Y2ggaXMgc2ltaWxhciB0byB0aGUgb25lIE5vcmFsZiBU csO4bm5lcyBzdWJtaXR0ZWQsIGFuZCBoaXMgaXMKYWxzbyBjbGVhbmluZyB1cCB0aGUgc3RhdGUg dmFyaWFibGUgaW4gaGRsY2RfZHJtX3ByaXZhdGUuIFRoZSBwYXRjaCBoYXMKYmVlbiBxdWV1ZWQg YXMgY29tbWl0IGY2OWQ5Njg2ZTVkOSBpbiBnaXQ6Ly9saW51eC1hcm0ub3JnL2xpbnV4LWxkLmdp dApmb3ItdXBzdHJlYW0vaGRsY2QgYW5kIEkgd2lsbCBzZW5kIGEgcHVsbCByZXF1ZXN0IHRvZGF5 IGZvciBpdC4KCkJlc3QgcmVnYXJkcywKTGl2aXUKCj4gIAo+ICBzdGF0aWMgU0lNUExFX0RFVl9Q TV9PUFMoaGRsY2RfcG1fb3BzLCBoZGxjZF9wbV9zdXNwZW5kLCBoZGxjZF9wbV9yZXN1bWUpOwo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jCj4gaW5kZXggMTg2ZDAwYS4uZjYwNGE4NCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jCj4gQEAgLTUyOSwyMSArNTI5LDMg QEAgdm9pZCBkcm1fZmJkZXZfY21hX3NldF9zdXNwZW5kKHN0cnVjdCBkcm1fZmJkZXZfY21hICpm YmRldl9jbWEsIGJvb2wgc3RhdGUpCj4gIAkJZHJtX2ZiX2hlbHBlcl9zZXRfc3VzcGVuZCgmZmJk ZXZfY21hLT5mYl9oZWxwZXIsIHN0YXRlKTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9mYmRl dl9jbWFfc2V0X3N1c3BlbmQpOwo+IC0KPiAtLyoqCj4gLSAqIGRybV9mYmRldl9jbWFfc2V0X3N1 c3BlbmRfdW5sb2NrZWQgLSB3cmFwcGVyIGFyb3VuZAo+IC0gKiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZHJtX2ZiX2hlbHBlcl9zZXRfc3VzcGVuZF91bmxvY2tlZAo+IC0g KiBAZmJkZXZfY21hOiBUaGUgZHJtX2ZiZGV2X2NtYSBzdHJ1Y3QsIG1heSBiZSBOVUxMCj4gLSAq IEBzdGF0ZTogZGVzaXJlZCBzdGF0ZSwgemVybyB0byByZXN1bWUsIG5vbi16ZXJvIHRvIHN1c3Bl bmQKPiAtICoKPiAtICogQ2FsbHMgZHJtX2ZiX2hlbHBlcl9zZXRfc3VzcGVuZCwgd2hpY2ggaXMg YSB3cmFwcGVyIGFyb3VuZAo+IC0gKiBmYl9zZXRfc3VzcGVuZCBpbXBsZW1lbnRlZCBieSBmYmRl diBjb3JlLgo+IC0gKi8KPiAtdm9pZCBkcm1fZmJkZXZfY21hX3NldF9zdXNwZW5kX3VubG9ja2Vk KHN0cnVjdCBkcm1fZmJkZXZfY21hICpmYmRldl9jbWEsCj4gLQkJCQkJYm9vbCBzdGF0ZSkKPiAt ewo+IC0JaWYgKGZiZGV2X2NtYSkKPiAtCQlkcm1fZmJfaGVscGVyX3NldF9zdXNwZW5kX3VubG9j a2VkKCZmYmRldl9jbWEtPmZiX2hlbHBlciwKPiAtCQkJCQkJICAgc3RhdGUpOwo+IC19Cj4gLUVY UE9SVF9TWU1CT0woZHJtX2ZiZGV2X2NtYV9zZXRfc3VzcGVuZF91bmxvY2tlZCk7Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgYi9kcml2ZXJzL2dw dS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gaW5kZXggMDJhZWU2Yy4uMjg4MjIwZiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+IEBAIC0zNTcsMzIgKzM1Nywx NSBAQCBzdGF0aWMgdm9pZCByY2FyX2R1X2xhc3RjbG9zZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KQo+ICBzdGF0aWMgaW50IHJjYXJfZHVfcG1fc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4g IHsKPiAgCXN0cnVjdCByY2FyX2R1X2RldmljZSAqcmNkdSA9IGRldl9nZXRfZHJ2ZGF0YShkZXYp Owo+IC0Jc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+ICAKPiAtCWRybV9rbXNfaGVs cGVyX3BvbGxfZGlzYWJsZShyY2R1LT5kZGV2KTsKPiAtCWRybV9mYmRldl9jbWFfc2V0X3N1c3Bl bmRfdW5sb2NrZWQocmNkdS0+ZmJkZXYsIHRydWUpOwo+IC0KPiAtCXN0YXRlID0gZHJtX2F0b21p Y19oZWxwZXJfc3VzcGVuZChyY2R1LT5kZGV2KTsKPiAtCWlmIChJU19FUlIoc3RhdGUpKSB7Cj4g LQkJZHJtX2ZiZGV2X2NtYV9zZXRfc3VzcGVuZF91bmxvY2tlZChyY2R1LT5mYmRldiwgZmFsc2Up Owo+IC0JCWRybV9rbXNfaGVscGVyX3BvbGxfZW5hYmxlKHJjZHUtPmRkZXYpOwo+IC0JCXJldHVy biBQVFJfRVJSKHN0YXRlKTsKPiAtCX0KPiAtCj4gLQlyY2R1LT5zdXNwZW5kX3N0YXRlID0gc3Rh dGU7Cj4gLQo+IC0JcmV0dXJuIDA7Cj4gKwlyZXR1cm4gZHJtX21vZGVfY29uZmlnX2hlbHBlcl9z dXNwZW5kKHJjZHUtPmRkZXYpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IHJjYXJfZHVfcG1fcmVz dW1lKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgewo+ICAJc3RydWN0IHJjYXJfZHVfZGV2aWNlICpy Y2R1ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gIAo+IC0JZHJtX2F0b21pY19oZWxwZXJfcmVz dW1lKHJjZHUtPmRkZXYsIHJjZHUtPnN1c3BlbmRfc3RhdGUpOwo+IC0JZHJtX2ZiZGV2X2NtYV9z ZXRfc3VzcGVuZF91bmxvY2tlZChyY2R1LT5mYmRldiwgZmFsc2UpOwo+IC0JZHJtX2ttc19oZWxw ZXJfcG9sbF9lbmFibGUocmNkdS0+ZGRldik7Cj4gLQo+IC0JcmV0dXJuIDA7Cj4gKwlyZXR1cm4g ZHJtX21vZGVfY29uZmlnX2hlbHBlcl9yZXN1bWUocmNkdS0+ZGRldik7Cj4gIH0KPiAgI2VuZGlm Cj4gIAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZmJfY21hX2hlbHBlci5oIGIvaW5j bHVkZS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuaAo+IGluZGV4IGQ1MzJmODhhLi4xNWM0NTY5IDEw MDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9mYl9jbWFfaGVscGVyLmgKPiArKysgYi9pbmNs dWRlL2RybS9kcm1fZmJfY21hX2hlbHBlci5oCj4gQEAgLTMzLDggKzMzLDYgQEAgc3RydWN0IGRy bV9mYmRldl9jbWEgKmRybV9mYmRldl9jbWFfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ICB2b2lkIGRybV9mYmRldl9jbWFfcmVzdG9yZV9tb2RlKHN0cnVjdCBkcm1fZmJkZXZfY21hICpm YmRldl9jbWEpOwo+ICB2b2lkIGRybV9mYmRldl9jbWFfaG90cGx1Z19ldmVudChzdHJ1Y3QgZHJt X2ZiZGV2X2NtYSAqZmJkZXZfY21hKTsKPiAgdm9pZCBkcm1fZmJkZXZfY21hX3NldF9zdXNwZW5k KHN0cnVjdCBkcm1fZmJkZXZfY21hICpmYmRldl9jbWEsIGJvb2wgc3RhdGUpOwo+IC12b2lkIGRy bV9mYmRldl9jbWFfc2V0X3N1c3BlbmRfdW5sb2NrZWQoc3RydWN0IGRybV9mYmRldl9jbWEgKmZi ZGV2X2NtYSwKPiAtCQkJCQlib29sIHN0YXRlKTsKPiAgCj4gIHN0cnVjdCBkcm1fZ2VtX2NtYV9v YmplY3QgKmRybV9mYl9jbWFfZ2V0X2dlbV9vYmooc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIs Cj4gIAl1bnNpZ25lZCBpbnQgcGxhbmUpOwo+IC0tIAo+IDEuOS4xCj4gCgotLSAKPT09PT09PT09 PT09PT09PT09PT0KfCBJIHdvdWxkIGxpa2UgdG8gfAp8IGZpeCB0aGUgd29ybGQsICB8CnwgYnV0 IHRoZXkncmUgbm90IHwKfCBnaXZpbmcgbWUgdGhlICAgfAogXCBzb3VyY2UgY29kZSEgIC8KICAt LS0tLS0tLS0tLS0tLS0KICAgIMKvXF8o44OEKV8vwq8KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==