From: Daniel Vetter <daniel@ffwll.ch>
To: Stefan Agner <stefan@agner.ch>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/doc: clarify how to acquire required vblank event reference
Date: Wed, 8 Aug 2018 10:25:52 +0200 [thread overview]
Message-ID: <20180808082552.GI3008@phenom.ffwll.local> (raw)
In-Reply-To: <20180807201143.7446-1-stefan@agner.ch>
On Tue, Aug 07, 2018 at 10:11:43PM +0200, Stefan Agner wrote:
> As a driver write it is not entirely obvious that a reference to
> the event e mentioned in the doc can be obtained via
> drm_crtc_vblank_get(). Clarify how to obtain the reference.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> drivers/gpu/drm/drm_vblank.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
> index 28cdcf76b6f9..7610ff466ef9 100644
> --- a/drivers/gpu/drm/drm_vblank.c
> +++ b/drivers/gpu/drm/drm_vblank.c
> @@ -873,8 +873,8 @@ static void send_vblank_event(struct drm_device *dev,
> * handler by calling drm_crtc_send_vblank_event() and make sure that there's no
> * possible race with the hardware committing the atomic update.
> *
> - * Caller must hold a vblank reference for the event @e, which will be dropped
> - * when the next vblank arrives.
> + * Caller must hold a vblank reference for the event @e acquired by a
> + * drm_crtc_vblank_get(), which will be dropped when the next vblank arrives.
Thanks for this clarification, patch applied.
-Daniel
> */
> void drm_crtc_arm_vblank_event(struct drm_crtc *crtc,
> struct drm_pending_vblank_event *e)
> --
> 2.18.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-08-08 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 20:11 [PATCH] drm/doc: clarify how to acquire required vblank event reference Stefan Agner
2018-08-08 8:25 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808082552.GI3008@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox