From: Sean Paul <seanpaul@chromium.org>
To: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, nd@arm.com
Subject: Re: [PATCH] drm: Clarify DRM_MODE_REFLECT_X/Y documentation
Date: Fri, 10 Aug 2018 14:13:57 -0400 [thread overview]
Message-ID: <20180810181357.GV20303@art_vandelay> (raw)
In-Reply-To: <20180810175031.5956-1-alexandru-cosmin.gheorghe@arm.com>
On Fri, Aug 10, 2018 at 06:50:31PM +0100, Alexandru Gheorghe wrote:
> DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear
> to me, so try to clarify that with a bit of ascii graphics.
>
> Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
> ---
> include/uapi/drm/drm_mode.h | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index 8d67243952f4..ac5de85c93eb 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -186,9 +186,18 @@ extern "C" {
> /*
> * DRM_MODE_REFLECT_<axis>
> *
> - * Signals that the contents of a drm plane is reflected in the <axis> axis,
> + * Signals that the contents of a drm plane is reflected along the <axis> axis,
> * in the same way as mirroring.
> *
> + * DRM_MODE_REFLECT_X
> + * |o | | o|
> + * | | -> | |
> + * | v| |v |
> + *
> + * DRM_MODE_REFLECT_Y
> + * |o | | ^|
> + * | | -> | |
> + * | v| |o |
> * This define is provided as a convenience, looking up the property id
> * using the name->prop id lookup is the preferred method.
> */
> --
> 2.18.0
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-08-10 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 17:50 [PATCH] drm: Clarify DRM_MODE_REFLECT_X/Y documentation Alexandru Gheorghe
2018-08-10 18:13 ` Sean Paul [this message]
2018-08-14 8:36 ` Daniel Vetter
2018-08-20 9:10 ` Alexandru-Cosmin Gheorghe
2018-08-21 8:54 ` Daniel Vetter
2018-08-21 9:20 ` Alexandru-Cosmin Gheorghe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810181357.GV20303@art_vandelay \
--to=seanpaul@chromium.org \
--cc=airlied@linux.ie \
--cc=alexandru-cosmin.gheorghe@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox