From: Sean Paul <sean@poorly.run>
To: dri-devel@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Guenter Roeck <groeck@chromium.org>,
Dylan Reid <dgreid@chromium.org>
Subject: [PATCH] drm/bridge: ti-sn65dsi86: Fix 0-day build error
Date: Wed, 15 Aug 2018 15:49:14 -0400 [thread overview]
Message-ID: <20180815194923.3258-1-sean@poorly.run> (raw)
From: Guenter Roeck <groeck@chromium.org>
0day reports:
>> drivers/gpu/drm/bridge/ti-sn65dsi86.o: In function
`ti_sn_bridge_remove':
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:629: undefined reference to
`mipi_dsi_detach'
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:630: undefined reference to
`mipi_dsi_device_unregister'
drivers/gpu/drm/bridge/ti-sn65dsi86.o: In function
`ti_sn_bridge_attach':
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:249: undefined reference to
`of_find_mipi_dsi_host_by_node'
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:256: undefined reference to
`mipi_dsi_device_register_full'
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:276: undefined reference to
`mipi_dsi_attach'
drivers/gpu/drm/bridge/ti-sn65dsi86.c:289: undefined reference to
`mipi_dsi_device_unregister'
Quite obviously the driver depends on DRM_MIPI_DSI.
We can not use "depends" since the driver configuration uses "select",
so we'll have to select the missing dependency instead.
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Dylan Reid <dgreid@chromium.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
---
Originally uploaded here:
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1176224
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 9a455c5f24f0..9eeb8ef0b174 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -142,6 +142,7 @@ config DRM_TI_SN65DSI86
select DRM_KMS_HELPER
select REGMAP_I2C
select DRM_PANEL
+ select DRM_MIPI_DSI
help
Texas Instruments SN65DSI86 DSI to eDP Bridge driver
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2018-08-15 19:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180815194928epcas1p26c8e12985412e839378341f44145250e@epcas1p2.samsung.com>
2018-08-15 19:49 ` Sean Paul [this message]
2018-08-16 7:31 ` [PATCH] drm/bridge: ti-sn65dsi86: Fix 0-day build error Daniel Vetter
2018-08-16 11:01 ` Guenter Roeck
2018-08-16 15:20 ` Daniel Vetter
2018-08-16 15:47 ` Sean Paul
2018-08-20 15:15 ` Andrzej Hajda
2018-08-20 15:26 ` Guenter Roeck
2018-08-20 16:38 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815194923.3258-1-sean@poorly.run \
--to=sean@poorly.run \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=dgreid@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=groeck@chromium.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).