[PATCH] drm/panel: Fix sphinx warning

[PATCH] drm/panel: Fix sphinx warning

[Sean Paul]

From: Sean Paul <seanpaul@chromium.org>

Resolves the following warnings.
../drivers/gpu/drm/drm_panel.c:158: WARNING: Unexpected indentation.
../drivers/gpu/drm/drm_panel.c:159: WARNING: Block quote ends without a blank line; unexpected unindent.

Fixes: 83127f67e450 ("drm/panel: Flesh out kerneldoc")
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 drivers/gpu/drm/drm_panel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index b902361dee6e..0db486d10d1c 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -152,7 +152,9 @@ EXPORT_SYMBOL(drm_panel_detach);
  *
  * Return: A pointer to the panel registered for the specified device tree
  * node or an ERR_PTR() if no panel matching the device tree node can be found.
+ *
  * Possible error codes returned by this function:
+ *
  * - EPROBE_DEFER: the panel device has not been probed yet, and the caller
  *   should retry later
  * - ENODEV: the device is not available (status != "okay" or "ok")
-- 
Sean Paul, Software Engineer, Google / Chromium OS

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/panel: Fix sphinx warning

[Daniel Vetter]

On Wed, Aug 15, 2018 at 04:38:28PM -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> Resolves the following warnings.
> ../drivers/gpu/drm/drm_panel.c:158: WARNING: Unexpected indentation.
> ../drivers/gpu/drm/drm_panel.c:159: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Fixes: 83127f67e450 ("drm/panel: Flesh out kerneldoc")
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>

I was sitting on this fix since a while, but forgot to send it out :-/

You picked the wrong culprit though, the issue is with the enumeration
formatting below:

Fixes: c59eb3cfde1f ("drm/panel: Let of_drm_find_panel() return -ENODEV when the panel is disabled")
Cc: Boris Brezillon <boris.brezillon@bootlin.com>

With that adjusted: Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/drm_panel.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
> index b902361dee6e..0db486d10d1c 100644
> --- a/drivers/gpu/drm/drm_panel.c
> +++ b/drivers/gpu/drm/drm_panel.c
> @@ -152,7 +152,9 @@ EXPORT_SYMBOL(drm_panel_detach);
>   *
>   * Return: A pointer to the panel registered for the specified device tree
>   * node or an ERR_PTR() if no panel matching the device tree node can be found.
> + *
>   * Possible error codes returned by this function:
> + *
>   * - EPROBE_DEFER: the panel device has not been probed yet, and the caller
>   *   should retry later
>   * - ENODEV: the device is not available (status != "okay" or "ok")
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/panel: Fix sphinx warning

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 759 bytes --]

On Wed, Aug 15, 2018 at 04:38:28PM -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> Resolves the following warnings.
> ../drivers/gpu/drm/drm_panel.c:158: WARNING: Unexpected indentation.
> ../drivers/gpu/drm/drm_panel.c:159: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Fixes: 83127f67e450 ("drm/panel: Flesh out kerneldoc")
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>  drivers/gpu/drm/drm_panel.c | 2 ++
>  1 file changed, 2 insertions(+)

Feel free to push this after addressing Daniel's comments:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/panel: Fix sphinx warning

[Sean Paul]

On Thu, Aug 16, 2018 at 11:24:42AM +0200, Thierry Reding wrote:
> On Wed, Aug 15, 2018 at 04:38:28PM -0400, Sean Paul wrote:
> > From: Sean Paul <seanpaul@chromium.org>
> > 
> > Resolves the following warnings.
> > ../drivers/gpu/drm/drm_panel.c:158: WARNING: Unexpected indentation.
> > ../drivers/gpu/drm/drm_panel.c:159: WARNING: Block quote ends without a blank line; unexpected unindent.
> > 
> > Fixes: 83127f67e450 ("drm/panel: Flesh out kerneldoc")
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Jyri Sarha <jsarha@ti.com>
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> >  drivers/gpu/drm/drm_panel.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Feel free to push this after addressing Daniel's comments:
> 
> Acked-by: Thierry Reding <treding@nvidia.com>

Pushed to -misc-next

Thanks!

Sean




-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel