From: Christoph Hellwig <hch@lst.de>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org,
Lucas Stach <l.stach@pengutronix.de>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC] etnaviv: missing dma_mask
Date: Fri, 17 Aug 2018 08:42:22 +0200 [thread overview]
Message-ID: <20180817064222.GB10811@lst.de> (raw)
In-Reply-To: <20180814141225.6123-1-Eugeniy.Paltsev@synopsys.com>
On Tue, Aug 14, 2018 at 05:12:25PM +0300, Eugeniy Paltsev wrote:
> Hi Lucas, Christoph,
>
> After switching ARC to generic dma_noncoherent cache ops
> etnaviv driver start failing on dma maping functions because of
> dma_mask lack.
>
> So I'm wondering is it valid case to have device which is
> DMA capable and doesn't have dma_mask set?
>
> If not, then I guess something like that should work
> (at least it works for ARC):
This looks ok is a minimal fix:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But why doesn't this device have a dma-range property in DT?
next prev parent reply other threads:[~2018-08-17 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 14:12 [RFC] etnaviv: missing dma_mask Eugeniy Paltsev
2018-08-17 6:42 ` Christoph Hellwig [this message]
2018-08-23 8:54 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817064222.GB10811@lst.de \
--to=hch@lst.de \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=christian.gmeiner@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).