From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/5] drm/vc4: Fix TILE_Y_OFFSET definitions
Date: Fri, 24 Aug 2018 09:42:07 +0200 [thread overview]
Message-ID: <20180824094207.02a4c39b@bbrezillon> (raw)
In-Reply-To: <20180824090926.3b1cdb90@bbrezillon>
On Fri, 24 Aug 2018 09:09:26 +0200
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> On Fri, 3 Aug 2018 11:22:27 +0200
> Boris Brezillon <boris.brezillon@bootlin.com> wrote:
>
> > From: Eric Anholt <eric@anholt.net>
> >
> > Y_OFFSET field starts at bit 8 not 7.
> >
> > Signed-off-by: Eric Anholt <eric@anholt.net>
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
>
> As discussed with Eric 2 weeks ago, I'm about to apply this series to
> drm-misc-fixes. The rational behind this decision is that those patches
> are actually fixing the driver, even though they don't all have Fixes
> and Cc-stable tags.
>
> Daniel, any objection?
Actually it conflicts in a few places because this series was based on
drm-misc-next, so I'll wait for 4.19-rc1 to be back-merged in
drm-misc-fixes before applying the patchset.
>
> > ---
> > Changes in v2:
> > - None
> > ---
> > drivers/gpu/drm/vc4/vc4_regs.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h
> > index d6864fa4bd14..ccbd6b377ffe 100644
> > --- a/drivers/gpu/drm/vc4/vc4_regs.h
> > +++ b/drivers/gpu/drm/vc4/vc4_regs.h
> > @@ -1043,8 +1043,8 @@ enum hvs_pixel_format {
> > #define SCALER_PITCH0_TILE_LINE_DIR BIT(15)
> > #define SCALER_PITCH0_TILE_INITIAL_LINE_DIR BIT(14)
> > /* Y offset within a tile. */
> > -#define SCALER_PITCH0_TILE_Y_OFFSET_MASK VC4_MASK(13, 7)
> > -#define SCALER_PITCH0_TILE_Y_OFFSET_SHIFT 7
> > +#define SCALER_PITCH0_TILE_Y_OFFSET_MASK VC4_MASK(13, 8)
> > +#define SCALER_PITCH0_TILE_Y_OFFSET_SHIFT 8
> > #define SCALER_PITCH0_TILE_WIDTH_R_MASK VC4_MASK(6, 0)
> > #define SCALER_PITCH0_TILE_WIDTH_R_SHIFT 0
> >
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-08-24 7:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 9:22 [PATCH v2 1/5] drm/vc4: Fix TILE_Y_OFFSET definitions Boris Brezillon
2018-08-03 9:22 ` [PATCH v2 2/5] drm/vc4: Define missing PITCH0_SINK_PIX field Boris Brezillon
2018-08-03 9:22 ` [PATCH v2 3/5] drm/vc4: Use drm_atomic_helper_check_plane_state() to simplify the logic Boris Brezillon
2018-08-03 9:22 ` [PATCH v2 4/5] drm/vc4: Move ->offsets[] adjustment out of setup_clipping_and_scaling() Boris Brezillon
2018-08-03 9:22 ` [PATCH v2 5/5] drm/vc4: Fix X/Y positioning of planes using T_TILES modifier Boris Brezillon
2018-08-06 20:02 ` [PATCH v2 1/5] drm/vc4: Fix TILE_Y_OFFSET definitions Eric Anholt
2018-08-06 20:12 ` Boris Brezillon
2018-08-07 0:41 ` Eric Anholt
2018-08-24 7:09 ` Boris Brezillon
2018-08-24 7:42 ` Boris Brezillon [this message]
2018-08-27 19:09 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824094207.02a4c39b@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox