* [radeon-alex:drm-next-4.20-wip 220/235] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used
@ 2018-08-28 20:00 kbuild test robot
2018-08-28 20:00 ` [PATCH] drm/amd/display: fix ptr_ret.cocci warnings kbuild test robot
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-08-28 20:00 UTC (permalink / raw)
To: Nicholas Kazlauskas; +Cc: Alex Deucher, kbuild-all, dri-devel
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.20-wip
head: bdb1922abd620d24715906bac4d119274d98f4c9
commit: e498eb7136042aa9a352b1039c678537f4694158 [220/235] drm/amd/display: Add support for hw_state logging via debugfs
coccinelle warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/amd/display: fix ptr_ret.cocci warnings
2018-08-28 20:00 [radeon-alex:drm-next-4.20-wip 220/235] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot
@ 2018-08-28 20:00 ` kbuild test robot
0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2018-08-28 20:00 UTC (permalink / raw)
To: Nicholas Kazlauskas; +Cc: Alex Deucher, kbuild-all, dri-devel
From: kbuild test robot <fengguang.wu@intel.com>
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: e498eb713604 ("drm/amd/display: Add support for hw_state logging via debugfs")
CC: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.20-wip
head: bdb1922abd620d24715906bac4d119274d98f4c9
commit: e498eb7136042aa9a352b1039c678537f4694158 [220/235] drm/amd/display: Add support for hw_state logging via debugfs
amdgpu_dm_debugfs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -768,8 +768,5 @@ int dtn_debugfs_init(struct amdgpu_devic
adev,
&dtn_log_fops);
- if (IS_ERR(ent))
- return PTR_ERR(ent);
-
- return 0;
+ return PTR_ERR_OR_ZERO(ent);
}
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [radeon-alex:drm-next-4.20-wip 220/310] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used
@ 2018-09-12 0:59 kbuild test robot
2018-09-12 0:59 ` [PATCH] drm/amd/display: fix ptr_ret.cocci warnings kbuild test robot
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-09-12 0:59 UTC (permalink / raw)
To: Nicholas Kazlauskas; +Cc: Alex Deucher, kbuild-all, dri-devel
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.20-wip
head: d8de8260a45aae8f74af77eae9a162bdc0ed48d2
commit: e498eb7136042aa9a352b1039c678537f4694158 [220/310] drm/amd/display: Add support for hw_state logging via debugfs
coccinelle warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/amd/display: fix ptr_ret.cocci warnings
2018-09-12 0:59 [radeon-alex:drm-next-4.20-wip 220/310] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot
@ 2018-09-12 0:59 ` kbuild test robot
2018-09-12 20:14 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-09-12 0:59 UTC (permalink / raw)
To: Nicholas Kazlauskas; +Cc: Alex Deucher, kbuild-all, dri-devel
From: kbuild test robot <fengguang.wu@intel.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: e498eb713604 ("drm/amd/display: Add support for hw_state logging via debugfs")
CC: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.20-wip
head: d8de8260a45aae8f74af77eae9a162bdc0ed48d2
commit: e498eb7136042aa9a352b1039c678537f4694158 [220/310] drm/amd/display: Add support for hw_state logging via debugfs
amdgpu_dm_debugfs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -768,8 +768,5 @@ int dtn_debugfs_init(struct amdgpu_devic
adev,
&dtn_log_fops);
- if (IS_ERR(ent))
- return PTR_ERR(ent);
-
- return 0;
+ return PTR_ERR_OR_ZERO(ent);
}
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amd/display: fix ptr_ret.cocci warnings
2018-09-12 0:59 ` [PATCH] drm/amd/display: fix ptr_ret.cocci warnings kbuild test robot
@ 2018-09-12 20:14 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2018-09-12 20:14 UTC (permalink / raw)
To: Fengguang Wu
Cc: Deucher, Alexander, nicholas.kazlauskas,
Maling list - DRI developers, kbuild-all
On Tue, Sep 11, 2018 at 8:59 PM kbuild test robot
<fengguang.wu@intel.com> wrote:
>
> From: kbuild test robot <fengguang.wu@intel.com>
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Fixes: e498eb713604 ("drm/amd/display: Add support for hw_state logging via debugfs")
> CC: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Applied. thanks!
Alex
> ---
>
> tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.20-wip
> head: d8de8260a45aae8f74af77eae9a162bdc0ed48d2
> commit: e498eb7136042aa9a352b1039c678537f4694158 [220/310] drm/amd/display: Add support for hw_state logging via debugfs
>
> amdgpu_dm_debugfs.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
> @@ -768,8 +768,5 @@ int dtn_debugfs_init(struct amdgpu_devic
> adev,
> &dtn_log_fops);
>
> - if (IS_ERR(ent))
> - return PTR_ERR(ent);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(ent);
> }
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-12 20:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-28 20:00 [radeon-alex:drm-next-4.20-wip 220/235] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot
2018-08-28 20:00 ` [PATCH] drm/amd/display: fix ptr_ret.cocci warnings kbuild test robot
-- strict thread matches above, loose matches on Subject: below --
2018-09-12 0:59 [radeon-alex:drm-next-4.20-wip 220/310] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c:771:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot
2018-09-12 0:59 ` [PATCH] drm/amd/display: fix ptr_ret.cocci warnings kbuild test robot
2018-09-12 20:14 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).