From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
dri-devel@freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH libdrm v2 5/5] intel: get gen once for gen >= 9
Date: Tue, 28 Aug 2018 17:35:32 -0700 [thread overview]
Message-ID: <20180829003532.22878-6-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20180829003532.22878-1-lucas.demarchi@intel.com>
We don't need to call IS_GEN() for each gen >= 9: we can rather use the
new intel_is_genx() helper to iterate the pciids array once.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
intel/intel_bufmgr_gem.c | 8 +-------
intel/intel_decode.c | 8 ++------
2 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index 8c3a4b20..d6587b76 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
@@ -3656,13 +3656,7 @@ drm_intel_bufmgr_gem_init(int fd, int batch_size)
bufmgr_gem->gen = 7;
else if (IS_GEN8(bufmgr_gem->pci_device))
bufmgr_gem->gen = 8;
- else if (IS_GEN9(bufmgr_gem->pci_device))
- bufmgr_gem->gen = 9;
- else if (IS_GEN10(bufmgr_gem->pci_device))
- bufmgr_gem->gen = 10;
- else if (IS_GEN11(bufmgr_gem->pci_device))
- bufmgr_gem->gen = 11;
- else {
+ else if (!intel_get_genx(bufmgr_gem->pci_device, &bufmgr_gem->gen)) {
free(bufmgr_gem);
bufmgr_gem = NULL;
goto exit;
diff --git a/intel/intel_decode.c b/intel/intel_decode.c
index b24861b1..0ff095bc 100644
--- a/intel/intel_decode.c
+++ b/intel/intel_decode.c
@@ -3823,12 +3823,8 @@ drm_intel_decode_context_alloc(uint32_t devid)
ctx->devid = devid;
ctx->out = stdout;
- if (IS_GEN11(devid))
- ctx->gen = 11;
- else if (IS_GEN10(devid))
- ctx->gen = 10;
- else if (IS_GEN9(devid))
- ctx->gen = 9;
+ if (intel_get_genx(devid, &ctx->gen))
+ ;
else if (IS_GEN8(devid))
ctx->gen = 8;
else if (IS_GEN7(devid))
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-08-29 0:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 0:35 [PATCH libdrm v2 0/5] intel: rework how we add PCI IDs Lucas De Marchi
2018-08-29 0:35 ` [PATCH libdrm v2 1/5] intel: add generic functions to check PCI ID Lucas De Marchi
2018-08-31 8:16 ` Chris Wilson
2018-08-31 16:06 ` Lucas De Marchi
2018-08-31 16:13 ` Chris Wilson
2018-08-29 0:35 ` [PATCH libdrm v2 2/5] intel: make gen11 use generic gen macro Lucas De Marchi
2018-08-29 0:35 ` [PATCH libdrm v2 3/5] intel: make gen10 " Lucas De Marchi
2018-08-29 0:35 ` [PATCH libdrm v2 4/5] intel: make gen9 " Lucas De Marchi
2018-08-29 10:32 ` Chris Wilson
2018-08-29 16:01 ` Lucas De Marchi
2018-08-31 8:20 ` Chris Wilson
2018-08-31 8:21 ` Chris Wilson
2018-08-31 16:14 ` Lucas De Marchi
2018-08-29 0:35 ` Lucas De Marchi [this message]
2018-08-29 14:31 ` [PATCH libdrm v2 5/5] intel: get gen once for gen >= 9 Chris Wilson
2018-09-05 18:01 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829003532.22878-6-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=dri-devel@freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).