From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
Cc: "juhapekka.heikkila@intel.com" <juhapekka.heikkila@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Syrjala, Ville" <ville.syrjala@intel.com>,
"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v7 2/2] drm/i915: Adding YUV444 packed format(DRM_FORMAT_XYUV) support.
Date: Fri, 31 Aug 2018 14:09:02 +0300 [thread overview]
Message-ID: <20180831110902.GS5565@intel.com> (raw)
In-Reply-To: <77e66849ccc3a5dbb53f25ad06bae0e093e6df9c.camel@intel.com>
On Fri, Aug 31, 2018 at 07:24:48AM +0000, Lisovskiy, Stanislav wrote:
> On Thu, 2018-08-30 at 11:15 -0700, Dhinakaran Pandiyan wrote:
> > On Thu, 2018-08-30 at 13:57 +0100, Lisovskiy, Stanislav wrote:
> > > On Wed, 2018-08-29 at 12:16 -0700, Dhinakaran Pandiyan wrote:
> > > >
> > > > On Wed, 2018-08-29 at 21:10 +0300, Ville Syrjälä wrote:
> > > > > On Wed, Aug 29, 2018 at 02:28:47PM +0300, Stanislav Lisovskiy
> > > > > wrote:
> > > > > > PLANE_CTL_FORMAT_AYUV is already supported, according to
> > > > > > hardware
> > > > > > specification.
> > > > > >
> > > > > > v2: Edited commit message, removed redundant whitespaces.
> > > > > >
> > > > > > v3: Fixed fallthrough logic for the format switch cases.
> > > > > >
> > > > > > v4: Yet again fixed fallthrough logic, to reuse code from
> > > > > > other
> > > > > > case
> > > > > > labels.
> > > > > >
> > > > > > v5: Started to use XYUV instead of AYUV, as we don't use
> > > > > > alpha.
> >
> > Curious what the reason is. Is it because the hardware does not
> > support
> > alpha with this format?
>
> As I understood yes, this is a hardware limitation.
>
> >
> > > > > >
> > > > > > v6: Removed unneeded initializer for new XYUV format.
> > > > > >
> > > > > > v7: Added scaling support for DRM_FORMAT_XYUV
> > > >
> > > > I don't see yuv formats in skl_format_to_fourcc(), any idea why?
> > >
> > > Good point. I guess would be nice idea to add at least XYUV there
> > > now.
> > > I can add rest of the formats with a separate patch afterwards.
> >
> > Wonder if the expectation is BIOS not use yuv formats. Ville?
>
> I talked to Ville yesterday, I think that was basically what he said.
Yes. Although I have this dream of full plane state readout (which we
could then use for verification purposes at least), so adding the
missing formats there would be a decent idea.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-08-31 11:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 11:28 [PATCH v7 0/2] Add XYUV format support Stanislav Lisovskiy
2018-08-29 11:28 ` [PATCH v7 1/2] drm: Introduce new DRM_FORMAT_XYUV Stanislav Lisovskiy
2018-08-29 11:28 ` [PATCH v7 2/2] drm/i915: Adding YUV444 packed format(DRM_FORMAT_XYUV) support Stanislav Lisovskiy
2018-08-29 18:10 ` [Intel-gfx] " Ville Syrjälä
2018-08-29 19:16 ` Dhinakaran Pandiyan
2018-08-30 12:57 ` Lisovskiy, Stanislav
2018-08-30 18:15 ` Dhinakaran Pandiyan
2018-08-31 7:24 ` [Intel-gfx] " Lisovskiy, Stanislav
2018-08-31 11:09 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831110902.GS5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=juhapekka.heikkila@intel.com \
--cc=stanislav.lisovskiy@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).