From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Reject unknown legacy bpp and dpeth for drm_mode_addfb ioctl Date: Tue, 4 Sep 2018 23:46:33 +0200 Message-ID: <20180904214633.GU21634@phenom.ffwll.local> References: <20180904205319.11174-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180904205319.11174-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDk6NTM6MTlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFNpbmNlIHRoaXMgaXMgaGFuZGxpbmcgdXNlciBwcm92aWRlZCBicHAgYW5kIGRlcHRo LCB3ZSBuZWVkIHRvIHNhbml0eQo+IGNoZWNrIGFuZCBwcm9wYWdhdGUgdGhlIEVJTlZBTCBiYWNr IHJhdGhlciB0aGFuIGFzc3VtZSB3aGF0IHRoZSBpbnNhbmUKPiBjbGllbnQgaW50ZW5kZWQgYW5k IGZpbGwgdGhlIGxvZ3Mgd2l0aCBEUk1fRVJST1IuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMg V2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRh bmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gU28gSSBhbSBwcmVzdW1pbmcgdGhhdCByLnBpeGVs X2Zvcm1hdCA9PSAwIGlzIHJlamVjdGVkIGVsc2V3aGVyZSBmb3IgdGhlCj4gaW50ZXJuYWwgdXNl cnMgKGFzIGlmIGFueSB3b3VsZCBkZWxpYmVyYXRlbHkgcHJvdm9rZSB0aGUgZXJyb3IpIQoKQ291 bGQgbWF5YmUgYWRkIGEgRFJNX0ZPUk1BVF9JTlZBTElEIGF0IHRoZSBlbmQgb2YgZHJtX2ZvdXJj Yy5oLCBhbmQgdGhlbgpzd2l0Y2ggb3ZlciB0aGUgdmFyaW91cyBmb3JtYXQvbW9kaWZpZXIgdGFi bGVzIHRvIGJlaW5nIHplcm8gdGVybWluYXRlZC4KV2VsbCBEUk1fRk9STUFUX01PRF9JTlZBTElE IGNhbid0IGJlIDAgYmVjYXVzZSB0aGF0IG1lYW5zIGxpbmVhci4gQW55d2F5LApJIGRpZ3Jlc3Ms IHRoaXMgbG9rcyBnb29kLgoKQW5kIHllcyBkcm1faW50ZXJuYWxfZnJhbWVidWZmZXJfY3JlYXRl IG1ha2VzIHN1cmUgeW91IGhhdmUgYSByZWFsIGZvdXJjYwpjb2RlLCBub3QgYSBmaWdtZW50IG9m IHlvdXIgaW1hZ2luYXRpb24gKG9yIG1vcmUgcHJvZmFuZSwgc3RhY2sgZ2FyYmFnZSkuCgpSZXZp ZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KClNhbWUgYXMg d2l0aCB0aGUgcHJldmlvdXMgb25lLCBpZ3Qgd291bGQgYmUgc3dlZXQgb24gdG9wLgotRGFuaWVs Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jICAgICAgfCA0ICsrLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jIHwgNSArKysrLQo+ICAyIGZpbGVzIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm91cmNj LmMKPiBpbmRleCAzNWMxZTI3NDJjMjcuLjM0NTk1YzViNTVjOSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mb3Vy Y2MuYwo+IEBAIC02OSw4ICs2OSw4IEBAIHVpbnQzMl90IGRybV9tb2RlX2xlZ2FjeV9mYl9mb3Jt YXQodWludDMyX3QgYnBwLCB1aW50MzJfdCBkZXB0aCkKPiAgCQkJZm10ID0gRFJNX0ZPUk1BVF9B UkdCODg4ODsKPiAgCQlicmVhazsKPiAgCWRlZmF1bHQ6Cj4gLQkJRFJNX0VSUk9SKCJiYWQgYnBw LCBhc3N1bWluZyB4OHI4ZzhiOCBwaXhlbCBmb3JtYXRcbiIpOwo+IC0JCWZtdCA9IERSTV9GT1JN QVRfWFJHQjg4ODg7Cj4gKwkJRFJNX0RFQlVHKCJiYWQgYnBwIFslZF0gYW5kIGRlcHRoIFslZF1c biIsIGJwcCwgZGVwdGgpOwo+ICsJCWZtdCA9IDA7Cj4gIAkJYnJlYWs7Cj4gIAl9Cj4gIAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiBpbmRleCA3ODFhZjFkNDJkNzYuLjc2NDFiZGRmZTM2 NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiBAQCAtMTEyLDEyICsxMTIsMTUg QEAgaW50IGRybV9tb2RlX2FkZGZiKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1f bW9kZV9mYl9jbWQgKm9yLAo+ICAJc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgciA9IHt9Owo+ICAJ aW50IHJldDsKPiAgCj4gKwlyLnBpeGVsX2Zvcm1hdCA9IGRybV9tb2RlX2xlZ2FjeV9mYl9mb3Jt YXQob3ItPmJwcCwgb3ItPmRlcHRoKTsKPiArCWlmICghci5waXhlbF9mb3JtYXQpCj4gKwkJcmV0 dXJuIC1FSU5WQUw7Cj4gKwo+ICAJLyogY29udmVydCB0byBuZXcgZm9ybWF0IGFuZCBjYWxsIG5l dyBpb2N0bCAqLwo+ICAJci5mYl9pZCA9IG9yLT5mYl9pZDsKPiAgCXIud2lkdGggPSBvci0+d2lk dGg7Cj4gIAlyLmhlaWdodCA9IG9yLT5oZWlnaHQ7Cj4gIAlyLnBpdGNoZXNbMF0gPSBvci0+cGl0 Y2g7Cj4gLQlyLnBpeGVsX2Zvcm1hdCA9IGRybV9tb2RlX2xlZ2FjeV9mYl9mb3JtYXQob3ItPmJw cCwgb3ItPmRlcHRoKTsKPiAgCXIuaGFuZGxlc1swXSA9IG9yLT5oYW5kbGU7Cj4gIAo+ICAJaWYg KHIucGl4ZWxfZm9ybWF0ID09IERSTV9GT1JNQVRfWFJHQjIxMDEwMTAgJiYKPiAtLSAKPiAyLjE5 LjAucmMxCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==