From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm: Reject unknown legacy bpp and depth
 for drm_mode_addfb ioctl
Date: Wed, 5 Sep 2018 16:28:11 +0200
Message-ID: <20180905142811.GE4929@phenom.ffwll.local>
References: <20180904205319.11174-1-chris@chris-wilson.co.uk>
 <20180905102205.5472-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20180905102205.5472-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMTE6MjI6MDVBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFNpbmNlIHRoaXMgaXMgaGFuZGxpbmcgdXNlciBwcm92aWRlZCBicHAgYW5kIGRlcHRo
LCB3ZSBuZWVkIHRvIHNhbml0eQo+IGNoZWNrIGFuZCBwcm9wYWdhdGUgdGhlIEVJTlZBTCBiYWNr
IHJhdGhlciB0aGFuIGFzc3VtZSB3aGF0IHRoZSBpbnNhbmUKPiBjbGllbnQgaW50ZW5kZWQgYW5k
IGZpbGwgdGhlIGxvZ3Mgd2l0aCBEUk1fRVJST1IuCj4gCj4gdjI6IENoZWNrIGJvdGggYnBwIGFu
ZCBkZXB0aCBtYXRjaCB0aGUgYnVpbHRpbiBwaXhlbCBmb3JtYXQsIGFuZAo+IGludHJvZHVjZSBh
IGNhbm9uaWNhbCBEUk1fRk9STUFUX0lOVkFMSUQgdG8gcmVzZXJ2ZSAwIGFnYWluc3QgYW55IGZ1
dHVyZQo+IGZvdXJjYy4KPiAKPiBUZXN0Y2FzZTogaWd0L2ttc19hZGRmYl9iYXNpYy9sZWdhY3kt
Zm9ybWF0Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24u
Y28udWs+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6
IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpJIGNoZWNr
ZWQgYSBidW5jaCBvZiByYW5kb21seSBzZWxlY3RlZCB1c2Vyc3BhY2UgcGllY2VzLCBhbmQgaWYg
dGhlcmUncwpoYWlyeSBzdHVmZiBnb2luZyBvbiB0aGVuIGl0J3MgbWlzLXNlbGVjdGVkIGJwcC4K
PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYyAgICAgIHwgMzMgKysrKysrKysr
KysrKysrKysrKysrLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVy
LmMgfCAgNyArKysrKystCj4gIGluY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oICAgICB8ICAz
ICsrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygt
KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jIGIvZHJpdmVy
cy9ncHUvZHJtL2RybV9mb3VyY2MuYwo+IGluZGV4IDM1YzFlMjc0MmMyNy4uZDlkYWRiYzQzMzI3
IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm91cmNjLmMKPiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jCj4gQEAgLTQ1LDMyICs0NSw0NSBAQCBzdGF0aWMgY2hh
ciBwcmludGFibGVfY2hhcihpbnQgYykKPiAgICovCj4gIHVpbnQzMl90IGRybV9tb2RlX2xlZ2Fj
eV9mYl9mb3JtYXQodWludDMyX3QgYnBwLCB1aW50MzJfdCBkZXB0aCkKPiAgewo+IC0JdWludDMy
X3QgZm10Owo+ICsJdWludDMyX3QgZm10ID0gRFJNX0ZPUk1BVF9JTlZBTElEOwo+ICAKPiAgCXN3
aXRjaCAoYnBwKSB7Cj4gIAljYXNlIDg6Cj4gLQkJZm10ID0gRFJNX0ZPUk1BVF9DODsKPiArCQlp
ZiAoZGVwdGggPT0gMCkKPiArCQkJZm10ID0gRFJNX0ZPUk1BVF9DODsKCk1pY2hlbCBEw6RuemVy
IHRoaW5rcyB0aGlzIHNob3VsZCBiZSBkZXB0aCA9PSA4IGhlcmUuIEkgZ3JlcHBlZCBhcm91bmQg
aW4KLW1vZGVzZXR0aW5nLCBzZWVtcyBvdXRyaWdodCBub3Qgc3VwcG9ydGVkLiBBcHBhcmVudGx5
IGFtZCBkcml2ZXJzIGRvCnN1cHBvcnQgaXQsIGFuZCBzZXQgOC84LiBXaXRoIHRoYXQgYWRkcmVz
c2VkOgoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+
CgoKPiAgCQlicmVhazsKPiAgCWNhc2UgMTY6Cj4gLQkJaWYgKGRlcHRoID09IDE1KQo+ICsJCXN3
aXRjaCAoZGVwdGgpIHsKPiArCQljYXNlIDE1Ogo+ICAJCQlmbXQgPSBEUk1fRk9STUFUX1hSR0Ix
NTU1Owo+IC0JCWVsc2UKPiArCQkJYnJlYWs7Cj4gKwkJY2FzZSAxNjoKPiAgCQkJZm10ID0gRFJN
X0ZPUk1BVF9SR0I1NjU7Cj4gKwkJCWJyZWFrOwo+ICsJCWRlZmF1bHQ6Cj4gKwkJCWJyZWFrOwo+
ICsJCX0KPiAgCQlicmVhazsKPiAgCWNhc2UgMjQ6Cj4gLQkJZm10ID0gRFJNX0ZPUk1BVF9SR0I4
ODg7Cj4gKwkJaWYgKGRlcHRoID09IDI0KQo+ICsJCQlmbXQgPSBEUk1fRk9STUFUX1JHQjg4ODsK
PiAgCQlicmVhazsKPiAgCWNhc2UgMzI6Cj4gLQkJaWYgKGRlcHRoID09IDI0KQo+ICsJCXN3aXRj
aCAoZGVwdGgpIHsKPiArCQljYXNlIDI0Ogo+ICAJCQlmbXQgPSBEUk1fRk9STUFUX1hSR0I4ODg4
Owo+IC0JCWVsc2UgaWYgKGRlcHRoID09IDMwKQo+ICsJCQlicmVhazsKPiArCQljYXNlIDMwOgo+
ICAJCQlmbXQgPSBEUk1fRk9STUFUX1hSR0IyMTAxMDEwOwo+IC0JCWVsc2UKPiArCQkJYnJlYWs7
Cj4gKwkJY2FzZSAzMjoKPiAgCQkJZm10ID0gRFJNX0ZPUk1BVF9BUkdCODg4ODsKPiArCQkJYnJl
YWs7Cj4gKwkJZGVmYXVsdDoKPiArCQkJYnJlYWs7Cj4gKwkJfQo+ICAJCWJyZWFrOwo+ICAJZGVm
YXVsdDoKPiAtCQlEUk1fRVJST1IoImJhZCBicHAsIGFzc3VtaW5nIHg4cjhnOGI4IHBpeGVsIGZv
cm1hdFxuIik7Cj4gLQkJZm10ID0gRFJNX0ZPUk1BVF9YUkdCODg4ODsKPiAgCQlicmVhazsKPiAg
CX0KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYyBi
L2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+IGluZGV4IDc4MWFmMWQ0MmQ3Ni4u
NjM2ZjYyNmM1ODI4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZm
ZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+IEBAIC0xMTIs
MTIgKzExMiwxNyBAQCBpbnQgZHJtX21vZGVfYWRkZmIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwg
c3RydWN0IGRybV9tb2RlX2ZiX2NtZCAqb3IsCj4gIAlzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiBy
ID0ge307Cj4gIAlpbnQgcmV0Owo+ICAKPiArCXIucGl4ZWxfZm9ybWF0ID0gZHJtX21vZGVfbGVn
YWN5X2ZiX2Zvcm1hdChvci0+YnBwLCBvci0+ZGVwdGgpOwo+ICsJaWYgKHIucGl4ZWxfZm9ybWF0
ID09IERSTV9GT1JNQVRfSU5WQUxJRCkgewo+ICsJCURSTV9ERUJVRygiYmFkIChicHA6JWQsIGRl
cHRoOiVkKVxuIiwgb3ItPmJwcCwgb3ItPmRlcHRoKTsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiAr
CX0KPiArCj4gIAkvKiBjb252ZXJ0IHRvIG5ldyBmb3JtYXQgYW5kIGNhbGwgbmV3IGlvY3RsICov
Cj4gIAlyLmZiX2lkID0gb3ItPmZiX2lkOwo+ICAJci53aWR0aCA9IG9yLT53aWR0aDsKPiAgCXIu
aGVpZ2h0ID0gb3ItPmhlaWdodDsKPiAgCXIucGl0Y2hlc1swXSA9IG9yLT5waXRjaDsKPiAtCXIu
cGl4ZWxfZm9ybWF0ID0gZHJtX21vZGVfbGVnYWN5X2ZiX2Zvcm1hdChvci0+YnBwLCBvci0+ZGVw
dGgpOwo+ICAJci5oYW5kbGVzWzBdID0gb3ItPmhhbmRsZTsKPiAgCj4gIAlpZiAoci5waXhlbF9m
b3JtYXQgPT0gRFJNX0ZPUk1BVF9YUkdCMjEwMTAxMCAmJgo+IGRpZmYgLS1naXQgYS9pbmNsdWRl
L3VhcGkvZHJtL2RybV9mb3VyY2MuaCBiL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4g
aW5kZXggMmVkNDZlOWFlMTZhLi4xMzk2MzJiODcxODEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS91
YXBpL2RybS9kcm1fZm91cmNjLmgKPiArKysgYi9pbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2Mu
aAo+IEBAIC03MSw2ICs3MSw5IEBAIGV4dGVybiAiQyIgewo+ICAKPiAgI2RlZmluZSBEUk1fRk9S
TUFUX0JJR19FTkRJQU4gKDE8PDMxKSAvKiBmb3JtYXQgaXMgYmlnIGVuZGlhbiBpbnN0ZWFkIG9m
IGxpdHRsZSBlbmRpYW4gKi8KPiAgCj4gKy8qIFJlc2VydmUgMCBmb3IgdGhlIGludmFsaWQgZm9y
bWF0IHNwZWNpZmllciAqLwo+ICsjZGVmaW5lIERSTV9GT1JNQVRfSU5WQUxJRAkwCj4gKwo+ICAv
KiBjb2xvciBpbmRleCAqLwo+ICAjZGVmaW5lIERSTV9GT1JNQVRfQzgJCWZvdXJjY19jb2RlKCdD
JywgJzgnLCAnICcsICcgJykgLyogWzc6MF0gQyAqLwo+ICAKPiAtLSAKPiAyLjE5LjAucmMxCj4g
CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K
aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl
c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v
aW50ZWwtZ2Z4Cg==