From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 4/6] drm: fix drm_mode_addfb() on big endian machines. Date: Wed, 5 Sep 2018 20:19:19 +0200 Message-ID: <20180905181919.GH4929@phenom.ffwll.local> References: <20180905060445.15008-1-kraxel@redhat.com> <20180905060445.15008-5-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFC8A6E533 for ; Wed, 5 Sep 2018 18:19:23 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id d8-v6so6871189edv.0 for ; Wed, 05 Sep 2018 11:19:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180905060445.15008-5-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: David Airlie , michel@daenzer.net, Sean Paul , open list , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMDg6MDQ6NDNBTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBVc2Vyc3BhY2Ugb24gYmlnIGVuZGlhbiBtYWNoaGluZXMgdHlwaWNhbGx5IGV4cGVj dHMgdGhlIEFEREZCIGlvY3RsCj4gcmV0dXJucyBhIGJpZyBlbmRpYW4gZnJhbWVidWZmZXIuICBk cm1fbW9kZV9hZGRmYigpIHdpbGwgY2FsbAo+IGRybV9tb2RlX2FkZGZiMigpIHVuY29uZGl0aW9u YWxseSB3aXRoIGxpdHRsZSBlbmRpYW4gRFJNX0ZPUk1BVF8qCj4gdmFsdWVzIHRob3VnaCwgd2hp Y2ggaXMgd3JvbmcuICBUaGlzIHBhdGNoIGZpeGVzIHRoYXQuCj4gCj4gRHJpdmVycyAoYm90aCBr ZXJuZWwgYW5kIHhvcmcpIGhhdmUgcXVpcmtzIGluIHBsYWNlIHRvIGRlYWwgd2l0aCB0aGUKPiBi cm9rZW4gZHJtX21vZGVfYWRkZmIoKSBiZWhhdmlvci4gIEJlY2F1c2Ugb2YgdGhpcyB3ZSBjYW4n dCBqdXN0IGNoYW5nZQo+IGRybV9tb2RlX2FkZGZiKCkgYmVoYXZpb3IgZm9yIGV2ZXJ5Ym9keSB3 aXRob3V0IGJyZWFraW5nIHRoaW5ncy4gIEFkZAo+IHRoZSBxdWlya19hZGRmYl9wcmVmZXJfaG9z dF9ieXRlX29yZGVyIGZpZWxkIHRvIG1vZGVfY29uZmlnLCBzbyBkcml2ZXJzCj4gY2FuIG9wdC1p bi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4K PiAtLS0KPiAgaW5jbHVkZS9kcm0vZHJtX21vZGVfY29uZmlnLmggICAgIHwgMTQgKysrKysrKysr KysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jIHwgMTEgKysrKysrKysr KysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvZHJtL2RybV9tb2RlX2NvbmZpZy5oIGIvaW5jbHVkZS9kcm0vZHJtX21vZGVfY29u ZmlnLmgKPiBpbmRleCA1ZDI5ZjRiYTZmLi42NTAyMDA4NmM5IDEwMDY0NAo+IC0tLSBhL2luY2x1 ZGUvZHJtL2RybV9tb2RlX2NvbmZpZy5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX21vZGVfY29u ZmlnLmgKPiBAQCAtODExLDYgKzgxMSwyMCBAQCBzdHJ1Y3QgZHJtX21vZGVfY29uZmlnIHsKPiAg CXVpbnQzMl90IHByZWZlcnJlZF9kZXB0aCwgcHJlZmVyX3NoYWRvdzsKPiAgCWJvb2wgcXVpcmtf YWRkZmJfcHJlZmVyX3hiZ3JfMzBicHA7Cj4gIAo+ICsJLyoKClRoaXMgZG9lc24ndCBwYXJzZSwg bmVlZHMgLyoqCgokIG1ha2UgaHRtbGRvY3MKCnRvIGNoZWNrIGl0LgoKPiArCSAqIEBxdWlya19h ZGRmYl9wcmVmZXJfaG9zdF9ieXRlX29yZGVyOgo+ICsJICoKPiArCSAqIFdoZW4gc2V0IHRvIHRy dWUgZHJtX21vZGVfYWRkZmIoKSB3aWxsIHBpY2sgaG9zdCBieXRlIG9yZGVyCj4gKwkgKiBwaXhl bF9mb3JtYXQgd2hlbiBjYWxsaW5nIGRybV9tb2RlX2FkZGZiMigpLiAgVGhpcyBpcyBob3cKPiAr CSAqIGRybV9tb2RlX2FkZGZiKCkgc2hvdWxkIGhhdmUgd29ya2VkIGZyb20gZGF5IG9uZS4gIEl0 Cj4gKwkgKiBkaWRuJ3QgdGhvdWdoLCBzbyB3ZSBlbmRlZCB1cCB3aXRoIHF1aXJrcyBpbiBib3Ro IGtlcm5lbAo+ICsJICogYW5kIHVzZXJzcGFjZSBkcml2ZXJzIHRvIGRlYWwgd2l0aCB0aGUgYnJv a2VuIGJlaGF2aW9yLgo+ICsJICogU2ltcGx5IGZpeGluZyBkcm1fbW9kZV9hZGRmYigpIHVuY29u ZGl0aW9uYWxseSB3b3VsZCBicmVhawo+ICsJICogdGhlc2UgZHJpdmVycywgc28gYWRkIGEgcXVp cmsgYml0IGhlcmUgdG8gYWxsb3cgZHJpdmVycwo+ICsJICogb3B0LWluLgo+ICsJICovCj4gKwli b29sIHF1aXJrX2FkZGZiX3ByZWZlcl9ob3N0X2J5dGVfb3JkZXI7CgpJIHdvbmRlciB3aGV0aGVy IHdlIHNob3VsZCByZWplY3QgYWRkRkIyIG9uIGJpZyBlbmRpYW4gaG9zdHMgaWYgdGhpcyBpc24n dApzZXQuIE90aGVyd2lzZSB3ZSBuZWVkIGFkZGZiMywgYWthIHdpbGwgbmV2ZXIgYmUgYWJsZSB0 byBmaXggdGhpcy4gQW55d2F5LAp0aGF0IG1pZ2h0IGJlIGdvb2Qgd29yayBmb3IgYSBmb2xsb3ct dXAgLi4uCgpVcCB0byB0aGlzIHBhdGNoIHNlcmllcyAod2l0aCB0aGUga2VybmVsZG9jIGZpeGVk KToKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoK PiArCj4gIAkvKioKPiAgCSAqIEBhc3luY19wYWdlX2ZsaXA6IERvZXMgdGhpcyBkZXZpY2Ugc3Vw cG9ydCBhc3luYyBmbGlwcyBvbiB0aGUgcHJpbWFyeQo+ICAJICogcGxhbmU/Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZnJhbWVidWZmZXIuYwo+IGluZGV4IDg4OGM0ZDUzY2YuLmY4NjNmOGEyMGYgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jCj4gQEAgLTEyNCw2ICsxMjQsMTcgQEAgaW50IGRybV9t b2RlX2FkZGZiKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQg Km9yLAo+ICAJICAgIHIucGl4ZWxfZm9ybWF0ID09IERSTV9GT1JNQVRfWFJHQjIxMDEwMTApCj4g IAkJci5waXhlbF9mb3JtYXQgPSBEUk1fRk9STUFUX1hCR1IyMTAxMDEwOwo+ICAKPiArCWlmIChk ZXYtPm1vZGVfY29uZmlnLnF1aXJrX2FkZGZiX3ByZWZlcl9ob3N0X2J5dGVfb3JkZXIpIHsKPiAr CQlpZiAoci5waXhlbF9mb3JtYXQgPT0gRFJNX0ZPUk1BVF9YUkdCODg4OCkKPiArCQkJci5waXhl bF9mb3JtYXQgPSBEUk1fRk9STUFUX0hPU1RfWFJHQjg4ODg7Cj4gKwkJaWYgKHIucGl4ZWxfZm9y bWF0ID09IERSTV9GT1JNQVRfQVJHQjg4ODgpCj4gKwkJCXIucGl4ZWxfZm9ybWF0ID0gRFJNX0ZP Uk1BVF9IT1NUX0FSR0I4ODg4Owo+ICsJCWlmIChyLnBpeGVsX2Zvcm1hdCA9PSBEUk1fRk9STUFU X1JHQjU2NSkKPiArCQkJci5waXhlbF9mb3JtYXQgPSBEUk1fRk9STUFUX0hPU1RfUkdCNTY1Owo+ ICsJCWlmIChyLnBpeGVsX2Zvcm1hdCA9PSBEUk1fRk9STUFUX1hSR0IxNTU1KQo+ICsJCQlyLnBp eGVsX2Zvcm1hdCA9IERSTV9GT1JNQVRfSE9TVF9YUkdCMTU1NTsKPiArCX0KPiArCj4gIAlyZXQg PSBkcm1fbW9kZV9hZGRmYjIoZGV2LCAmciwgZmlsZV9wcml2KTsKPiAgCWlmIChyZXQpCj4gIAkJ cmV0dXJuIHJldDsKPiAtLSAKPiAyLjkuMwo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5n aW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=