From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/7] drm: Drop drmP.h from drm_connector.c
Date: Wed, 5 Sep 2018 21:44:36 +0200 [thread overview]
Message-ID: <20180905194436.GA26243@ravnborg.org> (raw)
In-Reply-To: <CAKMK7uG58awwedGB6Rp+CMtSPFPt_f7jU_ayhtZ9RGuCtXFk=g@mail.gmail.com>
>
> > 2) patch revision info belongs outside the changelog part - no?
>
> If it's information worth writing it's information worth recording. In
> drm we're pretty much ok with whatever you feel like, and most people
> include the patch revision in the commit message. Too many cases where
> critical information was left out and a patch made no sense at all
> anymore half a year down the road.
Noted, thanks for the explanation.
Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-09-05 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 13:57 [PATCH 1/7] drm: Add drm/drm_util.h header file Daniel Vetter
2018-09-05 13:57 ` [PATCH 2/7] drm: Drop drmP.h from drm_connector.c Daniel Vetter
2018-09-05 17:12 ` Sam Ravnborg
2018-09-05 17:22 ` Daniel Vetter
2018-09-05 19:44 ` Sam Ravnborg [this message]
2018-09-05 13:57 ` [PATCH 3/7] drm: drop drmP.h include from drm_plane.c Daniel Vetter
2018-09-05 13:57 ` [PATCH 4/7] drm: drop drmP.h include from drm_crtc.c Daniel Vetter
2018-09-05 13:57 ` [PATCH 5/7] drm/atomic: trim driver interface/docs Daniel Vetter
2018-09-06 9:46 ` Heiko Stuebner
2018-09-05 13:57 ` [PATCH 6/7] drm: Update todo.rst Daniel Vetter
2018-09-05 18:15 ` [PATCH] " Daniel Vetter
2018-09-06 9:40 ` Heiko Stuebner
2018-09-06 13:28 ` Emil Velikov
2018-09-09 12:10 ` Daniel Vetter
[not found] ` <20180905135711.28370-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-09-05 13:57 ` [PATCH 7/7] drm: extract drm_atomic_uapi.c Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905194436.GA26243@ravnborg.org \
--to=sam@ravnborg.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox