Re: [PATCH libdrm v3 0/5] intel: rework how we add PCI IDs

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Sep 05, 2018 at 08:56:44PM +0100, Chris Wilson wrote:
> Quoting Lucas De Marchi (2018-09-05 19:31:55)
> > Adding PCI IDs to different projects is a boring manual task that
> > motivated me to create this series. The idea is to centralize the IDs in
> > the kernel header and let other projects copy it.
> > 
> > Initially my plan was to convert all gens, back to gen2, but that proved
> > slightly difficult since there are some corner cases to cover and I
> > didn't want to block the important part, i.e.:  for recent gens, there's
> > no risk of missing a PCI ID.
> > 
> > v2: address comments from Chris by pulling it out to a separate .c
> > v3: remove/add comments on first patch and rebase the rest
> > 
> > Discussed on v2 but left for later:
> >         - replace intel_is_genx() with a simple check for bufmgr->gen,
> >           after making sure said variable is initialized on all code
> >           paths.
> >         - treat unknown gen as a future gen
> >         - convert gen < 9 to use the new header
> > 
> > Lucas De Marchi (5):
> >   intel: add generic functions to check PCI ID
> >   intel: make gen11 use generic gen macro
> >   intel: make gen10 use generic gen macro
> >   intel: make gen9 use generic gen macro
> >   intel: get gen once for gen >= 9
> 
> The opens are fine and I didn't find anything else to question, so the
> series is
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

pushed, thanks for patches and reviews.

> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx