From: Eric Engestrom <eric.engestrom@intel.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Daniel Stone <daniels@collabora.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH libdrm] gitlab-ci: use variables to deduplicate the build commands
Date: Thu, 6 Sep 2018 17:01:59 +0100 [thread overview]
Message-ID: <20180906160159.nowwwd3ly7bnlbwx@intel.com> (raw)
In-Reply-To: <CACvgo5228bcoWRSenrnHDP0qkReHE=ayrQmhCmwG8PP2uAh+LQ@mail.gmail.com>
On Thursday, 2018-09-06 16:01:15 +0100, Emil Velikov wrote:
> On 6 September 2018 at 14:40, Eric Engestrom <eric.engestrom@intel.com> wrote:
> > Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
> > ---
> > .gitlab-ci.yml | 129 ++++++++++++++++++-------------------------------
> > 1 file changed, 47 insertions(+), 82 deletions(-)
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index eee6abfcdd7de2839660..1dc434a5d359b3b077e7 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -1,3 +1,46 @@
> > +.meson-build: &meson-build
>
> Gitlab calls these templates, not variables. With that fixed
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Thanks, I should've looked that up :]
Fixed and pushed.
>
> -Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-09-06 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 13:40 [PATCH libdrm] gitlab-ci: use variables to deduplicate the build commands Eric Engestrom
2018-09-06 15:01 ` Emil Velikov
2018-09-06 16:01 ` Eric Engestrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906160159.nowwwd3ly7bnlbwx@intel.com \
--to=eric.engestrom@intel.com \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox