dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 19/20] drm/zte: Use drm_fbdev_generic_setup()
Date: Mon, 10 Sep 2018 09:23:43 +0800	[thread overview]
Message-ID: <20180910012341.GA22786@dragon> (raw)
In-Reply-To: <20180908134648.2582-20-noralf@tronnes.org>

On Sat, Sep 08, 2018 at 03:46:47PM +0200, Noralf Trønnes wrote:
> The CMA helper is already using the drm_fb_helper_generic_probe part of
> the generic fbdev emulation. This patch makes full use of the generic
> fbdev emulation by using its drm_client callbacks. This means that
> drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
> now handled by the emulation code. Additionally fbdev unregister happens
> automatically on drm_dev_unregister().
> 
> The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
> driver. This is done to highlight the fact that fbdev emulation is an
> internal client that makes use of the driver, it is not part of the
> driver as such. If fbdev setup fails, an error is printed, but the driver
> succeeds probing.
> 
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>

Acked-by: Shawn Guo <shawnguo@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-09-10  1:25 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-08 13:46 [PATCH 00/20] drm/cma-helper drivers: Use drm_fbdev_generic_setup() Noralf Trønnes
2018-09-08 13:46 ` [PATCH 01/20] drm/fb-helper: Improve error reporting in setup Noralf Trønnes
2018-09-25  9:46   ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 02/20] drm/arc: Use drm_fbdev_generic_setup() Noralf Trønnes
2018-09-10 12:31   ` Alexey Brodkin
2018-09-10 13:00     ` Noralf Trønnes
2018-09-28  7:34   ` Alexey Brodkin
2018-09-28 10:42     ` Noralf Trønnes
2018-10-01  7:56       ` Alexey Brodkin
2018-10-01 12:05         ` Noralf Trønnes
2018-10-01 12:06           ` Alexey Brodkin
2018-09-08 13:46 ` [PATCH 03/20] drm/fsl-dcu: " Noralf Trønnes
2018-09-27 21:08   ` Stefan Agner
2018-09-27 21:23     ` Noralf Trønnes
2018-09-28 14:11       ` Stefan Agner
2018-09-28 14:57         ` Noralf Trønnes
2018-09-28 15:00           ` Stefan Agner
2018-09-08 13:46 ` [PATCH 04/20] drm/hisilicon/kirin: " Noralf Trønnes
2018-09-08 13:46 ` [PATCH 05/20] drm/meson: " Noralf Trønnes
2018-09-12  9:48   ` Neil Armstrong
2018-09-12  9:56     ` Maxime Ripard
2018-09-12 10:57       ` Noralf Trønnes
2018-09-12 11:06         ` Noralf Trønnes
2018-09-13 13:21           ` Daniel Vetter
2018-09-13 14:26             ` Neil Armstrong
2018-09-13 14:55               ` Daniel Vetter
2018-09-14  8:23                 ` Neil Armstrong
2018-09-14  8:51                   ` Daniel Vetter
2018-09-14 16:33                   ` Noralf Trønnes
2018-09-17  7:53                     ` Neil Armstrong
2018-10-01 12:27                       ` Neil Armstrong
2018-10-03 19:24   ` Neil Armstrong
2018-10-25 15:09     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 06/20] drm/mxsfb: " Noralf Trønnes
2018-09-08 13:46 ` [PATCH 07/20] drm/rcar-du: " Noralf Trønnes
2018-09-09 14:00   ` Sam Ravnborg
2018-09-09 14:13   ` Laurent Pinchart
2018-09-10 13:02     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 08/20] drm/arm/hdlcd: " Noralf Trønnes
2018-09-11 12:17   ` Liviu Dudau
2018-09-11 12:41     ` Noralf Trønnes
2018-09-25  9:47     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 09/20] drm/arm/mali: " Noralf Trønnes
2018-09-11 12:18   ` Liviu Dudau
2018-09-25  9:47     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 10/20] drm/atmel-hlcdc: " Noralf Trønnes
2018-09-08 13:46 ` [PATCH 11/20] drm/imx: " Noralf Trønnes
2018-09-14 11:42   ` Philipp Zabel
2018-09-25  9:48     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 12/20] drm/pl111: " Noralf Trønnes
2018-09-13  0:07   ` Eric Anholt
2018-09-25  9:48     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 13/20] drm/sti: " Noralf Trønnes
2018-09-10  9:39   ` Benjamin Gaignard
2018-09-25  9:48     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 14/20] drm/stm: " Noralf Trønnes
2018-09-27 11:45   ` Yannick FERTRE
2018-10-25 15:10     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 15/20] drm/sun4i: " Noralf Trønnes
2018-09-10  7:28   ` Maxime Ripard
2018-09-10 12:57     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 16/20] drm/tilcdc: " Noralf Trønnes
2018-09-08 13:46 ` [PATCH 17/20] drm/tve200: " Noralf Trønnes
2018-09-18 22:10   ` Linus Walleij
2018-09-25  9:49     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 18/20] drm/vc4: " Noralf Trønnes
2018-09-13  0:06   ` Eric Anholt
2018-09-25  9:49     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 19/20] drm/zte: " Noralf Trønnes
2018-09-10  1:23   ` Shawn Guo [this message]
2018-09-25  9:49     ` Noralf Trønnes
2018-09-08 13:46 ` [PATCH 20/20] drm/cma-helper: Remove unused fbdev code Noralf Trønnes
2018-09-09 14:09 ` [PATCH 00/20] drm/cma-helper drivers: Use drm_fbdev_generic_setup() Sam Ravnborg
     [not found] ` <606da8a9-a402-5d2e-1f22-d287982f6abc@tronnes.org>
2018-09-11 11:40   ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910012341.GA22786@dragon \
    --to=shawnguo@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=noralf@tronnes.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).