From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/10] udmabuf: use pgoff_t for pagecount Date: Tue, 11 Sep 2018 09:38:44 +0200 Message-ID: <20180911073844.GH19774@phenom.ffwll.local> References: <20180911065921.23818-1-kraxel@redhat.com> <20180911065921.23818-4-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180911065921.23818-4-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, open list , "moderated list:DMA BUFFER SHARING FRAMEWORK" , laurent.pinchart@ideasonboard.com, "open list:DMA BUFFER SHARING FRAMEWORK" List-Id: dri-devel@lists.freedesktop.org On Tue, Sep 11, 2018 at 08:59:14AM +0200, Gerd Hoffmann wrote: > Reported-by: Laurent Pinchart > Signed-off-by: Gerd Hoffmann TIL pgoff_t stands for page cache offset. I think we're pretty bad at using that within i915 :-) On the entire series Acked-by: Daniel Vetter I did try to review in depth, but my brain is offline and coffee not working :-) Hence just an ack. -Daniel > --- > drivers/dma-buf/udmabuf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index 19bd918209..ec22f203b5 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -13,7 +13,7 @@ > #include > > struct udmabuf { > - u32 pagecount; > + pgoff_t pagecount; > struct page **pages; > }; > > -- > 2.9.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch