From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m Date: Tue, 11 Sep 2018 22:17:02 +0200 Message-ID: <20180911201702.GN19774@phenom.ffwll.local> References: <20180911113325.11024-1-maxime.ripard@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 21CE26E3FD for ; Tue, 11 Sep 2018 20:17:07 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id d8-v6so5895edv.0 for ; Tue, 11 Sep 2018 13:17:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180911113325.11024-1-maxime.ripard@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard Cc: Jernej Skrabec , Arnd Bergmann , Naresh Kamboju , dri-devel@lists.freedesktop.org, Jon Hunter , Chen-Yu Tsai List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBTZXAgMTEsIDIwMTggYXQgMDE6MzM6MjVQTSArMDIwMCwgTWF4aW1lIFJpcGFyZCB3 cm90ZToKPiBIYXZpbmcgRFJNX1NVTjRJIGJ1aWx0LWluIGJ1dCBEUk1fU1VOOElfTUlYRVIgYXMg YSBsb2FkYWJsZSBtb2R1bGUgcmVzdWx0cyBpbgo+IGEgbGluayBlcnJvciwgYXMgd2UgdHJ5IHRv IGFjY2VzcyBhIHN5bWJvbCBmcm9tIHRoZSBzdW44aV90Y29uX3RvcC5rbyBtb2R1bGU6Cj4gCj4g RVJST1I6ICJzdW44aV90Y29uX3RvcF9kZV9jb25maWciIFtkcml2ZXJzL2dwdS9kcm0vc3VuNGkv c3VuNGktdGNvbi5rb10gdW5kZWZpbmVkIQo+IEVSUk9SOiAic3VuOGlfdGNvbl90b3Bfc2V0X2hk bWlfc3JjIiBbZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpLXRjb24ua29dIHVuZGVmaW5lZCEK PiBFUlJPUjogInN1bjhpX3Rjb25fdG9wX29mX3RhYmxlIiBbZHJpdmVycy9ncHUvZHJtL3N1bjRp L3N1bjRpLXRjb24ua29dIHVuZGVmaW5lZCEKPiAKPiBUaGlzIHNvbHZlcyB0aGUgcHJvYmxlbSBi eSBhZGRpbmcgYSBzaWxlbnQgc3ltYm9sIGZvciB0aGUgdGNvbl90b3AgbW9kdWxlLAo+IGJ1aWxk aW5nIGl0IGFzIGEgc2VwYXJhdGUgbW9kdWxlIGluIGV4YWN0bHkgdGhlIGNhc2VzIHRoYXQgd2Ug bmVlZCBpdCwKPiBidXQgaW4gYSB3YXkgdGhhdCBpdCBpcyByZWFjaGFibGUgYnkgdGhlIG90aGVy IG1vZHVsZXMuCj4gCj4gRml4ZXM6IGNmNzdkNzliNGUyOSAoImRybS9zdW40aTogdGNvbjogQWRk IGFub3RoZXIgd2F5IGZvciBtYXRjaGluZyBtaXhlcnMgd2l0aCB0Y29uIikKPiBGaXhlczogMDMw NTE4OWFmYjMyICgiZHJtL3N1bjRpOiB0Y29uOiBBZGQgc3VwcG9ydCBmb3IgUjQwIFRDT04iKQo+ IFRlc3RlZC1ieTogSm9uIEh1bnRlciA8am9uYXRoYW5oQG52aWRpYS5jb20+Cj4gU2lnbmVkLW9m Zi1ieTogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBib290bGluLmNvbT4KClJldmlld2Vk LWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKQnV0IEkgY2FuJ3Qg aGVscCBteXNlbGYgYW5kIGRyb3AgdGhlIHVzdWFsIHF1ZXN0aW9ucyB3aGVuIEkgc2VlIGEgc21h bGwKc29jIGRyaXZlciB3aXRoIG1vcmUgS2NvbmZpZ3MgdGhhbiBhbnl0aGluZyBlbHNlIC4uLiBp cyBhbGwgdGhpcyBwYWluCndvcnRoIGl0PyBJIGtub3cgdGhhdCBtYXliZSB0aGUgZGVza3RvcCBh cHByb2FjaCBvZiBzdHVmZmluZyBoYWxmIGEKbWlsbGlvbiBsaW5lcyBvZiBkcml2ZXIgY29kZSBp bnRvIG9uZSAua28gbWlnaHQgYmUgYSBiaXQgdG9vIG11Y2ggZm9yCnNvY3MsIGJ1dCB0aGlzIHNl ZW1zIG92ZXJraWxsLgoKSSdtIGFsc28gcHJldHR5IHN1cmUgaXQncyBub3QganVzdGlmaWVkIGJ5 IGFueSByZWFsIGRhdGEsIGNvbXBhcmVkIHRvCm92ZXJhbGwgY29kZSBzaXplIG9mIGEgZHJtIHN0 YWNrLCB0aGF0IHNob3dzIGl0J3MgYSBzdWJzdGFudGlhbCBlbm91Z2gKc2F2aW5nIHRoYXQgaXQn cyB3b3J0aCBpdC4KCkltbywgaWYgeW91IHJlYWxseSBjYXJlIGFib3V0IGJ1aWxkaW5nIGEgbWlu aW1hbCBkcml2ZXIsIHN0dWZmIGV2ZXJ5dGhpbmcKaW50byBvbmUgLmtvIGFuZCB0aGVuIExUTyBv dXQgdGhlIHVuZWVkZWQgYml0cy4gV2UndmUgZG9uZSB0aGVzZQpleHBlcmltZW50cyBmb3IgaTkx NSwgdGhhdCBfYWN0dWFsbHlfIHNhdmVzIGEgdG9uIG9mIGJpbmFyeSBzaXplLCB3aXRoCmZhaXJs eSBtaW5pbWFsIGNvZGUgYW5kIG1haW50ZW5hbmNlIGltcGFjdC4gU3RpbGwsIHdlIGRlY2lkZWQg dGhlIHBheW9mZgppcyBzaW1wbHkgdG9vIHNtYWxsIHRvIGJvdGhlciBtYWtpbmcgaXQgYSBwcm9k dWN0aW9uIHRoaW5nLgoKQ2hlZXJzLCBEYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9z dW40aS9zdW40aV90Y29uLmMgfCAxNCArKysrKysrKysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg MTEgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL3N1bjRpL3N1bjRpX3Rjb24uYyBiL2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40 aV90Y29uLmMKPiBpbmRleCA0ODM0YzkwYjQ5MTIuLmM3OGNkMzVhMTI5NCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfdGNvbi5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3N1bjRpL3N1bjRpX3Rjb24uYwo+IEBAIC05NzQsNyArOTc0LDggQEAgc3RhdGljIGJvb2wg c3VuNGlfdGNvbl9jb25uZWN0ZWRfdG9fdGNvbl90b3Aoc3RydWN0IGRldmljZV9ub2RlICpub2Rl KQo+ICAKPiAgCXJlbW90ZSA9IG9mX2dyYXBoX2dldF9yZW1vdGVfbm9kZShub2RlLCAwLCAtMSk7 Cj4gIAlpZiAocmVtb3RlKSB7Cj4gLQkJcmV0ID0gISFvZl9tYXRjaF9ub2RlKHN1bjhpX3Rjb25f dG9wX29mX3RhYmxlLCByZW1vdGUpOwo+ICsJCXJldCA9ICEhKElTX0VOQUJMRUQoQ09ORklHX0RS TV9TVU44SV9UQ09OX1RPUCkgJiYKPiArCQkJIG9mX21hdGNoX25vZGUoc3VuOGlfdGNvbl90b3Bf b2ZfdGFibGUsIHJlbW90ZSkpOwo+ICAJCW9mX25vZGVfcHV0KHJlbW90ZSk7Cj4gIAl9Cj4gIAo+ IEBAIC0xNDAyLDEzICsxNDAzLDIwIEBAIHN0YXRpYyBpbnQgc3VuOGlfcjQwX3Rjb25fdHZfc2V0 X211eChzdHJ1Y3Qgc3VuNGlfdGNvbiAqdGNvbiwKPiAgCWlmICghcGRldikKPiAgCQlyZXR1cm4g LUVJTlZBTDsKPiAgCj4gLQlpZiAoZW5jb2Rlci0+ZW5jb2Rlcl90eXBlID09IERSTV9NT0RFX0VO Q09ERVJfVE1EUykgewo+ICsJaWYgKElTX0VOQUJMRUQoQ09ORklHX0RSTV9TVU44SV9UQ09OX1RP UCkgJiYKPiArCSAgICBlbmNvZGVyLT5lbmNvZGVyX3R5cGUgPT0gRFJNX01PREVfRU5DT0RFUl9U TURTKSB7Cj4gIAkJcmV0ID0gc3VuOGlfdGNvbl90b3Bfc2V0X2hkbWlfc3JjKCZwZGV2LT5kZXYs IGlkKTsKPiAgCQlpZiAocmV0KQo+ICAJCQlyZXR1cm4gcmV0Owo+ICAJfQo+ICAKPiAtCXJldHVy biBzdW44aV90Y29uX3RvcF9kZV9jb25maWcoJnBkZXYtPmRldiwgdGNvbi0+aWQsIGlkKTsKPiAr CWlmIChJU19FTkFCTEVEKENPTkZJR19EUk1fU1VOOElfVENPTl9UT1ApKSB7Cj4gKwkJcmV0ID0g c3VuOGlfdGNvbl90b3BfZGVfY29uZmlnKCZwZGV2LT5kZXYsIHRjb24tPmlkLCBpZCk7Cj4gKwkJ aWYgKHJldCkKPiArCQkJcmV0dXJuIHJldDsKPiArCX0KPiArCj4gKwlyZXR1cm4gMDsKPiAgfQo+ ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBzdW40aV90Y29uX3F1aXJrcyBzdW40aV9hMTBfcXVp cmtzID0gewo+IC0tIAo+IDIuMTcuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5l ZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=