From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m Date: Wed, 12 Sep 2018 16:02:03 +0200 Message-ID: <20180912140203.vfhztb2bit7ueobc@flea> References: <20180911113325.11024-1-maxime.ripard@bootlin.com> <20180911201702.GN19774@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0472068794==" Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id BC5636E55C for ; Wed, 12 Sep 2018 14:02:14 +0000 (UTC) In-Reply-To: <20180911201702.GN19774@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Jernej Skrabec , Arnd Bergmann , Naresh Kamboju , dri-devel@lists.freedesktop.org, Jon Hunter , Chen-Yu Tsai List-Id: dri-devel@lists.freedesktop.org --===============0472068794== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2lhyn6fn2ph54jti" Content-Disposition: inline --2lhyn6fn2ph54jti Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 11, 2018 at 10:17:02PM +0200, Daniel Vetter wrote: > On Tue, Sep 11, 2018 at 01:33:25PM +0200, Maxime Ripard wrote: > > Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module resu= lts in > > a link error, as we try to access a symbol from the sun8i_tcon_top.ko m= odule: > >=20 > > ERROR: "sun8i_tcon_top_de_config" [drivers/gpu/drm/sun4i/sun4i-tcon.ko]= undefined! > > ERROR: "sun8i_tcon_top_set_hdmi_src" [drivers/gpu/drm/sun4i/sun4i-tcon.= ko] undefined! > > ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun4i-tcon.ko] = undefined! > >=20 > > This solves the problem by adding a silent symbol for the tcon_top modu= le, > > building it as a separate module in exactly the cases that we need it, > > but in a way that it is reachable by the other modules. > >=20 > > Fixes: cf77d79b4e29 ("drm/sun4i: tcon: Add another way for matching mix= ers with tcon") > > Fixes: 0305189afb32 ("drm/sun4i: tcon: Add support for R40 TCON") > > Tested-by: Jon Hunter > > Signed-off-by: Maxime Ripard >=20 > Reviewed-by: Daniel Vetter It's pushed, thanks! Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --2lhyn6fn2ph54jti Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAluZHFoACgkQ0rTAlCFN r3SMww//XEX6S5RxUZO8sIbtxXX6lCw1YEraym+hgxlG+FWs6xwtpQWWsgjIhGYd j32tuyF5uGRJKQFZXAnBesIuGLSAkCFudRUZL9NuZ5EOwRu5U7uj4TgrNY2LnqOB xirGvm0rk12DRSlY1U4Y6NqBiNjf6oaQq0VcWna56+gPbS1TKYHKcN+o7FYoyjGp yb6YnkB7VL1BlpIlDCoN4Y59oxHNmBt9PCgJjmv/PlsRyZXe0jxZ/iLoLQldRu29 5mb7BAeXFPAzIecn0xaerr/l3HKL/NV2uB0ZwN0Daj4hjd50DDkYJgEroNZ6Hr4B +N4x+HfWyTmY8r3Z3i7jsSVY279jdyFsqmT2xkdCHoCSHXxevzOddgvmlWpuH19N HOZoXwdnyYmh5BMlFGPIGD5GyFdG8uWKZMA3YmJp+NP4BbSbZGpaB1pLqG334e90 2QMNPztXvzfldQP97buRQ0vOgEdLxOlsGb8xTqpgc3X3k3DxKSkatPZkBu1381jM FhB1b8hzZXXVA5hX38N3i1SFaeTuBfDArcmThTrhiKgh+Dp8Wh5wQW0nHskDxIWk AsvLv3EiyUYMUMsrYkHLDCbsOaiHaYVi2nBKoeR7xeTaC+40pPElHzkeIyrrkFiv wYU5ouu7Pve8fNTVYTr0bx62Fn1MpRr/v6RWtKp5uvkvblqYWb8= =yvxb -----END PGP SIGNATURE----- --2lhyn6fn2ph54jti-- --===============0472068794== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0472068794==--