From: Eric Engestrom <eric.engestrom@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/2] intel: hide library symbols by default
Date: Thu, 13 Sep 2018 09:03:28 +0100 [thread overview]
Message-ID: <20180913080328.nrccvbk7glni6n57@intel.com> (raw)
In-Reply-To: <20180912210536.29679-1-lucas.demarchi@intel.com>
On Wednesday, 2018-09-12 14:05:34 -0700, Lucas De Marchi wrote:
> Rely on -fvisibility=hidden to hide the symbols. This only applies to
> drm_intel.so sice there's no point in extending this if it receives a
> nack for some reason. For the same reason, only done on meson as well.
>
> drm_private can also be removed from other symbols. If this passes a
> smoke test I'll add a patch on v2 doing so.
Series is
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
but yeah, without that 3rd patch to remove drm_private it isn't all that
useful :P
Do you plan on converting the rest of libdrm if/when this gets accepted?
It looks like you already got all the scripts ready to go ;)
>
> From git log archeology and mention in another thread we used to pass
> -fvisibility=hidden, but reverted to the contrary due to bug in obscure
> toolchain some years ago (see 0f8da82500ec542e269092c0718479e25eaff5f6).
> I think it's time to revisit that decision: we have plenty of other
> projects doing that nowadays without problem.
>
> Lucas De Marchi (2):
> intel: annotate public functions
> meson: intel: make symbols hidden by default
>
> intel/intel_bufmgr.c | 64 +++++++++++++++++-----------------
> intel/intel_bufmgr_fake.c | 10 +++---
> intel/intel_bufmgr_gem.c | 73 +++++++++++++++++++--------------------
> intel/intel_decode.c | 14 ++++----
> intel/meson.build | 4 ++-
> libdrm_macros.h | 2 ++
> 6 files changed, 85 insertions(+), 82 deletions(-)
>
> --
> 2.17.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-13 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 21:05 [PATCH 0/2] intel: hide library symbols by default Lucas De Marchi
2018-09-12 21:05 ` [PATCH 1/2] intel: annotate public functions Lucas De Marchi
2018-09-12 21:05 ` [PATCH 2/2] meson: intel: make symbols hidden by default Lucas De Marchi
2018-09-13 8:03 ` Eric Engestrom [this message]
[not found] ` <74b366cf-7bf9-f8ba-7724-e04c8deaba70@intel.com>
2018-09-13 20:11 ` [PATCH 0/2] intel: hide library symbols " Eric Engestrom
2018-09-13 20:13 ` Eric Engestrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913080328.nrccvbk7glni6n57@intel.com \
--to=eric.engestrom@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox