From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH libdrm] intel: annotate the intel genx helpers as private Date: Thu, 13 Sep 2018 09:45:47 +0100 Message-ID: <20180913084547.ci45onyxfx64a2bi@intel.com> References: <20180912104403.o3gerb7w2de7ae7v@intel.com> <20180912155054.17334-1-rodrigo.vivi@intel.com> <20180912160322.GA17715@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC8BD6E624 for ; Thu, 13 Sep 2018 08:45:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chih-Wei Huang Cc: Emil Velikov , Lucas De Marchi , ML dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVGh1cnNkYXksIDIwMTgtMDktMTMgMTU6MTk6MDAgKzA4MDAsIENoaWgtV2VpIEh1YW5nIHdy b3RlOgo+IE5vdGUgdGhpcyBwYXRjaCBicmVha3MgZHJtX2dyYWxsb2M6Cj4gCj4gRkFJTEVEOiBv dXQvdGFyZ2V0L3Byb2R1Y3QveDg2XzY0L29ial94ODYvU0hBUkVEX0xJQlJBUklFUy9saWJncmFs bG9jX2RybV9pbnRlcm1lZGlhdGVzL0xJTktFRC9saWJncmFsbG9jX2RybS5zbwo+IC9iaW4vYmFz aCAtYyAicHJlYnVpbHRzL2NsYW5nL2hvc3QvbGludXgteDg2L2NsYW5nLTQwNTM1ODYvYmluL2Ns YW5nKysKPiAtbm9zdGRsaWIgLVdsLC1zb25hbWUsbGliZ3JhbGxvY19kcm0uc28gLVdsLC0tZ2Mt c2VjdGlvbnMgLXNoYXJlZAo+IG91dC90YXJnZXQvcHJvZHVjdC94ODZfNjQvb2JqX3g4Ni9saWIv Y3J0YmVnaW5fc28ubwo+IG91dC90YXJnZXQvcHJvZHVjdC94ODZfNjQvb2JqX3g4Ni9TSEFSRURf TElCUkFSSUVTL2xpYmdyYWxsb2NfZHJtX2ludGVybWVkaWF0ZXMvZ3JhbGxvY19kcm0ubwo+IG91 dC90YXJnZXQvcHJvZHVjdC94ODZfNjQvb2JqX3g4Ni9TSEFSRURfTElCUkFSSUVTL2xpYmdyYWxs b2NfZHJtX2ludGVybWVkaWF0ZXMvZ3JhbGxvY19kcm1fa21zLm8KPiBvdXQvdGFyZ2V0L3Byb2R1 Y3QveDg2XzY0L29ial94ODYvU0hBUkVEX0xJQlJBUklFUy9saWJncmFsbG9jX2RybV9pbnRlcm1l ZGlhdGVzL2dyYWxsb2NfZHJtX2ludGVsLm8KPiBvdXQvdGFyZ2V0L3Byb2R1Y3QveDg2XzY0L29i al94ODYvU0hBUkVEX0xJQlJBUklFUy9saWJncmFsbG9jX2RybV9pbnRlcm1lZGlhdGVzL2dyYWxs b2NfZHJtX3JhZGVvbi5vCj4gb3V0L3RhcmdldC9wcm9kdWN0L3g4Nl82NC9vYmpfeDg2L1NIQVJF RF9MSUJSQVJJRVMvbGliZ3JhbGxvY19kcm1faW50ZXJtZWRpYXRlcy9ncmFsbG9jX2RybV9ub3V2 ZWF1Lm8KPiBvdXQvdGFyZ2V0L3Byb2R1Y3QveDg2XzY0L29ial94ODYvU0hBUkVEX0xJQlJBUklF Uy9saWJncmFsbG9jX2RybV9pbnRlcm1lZGlhdGVzL2dyYWxsb2NfZHJtX3BpcGUubwo+IC1XbCwt LXdob2xlLWFyY2hpdmUgIC1XbCwtLW5vLXdob2xlLWFyY2hpdmUKPiBvdXQvdGFyZ2V0L3Byb2R1 Y3QveDg2XzY0L29ial94ODYvU1RBVElDX0xJQlJBUklFUy9saWJjb21waWxlcl9ydC1leHRyYXNf aW50ZXJtZWRpYXRlcy9saWJjb21waWxlcl9ydC1leHRyYXMuYQo+ICAgb3V0L3RhcmdldC9wcm9k dWN0L3g4Nl82NC9vYmpfeDg2L1NUQVRJQ19MSUJSQVJJRVMvbGliYXRvbWljX2ludGVybWVkaWF0 ZXMvbGliYXRvbWljLmEKPiBvdXQvdGFyZ2V0L3Byb2R1Y3QveDg2XzY0L29ial94ODYvU1RBVElD X0xJQlJBUklFUy9saWJnY2NfaW50ZXJtZWRpYXRlcy9saWJnY2MuYQo+IC1XbCwteixub2V4ZWNz dGFjayAtV2wsLXoscmVscm8gLVdsLC16LG5vdyAtV2wsLS1idWlsZC1pZD1tZDUKPiAtV2wsLS13 YXJuLXNoYXJlZC10ZXh0cmVsIC1XbCwtLWZhdGFsLXdhcm5pbmdzIC1XbCwtLWdjLXNlY3Rpb25z Cj4gLVdsLC0taGFzaC1zdHlsZT1nbnUgLVdsLC0tbm8tdW5kZWZpbmVkLXZlcnNpb24gLW0zMiAg LXRhcmdldAo+IGk2ODYtbGludXgtYW5kcm9pZAo+IC1CcHJlYnVpbHRzL2djYy9saW51eC14ODYv eDg2L3g4Nl82NC1saW51eC1hbmRyb2lkLTQuOS94ODZfNjQtbGludXgtYW5kcm9pZC9iaW4KPiAt V2wsLS1uby11bmRlZmluZWQgb3V0L3RhcmdldC9wcm9kdWN0L3g4Nl82NC9vYmpfeDg2L2xpYi9s aWJkcm0uc28KPiBvdXQvdGFyZ2V0L3Byb2R1Y3QveDg2XzY0L29ial94ODYvbGliL2xpYmxvZy5z bwo+IG91dC90YXJnZXQvcHJvZHVjdC94ODZfNjQvb2JqX3g4Ni9saWIvbGliY3V0aWxzLnNvCj4g b3V0L3RhcmdldC9wcm9kdWN0L3g4Nl82NC9vYmpfeDg2L2xpYi9saWJoYXJkd2FyZV9sZWdhY3ku c28KPiBvdXQvdGFyZ2V0L3Byb2R1Y3QveDg2XzY0L29ial94ODYvbGliL2xpYmRybV9pbnRlbC5z bwo+IG91dC90YXJnZXQvcHJvZHVjdC94ODZfNjQvb2JqX3g4Ni9saWIvbGliZHJtX3JhZGVvbi5z bwo+IG91dC90YXJnZXQvcHJvZHVjdC94ODZfNjQvb2JqX3g4Ni9saWIvbGliZHJtX25vdXZlYXUu c28KPiBvdXQvdGFyZ2V0L3Byb2R1Y3QveDg2XzY0L29ial94ODYvbGliL2xpYmMrKy5zbwo+IG91 dC90YXJnZXQvcHJvZHVjdC94ODZfNjQvb2JqX3g4Ni9saWIvbGliYy5zbwo+IG91dC90YXJnZXQv cHJvZHVjdC94ODZfNjQvb2JqX3g4Ni9saWIvbGlibS5zbwo+IG91dC90YXJnZXQvcHJvZHVjdC94 ODZfNjQvb2JqX3g4Ni9saWIvbGliZGwuc28gLW8KPiBvdXQvdGFyZ2V0L3Byb2R1Y3QveDg2XzY0 L29ial94ODYvU0hBUkVEX0xJQlJBUklFUy9saWJncmFsbG9jX2RybV9pbnRlcm1lZGlhdGVzL0xJ TktFRC9saWJncmFsbG9jX2RybS5zbwo+IG91dC90YXJnZXQvcHJvZHVjdC94ODZfNjQvb2JqX3g4 Ni9saWIvY3J0ZW5kX3NvLm8iCj4gZXh0ZXJuYWwvZHJtX2dyYWxsb2MvZ3JhbGxvY19kcm1faW50 ZWwuYzo2MzE6IGVycm9yOiB1bmRlZmluZWQKPiByZWZlcmVuY2UgdG8gJ2ludGVsX2lzX2dlbngn Cj4gZXh0ZXJuYWwvZHJtX2dyYWxsb2MvZ3JhbGxvY19kcm1faW50ZWwuYzo2MzA6IGVycm9yOiB1 bmRlZmluZWQKPiByZWZlcmVuY2UgdG8gJ2ludGVsX2dldF9nZW54Jwo+IGNsYW5nLnJlYWw6IGVy cm9yOiBsaW5rZXIgY29tbWFuZCBmYWlsZWQgd2l0aCBleGl0IGNvZGUgMSAodXNlIC12IHRvCj4g c2VlIGludm9jYXRpb24pCj4gCj4gCj4gVGhhdCdzIGJlY2F1c2UgZHJtX2dyYWxsb2MgdXNlIHRo ZSBJU19HRU45IG1hY3JvCj4gKGFuZCBvdGhlciBJU19HRU57bn0gbWFjcm9zKSBkaXJlY3RseS4K ClllYWgsIEkgdGhvdWdodCBzb21lIG90aGVyIHN0dWZmIHVzZWQgdGhlIElTX0dFTiogbWFjcm9z IMKvXF8o44OEKV8vwq8KCkkgYXNzdW1lIG15IG90aGVyIHBhdGNoICgiaW50ZWw6IHVzZSBkcm0g bmFtZXNwYWNlIGZvciBleHBvcnRlZCBmdW5jdGlvbnMiLApodHRwczovL3BhdGNod29yay5rZXJu ZWwub3JnL3BhdGNoLzEwNTkwNjUzLykgd29ya3MgZmluZSB3aXRoIGRybV9ncmFsbG9jPwoKPiAK PiBTaW5jZSBJU19HRU57bn0gYXJlIHB1YmxpYyBBUElzLCBJIGRvbid0IHNlZQo+IHRoZSByYXRp b25hbGUgb2YgdGhpcyBjaGFuZ2UuCj4gVW5sZXNzIHlvdSBhcmUgZ29pbmcgdG8gcHJpdmF0aXpl IGFsbCBJU19HRU57bn0gbWFjcm9zLgo+IChhcmUgeW91PykKPiAKPiAKPiAyMDE4LTA5LTEzIDA6 MDMgR01UKzA4OjAwIFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT46Cj4gPiBP biBXZWQsIFNlcCAxMiwgMjAxOCBhdCAwODo1MDo1NEFNIC0wNzAwLCBSb2RyaWdvIFZpdmkgd3Jv dGU6Cj4gPj4gRnJvbTogRW1pbCBWZWxpa292IDxlbWlsLnZlbGlrb3ZAY29sbGFib3JhLmNvbT4K PiA+Pgo+ID4+IFRoZXkncmUgdXNlZCBpbnRlcm5hbGx5IGFuZCBuZXZlciBtZWFudCB0byBiZSBw YXJ0IG9mIHRoZSBBUEkuCj4gPj4gQWRkIHRoZSBkcm1fcHJpdmF0ZSBub3RhdGlvbiwgd2hpY2gg c2hvdWxkIHJlc29sdmUgdGhhdC4KPiA+Pgo+ID4+IHYyOiAoUm9kcmlnbykgQWRkIG1pc3Npbmcg aW5jbHVkZS4KPiA+PiB2MzogKFJvZHJpZ28pIEtlZXAgaW5jbHVkZXMgZ3JvdXBlZCBwZXIgRXJp YyBzdWdnZXN0aW9uLgo+ID4+Cj4gPj4gQ2M6IEVyaWMgRW5nZXN0cm9tIDxlcmljLmVuZ2VzdHJv bUBpbnRlbC5jb20+Cj4gPj4gQ2M6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50 ZWwuY29tPgo+ID4+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4K PiA+PiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4+IEZpeGVz OiA0ZTgxZDRmOWM5YiAoImludGVsOiBhZGQgZ2VuZXJpYyBmdW5jdGlvbnMgdG8gY2hlY2sgUENJ IElEIikKPiA+PiBTaWduZWQtb2ZmLWJ5OiBFbWlsIFZlbGlrb3YgPGVtaWwudmVsaWtvdkBjb2xs YWJvcmEuY29tPgo+ID4+IEFja2VkLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hp QGludGVsLmNvbT4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2 aUBpbnRlbC5jb20+Cj4gPj4gUmV2aWV3ZWQtYnk6IEVyaWMgRW5nZXN0cm9tIDxlcmljLmVuZ2Vz dHJvbUBpbnRlbC5jb20+Cj4gPgo+ID4gQW5kIHB1c2hlZC4uLgo+ID4gdGhhbmtzIGZvciBwYXRj aCwgYWNrIGFuZCByZXZpZXcgOykKPiA+Cj4gPj4gLS0tCj4gPj4gIGludGVsL2ludGVsX2NoaXBz ZXQuYyB8IDQgKystLQo+ID4+ICBpbnRlbC9pbnRlbF9jaGlwc2V0LmggfCA1ICsrKy0tCj4gPj4g IDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4+Cj4g Pj4gZGlmZiAtLWdpdCBhL2ludGVsL2ludGVsX2NoaXBzZXQuYyBiL2ludGVsL2ludGVsX2NoaXBz ZXQuYwo+ID4+IGluZGV4IGQ1YzMzY2M1Li41YWE0YTJmMiAxMDA2NDQKPiA+PiAtLS0gYS9pbnRl bC9pbnRlbF9jaGlwc2V0LmMKPiA+PiArKysgYi9pbnRlbC9pbnRlbF9jaGlwc2V0LmMKPiA+PiBA QCAtNDQsNyArNDQsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHBjaV9kZXZpY2Ugewo+ID4+ICAg ICAgIElOVEVMX1NLTF9JRFMoOSksCj4gPj4gIH07Cj4gPj4KPiA+PiAtYm9vbCBpbnRlbF9pc19n ZW54KHVuc2lnbmVkIGludCBkZXZpZCwgaW50IGdlbikKPiA+PiArZHJtX3ByaXZhdGUgYm9vbCBp bnRlbF9pc19nZW54KHVuc2lnbmVkIGludCBkZXZpZCwgaW50IGdlbikKPiA+PiAgewo+ID4+ICAg ICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2aWNlICpwLAo+ID4+ICAgICAgICAgICAgICAgICAqcGVu ZCA9IHBjaWlkcyArIHNpemVvZihwY2lpZHMpIC8gc2l6ZW9mKHBjaWlkc1swXSk7Cj4gPj4gQEAg LTY2LDcgKzY2LDcgQEAgYm9vbCBpbnRlbF9pc19nZW54KHVuc2lnbmVkIGludCBkZXZpZCwgaW50 IGdlbikKPiA+PiAgICAgICByZXR1cm4gZmFsc2U7Cj4gPj4gIH0KPiA+Pgo+ID4+IC1ib29sIGlu dGVsX2dldF9nZW54KHVuc2lnbmVkIGludCBkZXZpZCwgaW50ICpnZW4pCj4gPj4gK2RybV9wcml2 YXRlIGJvb2wgaW50ZWxfZ2V0X2dlbngodW5zaWduZWQgaW50IGRldmlkLCBpbnQgKmdlbikKPiA+ PiAgewo+ID4+ICAgICAgIGNvbnN0IHN0cnVjdCBwY2lfZGV2aWNlICpwLAo+ID4+ICAgICAgICAg ICAgICAgICAqcGVuZCA9IHBjaWlkcyArIHNpemVvZihwY2lpZHMpIC8gc2l6ZW9mKHBjaWlkc1sw XSk7Cj4gPj4gZGlmZiAtLWdpdCBhL2ludGVsL2ludGVsX2NoaXBzZXQuaCBiL2ludGVsL2ludGVs X2NoaXBzZXQuaAo+ID4+IGluZGV4IDliMWU2NGYxLi41ZGIyMDdjYyAxMDA2NDQKPiA+PiAtLS0g YS9pbnRlbC9pbnRlbF9jaGlwc2V0LmgKPiA+PiArKysgYi9pbnRlbC9pbnRlbF9jaGlwc2V0LmgK PiA+PiBAQCAtMzI5LDkgKzMyOSwxMCBAQAo+ID4+Cj4gPj4gIC8qIE5ldyBwbGF0Zm9ybXMgdXNl IGtlcm5lbCBwY2kgaWRzICovCj4gPj4gICNpbmNsdWRlIDxzdGRib29sLmg+Cj4gPj4gKyNpbmNs dWRlIDxsaWJkcm1fbWFjcm9zLmg+Cj4gPj4KPiA+PiAtYm9vbCBpbnRlbF9pc19nZW54KHVuc2ln bmVkIGludCBkZXZpZCwgaW50IGdlbik7Cj4gPj4gLWJvb2wgaW50ZWxfZ2V0X2dlbngodW5zaWdu ZWQgaW50IGRldmlkLCBpbnQgKmdlbik7Cj4gPj4gK2RybV9wcml2YXRlIGJvb2wgaW50ZWxfaXNf Z2VueCh1bnNpZ25lZCBpbnQgZGV2aWQsIGludCBnZW4pOwo+ID4+ICtkcm1fcHJpdmF0ZSBib29s IGludGVsX2dldF9nZW54KHVuc2lnbmVkIGludCBkZXZpZCwgaW50ICpnZW4pOwo+ID4+Cj4gPj4g ICNkZWZpbmUgSVNfR0VOOShkZXZpZCkgaW50ZWxfaXNfZ2VueChkZXZpZCwgOSkKPiA+PiAgI2Rl ZmluZSBJU19HRU4xMChkZXZpZCkgaW50ZWxfaXNfZ2VueChkZXZpZCwgMTApCj4gPj4gLS0KPiAK PiAKPiAtLSAKPiBDaGloLVdlaQo+IEFuZHJvaWQteDg2IHByb2plY3QKPiBodHRwOi8vd3d3LmFu ZHJvaWQteDg2Lm9yZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK