From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH -fixes 5/5] drm/vmwgfx: Fix a buffer object eviction regression Date: Thu, 13 Sep 2018 10:38:46 -0700 Message-ID: <20180913173846.GD11574@bombadil.infradead.org> References: <20180913115837.7746-1-thellstrom@vmware.com> <20180913115837.7746-5-thellstrom@vmware.com> <20180913141048.GA22737@bombadil.infradead.org> <7eb47317-b385-d9c5-4d50-910219f8dbdf@vmware.com> <20180913152811.GA11574@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3ACE788C11 for ; Thu, 13 Sep 2018 17:38:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Hellstrom Cc: pv-drivers@vmware.com, linux-graphics-maintainer@vmware.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBTZXAgMTMsIDIwMTggYXQgMDY6NTI6NDNQTSArMDIwMCwgVGhvbWFzIEhlbGxzdHJv bSB3cm90ZToKPiBPbiAwOS8xMy8yMDE4IDA1OjI4IFBNLCBNYXR0aGV3IFdpbGNveCB3cm90ZToK PiA+IE9uIFRodSwgU2VwIDEzLCAyMDE4IGF0IDA0OjU2OjUzUE0gKzAyMDAsIFRob21hcyBIZWxs c3Ryb20gd3JvdGU6Cj4gPiA+IE9uIDA5LzEzLzIwMTggMDQ6MTAgUE0sIE1hdHRoZXcgV2lsY294 IHdyb3RlOgo+ID4gPiA+IEkgdGhpbmsgdGhpcyBjb3VsZCBiZSBiZXR0ZXIgdGhvdWdoIC4uLiBp ZiBpZGFfYWxsb2MoKSBldmVyIHN0YXJ0cwo+ID4gPiA+IHJldHVybmluZyBhIGRpZmZlcmVudCBl cnJubyBpbiB0aGUgZnV0dXJlLCB5b3UnbGwgaGl0IHRoZSBzYW1lIHByb2JsZW0sCj4gPiA+ID4g cmlnaHQ/ICBTbyBob3cgYWJvdXQgdGhpcyAuLi4KPiA+ID4gPiAKPiA+ID4gPiAgICAJaWQgPSBp ZGFfYWxsb2NfbWF4KCZnbWFuLT5nbXJfaWRhLCBnbWFuLT5tYXhfZ21yX2lkcyAtIDEsIEdGUF9L RVJORUwpOwo+ID4gPiA+ICsJaWYgKGlkID09IC1FTk9NRU0pCj4gPiA+ID4gKwkJcmV0dXJuIC1F Tk9NRU07Cj4gPiA+ID4gKwlpZiAoaWQgPCAwKQo+ID4gPiA+ICsJCXJldHVybiAwOwo+ID4gPiA+ ICAgIAlzcGluX2xvY2soJmdtYW4tPmxvY2spOwo+ID4gPiA+IAo+ID4gPiA+IEJ1dCBJIHdvbmRl ciAuLi4gd2h5IGlzIC1FTk9NRU0gc2VlbiBhcyBhIGZhdGFsIGVycm9yPyAgSWYgeW91IGZyZWUg dXAKPiA+ID4gPiBzb21lIG1lbW9yeSwgeW91J2xsIGZyZWUgdXAgYW4gSUQsIHNvIHRoZSBuZXh0 IHRpbWUgYXJvdW5kIHlvdSBzaG91bGQKPiA+ID4gPiBiZSBhYmxlIHRvIGFsbG9jYXRlIGFuIElE LiAgU28gc2hvdWxkbid0IHRoaXMgZnVuY3Rpb24ganVzdCBoYXZlCj4gPiA+ID4gYmVlbiBkb2lu ZyB0aGlzIGFsbCBhbG9uZz8KPiA+ID4gPiAKPiA+ID4gPiAgICAJaWQgPSBpZGFfYWxsb2NfbWF4 KCZnbWFuLT5nbXJfaWRhLCBnbWFuLT5tYXhfZ21yX2lkcyAtIDEsIEdGUF9LRVJORUwpOwo+ID4g PiA+ICsJaWYgKGlkIDwgMCkKPiA+ID4gPiArCQlyZXR1cm4gMDsKPiA+ID4gPiAKPiA+ID4gTm9u LWZhdGFsIGVycm9ycyBhcmUgZXJyb3JzIHRoYXQgY2FuIGJlIHJlbWVkaWVkIGJ5IEdQVSBidWZm ZXIgZXZpY3Rpb24sIGFuZAo+ID4gPiBidWZmZXIgZXZpY3Rpb24gd2lsbCBmcmVlIHVwIElEQSBz cGFjZSwgc28gYmFzaWNhbGx5IHdlIG5lZWQgdG8gdGFyZ2V0IG9ubHkKPiA+ID4gdGhlIGVycm9y IGNvZGUgdGhhdCBpbmRpY2F0ZXMgd2UndmUgcnVuIG91dCBvZiBJREEgc3BhY2UuCj4gPiBZZXMs IGJ1dCB0aGUgZm9sbG93aW5nIHNpdHVhdGlvbiBjYW4gaGFwcGVuOgo+ID4gCj4gPiAgIC0gQWxs b2NhdGUgMTAyNCBJRHMKPiA+ICAgLSBSdW4gdmVyeSBsb3cgb24gbWVtb3J5Cj4gPiAgIC0gQWxs b2NhdGluZyBJRCAxMDI1IHdpbGwgZmFpbCAodmVyeSB2ZXJ5IHVubGlrZWx5KQo+ID4gICAtIGlk YV9hbGxvY19tYXgoKSByZXR1cm5zIC1FTk9NRU0KPiA+IAo+ID4gSW4gdGhpcyBzaXR1YXRpb24s IHdlIHdhbnQgdHRtX21lbV9ldmljdF9maXJzdCgpIHRvIGJlIGNhbGxlZCB3aGljaCB3aWxsCj4g PiBmcmVlIHVwIG9uZSBvZiB0aGUgMTAyNCBleGlzdGluZyBJRHMgYW5kIHRoZW4gd2UgY2FuIGFs bG9jYXRlIHRoYXQgSUQgZm9yCj4gPiBvdXIgbmV3IG5vZGUuCj4gPiAKPiA+IEknbSBhc3N1bWlu ZyB3ZSdyZSBhbmFseXNpbmcgdGhlIGJlaGF2aW91ciBvZiB0dG1fYm9fbWVtX2ZvcmNlX3NwYWNl KCkKPiA+IGhlcmUuCj4gCj4gV2VsbCwgdGhhdCdzIHRydWUsIGJ1dCB0aGF0IHNpdHVhdGlvbiBk ZXBlbmRzIEkgZ3Vlc3MgdmVyeSBtdWNoIG9uIHRoZSByYWRpeAo+IHRyZWUgaW1wbGVtZW50YXRp b24gb2YgSURBPwoKVGhlIHNwZWNpZmljIG51bWJlciAxMDI0IGRlcGVuZHMgb24gdGhlIGN1cnJl bnQgaW1wbGVtZW50YXRpb24sIGJ1dApnZW5lcmFsbHkgc3BlYWtpbmcgYXQgc29tZSBwb2ludCwg dGhlIElEQSBoYXMgdG8gYWxsb2NhdGUgbWVtb3J5IHRvIHN0b3JlCm9uZSBleHRyYSBJRC4gIEJl Y2F1c2UgdGhlIElEQSBjYW5ub3QgYWxsb2NhdGUgbWVtb3J5IHdoZW4gZnJlZWluZyBhbgpJRCwg dGhlcmUgaXMgbm8gbW9yZSBjb21wYWN0IHJlcHJlc2VudGF0aW9uIG9mIHRoZSBhbGxvY2F0ZWQg SURzIHNtYWxsZXIKdGhhbiBhIGJpdG1hcC4KCj4gQWxzbyBJIHdvdWxkIGV4cGVjdCB0aGUgZXZp Y3Rpb24gcGF0aHMgdG8gdHJ5IHRvCj4gYWxsb2NhdGUgbW9yZSBtZW1vcnkgaGVyZSBhbmQgdGhl cmUsIHNvIHRvIG1lIHRoZSBwcmVmZXJyZWQgb3B0aW9uIHdoZW4KPiAtRU5PTUVNIGhhcHBlbnMs IGlzIHJlYWxseSB0byBiYWNrIG9mZiBhcyBzb29uIGFzIHBvc3NpYmxlIHRvIGF2b2lkCj4gaW50 ZXJmZXJpbmcgd2l0aCBzaHJpbmtlciB3b3JrIGdvaW5nIG9uIGV0Yy4KCkkgd291bGQgYmUgc3Vy cHJpc2VkIGlmIGZyZWVpbmcgcmVzb3VyY2VzIG5lZWRzIG1lbW9yeSB0byBiZSBhbGxvY2F0ZWQu ClRoYXQncyBub3Qgc3VwcG9zZWQgdG8gaGFwcGVuOyB0aGUgZmlsZXN5c3RlbXMgZ28gdG8gZ3Jl YXQgbGVuZ3RocyB0bwpwcmUtYWxsb2NhdGUgZW5vdWdoIG1lbW9yeSB0aGF0IHRoZXkgY2FuIGFs d2F5cyB3cml0ZSBhdCBsZWFzdCBvbmUgZGlydHkKcGFnZSBiYWNrIHRvIHN0b3JhZ2Ugd2l0aG91 dCBhbGxvY2F0aW5nIGFueSBtZW1vcnksIGZvciBleGFtcGxlLiAgTWF5YmUKdGhlIERSTSBzdWJz eXN0ZW0gaXMgZGlmZmVyZW50OyBJJ20gbm90IGFuIGV4cGVydCBpbiB5b3VyIHN1YnN5c3RlbS4K Cj4gPiBNeSBwb2ludCB3YXMgdGhhdCB5b3VyIHNvbHV0aW9uIChkZXRlY3QgdGhlIG9uZSBlcnJv ciB3aGljaCBzaG91bGQgYmUKPiA+IGRlZW1lZCBhcyBub24tZmF0YWwpIHdhcyBub3QgYXMgcm9i dXN0IGFzIGl0cyBpbnZlcnNlIChkZXRlY3QgdGhlIG9uZQo+ID4gZXJyb3Igd2hpY2ggdGhlIHBy ZXZpb3VzIGNvZGUgZGVlbWVkIGFzIGZhdGFsKS4gIEJ1dCBJIG5vdyBiZWxpZXZlIG5vCj4gPiBl cnJvciBmcm9tIHRoZSBJREEgc2hvdWxkIGJlIHNlZW4gYXMgZmF0YWwuCj4gCj4gSWYgeW91IGlu c2lzdCwgSSBjYW4gdGVzdCBvbiAtRU5PTUVNIGluc3RlYWQgb2YgLUVOT1NQQyB0byBtaW1pYyB0 aGUKPiBwcmUtY2hhbmdlIGJlaGF2aW91ci4gV2Ugc2hvdWxkIHJlYWxseSBmb2N1cyBvbiB0aGUg SURBIGFwaSBjaGFuZ2VzIGhlcmUsCj4gYW5kIGRlZmVyIGNoYW5naW5nIC1FTk9NRU0gdG8gbm9u LWZhdGFsIHRvIGEgZm9sbG93LXVwIHBhdGNoIGlmIG5lZWRlZC4KCkknZCBiZSBjb21mb3J0YWJs ZSB3aXRoIHRoYXQgc29sdXRpb24gZm9yIG5vdy4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==