[PATCH v10 0/2] Add XYUV format support

[PATCH v10 0/2] Add XYUV format support

[Stanislav Lisovskiy]

Introduced new XYUV scan-in format for framebuffer and
added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
  drm: Introduce new DRM_FORMAT_XYUV
  drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 20 insertions(+), 1 deletion(-)

-- 
2.17.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v10 1/2] drm: Introduce new DRM_FORMAT_XYUV

[Stanislav Lisovskiy]

v5: This is YUV444 packed format same as AYUV, but without alpha,
    as supported by i915.

v6: Removed unneeded initializer for new XYUV format.

v7: Added is_yuv field initialization according to latest
    drm_fourcc format structure initialization changes.

v8: Edited commit message to be more clear about skl+, renamed
    PLANE_CTL_FORMAT_AYUV to PLANE_CTL_FORMAT_XYUV as this format
    doesn't support per-pixel alpha. Fixed minor code issues.

v9: Moved DRM format check to proper place in intel_framebuffer_init.

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 drivers/gpu/drm/drm_fourcc.c  | 1 +
 include/uapi/drm/drm_fourcc.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
index 35c1e2742c27..2ad09c7ecebc 100644
--- a/drivers/gpu/drm/drm_fourcc.c
+++ b/drivers/gpu/drm/drm_fourcc.c
@@ -173,6 +173,7 @@ const struct drm_format_info *__drm_format_info(u32 format)
 		{ .format = DRM_FORMAT_UYVY,		.depth = 0,  .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1, .is_yuv = true },
 		{ .format = DRM_FORMAT_VYUY,		.depth = 0,  .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1, .is_yuv = true },
 		{ .format = DRM_FORMAT_AYUV,		.depth = 0,  .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true, .is_yuv = true },
+		{ .format = DRM_FORMAT_XYUV,		.depth = 0,  .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .is_yuv = true },
 	};
 
 	unsigned int i;
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 2ed46e9ae16a..5ba5b1473342 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -148,6 +148,7 @@ extern "C" {
 #define DRM_FORMAT_VYUY		fourcc_code('V', 'Y', 'U', 'Y') /* [31:0] Y1:Cb0:Y0:Cr0 8:8:8:8 little endian */
 
 #define DRM_FORMAT_AYUV		fourcc_code('A', 'Y', 'U', 'V') /* [31:0] A:Y:Cb:Cr 8:8:8:8 little endian */
+#define DRM_FORMAT_XYUV		fourcc_code('X', 'Y', 'U', 'V') /* [31:0] X:Y:Cb:Cr 8:8:8:8 little endian */
 
 /*
  * 2 plane RGB + A
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v10 2/2] drm/i915: Adding YUV444 packed format support for skl+

[Stanislav Lisovskiy]

PLANE_CTL_FORMAT_AYUV is already supported, according to hardware
specification.

v2: Edited commit message, removed redundant whitespaces.

v3: Fixed fallthrough logic for the format switch cases.

v4: Yet again fixed fallthrough logic, to reuse code from other case
    labels.

v5: Started to use XYUV instead of AYUV, as we don't use alpha.

v6: Removed unneeded initializer for new XYUV format.

v7: Added scaling support for DRM_FORMAT_XYUV

v8: Edited commit message to be more clear about skl+, renamed
    PLANE_CTL_FORMAT_AYUV to PLANE_CTL_FORMAT_XYUV as this format
    doesn't support per-pixel alpha. Fixed minor code issues.

v9: Moved DRM format check to proper place in intel_framebuffer_init.

v10: Added missing XYUV format to sprite planes for skl+.

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
 3 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8534f88a60f6..e0c8480aaa02 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -6499,7 +6499,7 @@ enum {
 #define   PLANE_CTL_FORMAT_XRGB_2101010		(2 << 24)
 #define   PLANE_CTL_FORMAT_XRGB_8888		(4 << 24)
 #define   PLANE_CTL_FORMAT_XRGB_16161616F	(6 << 24)
-#define   PLANE_CTL_FORMAT_AYUV			(8 << 24)
+#define   PLANE_CTL_FORMAT_XYUV			(8 << 24)
 #define   PLANE_CTL_FORMAT_INDEXED		(12 << 24)
 #define   PLANE_CTL_FORMAT_RGB_565		(14 << 24)
 #define   ICL_PLANE_CTL_FORMAT_MASK		(0x1f << 23)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 30fdfd1a3037..9323708db71f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -86,6 +86,7 @@ static const uint32_t skl_primary_formats[] = {
 	DRM_FORMAT_YVYU,
 	DRM_FORMAT_UYVY,
 	DRM_FORMAT_VYUY,
+	DRM_FORMAT_XYUV,
 };
 
 static const uint32_t skl_pri_planar_formats[] = {
@@ -101,6 +102,7 @@ static const uint32_t skl_pri_planar_formats[] = {
 	DRM_FORMAT_YVYU,
 	DRM_FORMAT_UYVY,
 	DRM_FORMAT_VYUY,
+	DRM_FORMAT_XYUV,
 	DRM_FORMAT_NV12,
 };
 
@@ -2672,6 +2674,8 @@ int skl_format_to_fourcc(int format, bool rgb_order, bool alpha)
 		return DRM_FORMAT_RGB565;
 	case PLANE_CTL_FORMAT_NV12:
 		return DRM_FORMAT_NV12;
+	case PLANE_CTL_FORMAT_XYUV:
+		return DRM_FORMAT_XYUV;
 	default:
 	case PLANE_CTL_FORMAT_XRGB_8888:
 		if (rgb_order) {
@@ -3501,6 +3505,8 @@ static u32 skl_plane_ctl_format(uint32_t pixel_format)
 		return PLANE_CTL_FORMAT_XRGB_2101010;
 	case DRM_FORMAT_XBGR2101010:
 		return PLANE_CTL_ORDER_RGBX | PLANE_CTL_FORMAT_XRGB_2101010;
+	case DRM_FORMAT_XYUV:
+		return PLANE_CTL_FORMAT_XYUV;
 	case DRM_FORMAT_YUYV:
 		return PLANE_CTL_FORMAT_YUV422 | PLANE_CTL_YUV422_YUYV;
 	case DRM_FORMAT_YVYU:
@@ -4959,6 +4965,7 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_VYUY:
 	case DRM_FORMAT_NV12:
+	case DRM_FORMAT_XYUV:
 		break;
 	default:
 		DRM_DEBUG_KMS("[PLANE:%d:%s] FB:%d unsupported scaling format 0x%x\n",
@@ -13414,6 +13421,7 @@ static bool skl_plane_format_mod_supported(struct drm_plane *_plane,
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_VYUY:
 	case DRM_FORMAT_NV12:
+	case DRM_FORMAT_XYUV:
 		if (modifier == I915_FORMAT_MOD_Yf_TILED)
 			return true;
 		/* fall through */
@@ -14540,6 +14548,13 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
 			goto err;
 		}
 		break;
+	case DRM_FORMAT_XYUV:
+		if (INTEL_GEN(dev_priv) < 9) {
+			DRM_DEBUG_KMS("unsupported pixel format: %s\n",
+				      drm_get_format_name(mode_cmd->pixel_format, &format_name));
+			goto err;
+		}
+		break;
 	case DRM_FORMAT_YUYV:
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_YVYU:
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index c286dda625e4..5c3931d2c557 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -1266,6 +1266,7 @@ static uint32_t skl_plane_formats[] = {
 	DRM_FORMAT_YVYU,
 	DRM_FORMAT_UYVY,
 	DRM_FORMAT_VYUY,
+	DRM_FORMAT_XYUV,
 };
 
 static uint32_t skl_planar_formats[] = {
@@ -1420,6 +1421,7 @@ static bool skl_plane_format_mod_supported(struct drm_plane *_plane,
 	case DRM_FORMAT_UYVY:
 	case DRM_FORMAT_VYUY:
 	case DRM_FORMAT_NV12:
+	case DRM_FORMAT_XYUV:
 		if (modifier == I915_FORMAT_MOD_Yf_TILED)
 			return true;
 		/* fall through */
-- 
2.17.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v10 0/2] Add XYUV format support

[Lisovskiy, Stanislav]

On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> Introduced new XYUV scan-in format for framebuffer and
> added support for it to i915(SkyLake+).
> 
> Stanislav Lisovskiy (2):
>   drm: Introduce new DRM_FORMAT_XYUV
>   drm/i915: Adding YUV444 packed format support for skl+
> 
>  drivers/gpu/drm/drm_fourcc.c         |  1 +
>  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
>  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
>  drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
>  include/uapi/drm/drm_fourcc.h        |  1 +
>  5 files changed, 20 insertions(+), 1 deletion(-)
> 

Ping. There is an IGT patch which got Reviewed-by Ville.
This one left in order to get XYUV support. 

-- 
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v10 0/2] Add XYUV format support

[Ville Syrjälä]

On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav wrote:
> On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > Introduced new XYUV scan-in format for framebuffer and
> > added support for it to i915(SkyLake+).
> > 
> > Stanislav Lisovskiy (2):
> >   drm: Introduce new DRM_FORMAT_XYUV
> >   drm/i915: Adding YUV444 packed format support for skl+
> > 
> >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> >  drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> >  include/uapi/drm/drm_fourcc.h        |  1 +
> >  5 files changed, 20 insertions(+), 1 deletion(-)
> > 
> 
> Ping. There is an IGT patch which got Reviewed-by Ville.
> This one left in order to get XYUV support. 

Did we figure out userspace for this?

Was the conflict solved with the other guy (forgot who it is)
trying to add the same format with a different name?

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v10 0/2] Add XYUV format support

[Lisovskiy, Stanislav]

On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav wrote:
> > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > Introduced new XYUV scan-in format for framebuffer and
> > > added support for it to i915(SkyLake+).
> > > 
> > > Stanislav Lisovskiy (2):
> > >   drm: Introduce new DRM_FORMAT_XYUV
> > >   drm/i915: Adding YUV444 packed format support for skl+
> > > 
> > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > >  drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > 
> > 
> > Ping. There is an IGT patch which got Reviewed-by Ville.
> > This one left in order to get XYUV support. 
> 
> Did we figure out userspace for this?
> 
> Was the conflict solved with the other guy (forgot who it is)
> trying to add the same format with a different name?

Currently for userspace we have VLC(checked with Juha-Pekka) and
also IGT test case.

I think those guys were from ARM and they were adding also support for
XYUV. The only difference was that they called XYUV, like XYUV8888
something. 
Our patches were otherwise identical regarding drm_fourcc.c part, I
don't see their stuff merged, but I guess it really shouldn't matter,
who does this first. i915 specific part doesn't conflict with their
stuff. To be honest, I forgot the guy's name neither could find his
email in my mailbox. 
So hopefully somebody shows up here.

> 
-- 
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v10 0/2] Add XYUV format support

[Saarinen, Jani]

Hi, 

> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Lisovskiy, Stanislav
> Sent: perjantai 14. syyskuuta 2018 17.31
> To: ville.syrjala@linux.intel.com
> Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville <ville.syrjala@intel.com>;
> Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; dri-
> devel@lists.freedesktop.org; Peres, Martin <martin.peres@intel.com>
> Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support
> 
> On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav wrote:
> > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > > Introduced new XYUV scan-in format for framebuffer and added
> > > > support for it to i915(SkyLake+).
> > > >
> > > > Stanislav Lisovskiy (2):
> > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > >
> > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > >
> > >
> > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > This one left in order to get XYUV support.
> >
> > Did we figure out userspace for this?
> >
> > Was the conflict solved with the other guy (forgot who it is) trying
> > to add the same format with a different name?
> 
> Currently for userspace we have VLC(checked with Juha-Pekka) and also IGT
> test case.
> 
> I think those guys were from ARM and they were adding also support for
> XYUV. The only difference was that they called XYUV, like XYUV8888
> something.
> Our patches were otherwise identical regarding drm_fourcc.c part, I don't
> see their stuff merged, but I guess it really shouldn't matter, who does this
> first. i915 specific part doesn't conflict with their stuff. To be honest, I forgot
> the guy's name neither could find his email in my mailbox.
> So hopefully somebody shows up here.
Stan:
Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com> ? 

> 
> >
> --
> Best Regards,
> 
> Lisovskiy Stanislav
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

[Lisovskiy, Stanislav]

On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani wrote:
> Hi, 
> 
> > -----Original Message-----
> > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On
> > Behalf
> > Of Lisovskiy, Stanislav
> > Sent: perjantai 14. syyskuuta 2018 17.31
> > To: ville.syrjala@linux.intel.com
> > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville <ville.syrjala@
> > intel.com>;
> > Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; dri-
> > devel@lists.freedesktop.org; Peres, Martin <martin.peres@intel.com>
> > Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support
> > 
> > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav
> > > wrote:
> > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > > > Introduced new XYUV scan-in format for framebuffer and added
> > > > > support for it to i915(SkyLake+).
> > > > > 
> > > > > Stanislav Lisovskiy (2):
> > > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > > > 
> > > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > 
> > > > 
> > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > This one left in order to get XYUV support.
> > > 
> > > Did we figure out userspace for this?
> > > 
> > > Was the conflict solved with the other guy (forgot who it is)
> > > trying
> > > to add the same format with a different name?
> > 
> > Currently for userspace we have VLC(checked with Juha-Pekka) and
> > also IGT
> > test case.
> > 
> > I think those guys were from ARM and they were adding also support
> > for
> > XYUV. The only difference was that they called XYUV, like XYUV8888
> > something.
> > Our patches were otherwise identical regarding drm_fourcc.c part, I
> > don't
> > see their stuff merged, but I guess it really shouldn't matter, who
> > does this
> > first. i915 specific part doesn't conflict with their stuff. To be
> > honest, I forgot
> > the guy's name neither could find his email in my mailbox.
> > So hopefully somebody shows up here.
> 
> Stan:
> Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com> ? 
> 

Exactly, found now. Thanks for the hint! 

> > 
> > > 
> > 
> > --
> > Best Regards,
> > 
> > Lisovskiy Stanislav
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-- 
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v10 0/2] Add XYUV format support

[Alexandru-Cosmin Gheorghe]

On Fri, Sep 14, 2018 at 02:49:09PM +0000, Lisovskiy, Stanislav wrote:
> On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani wrote:
> > Hi, 
> > 
> > > -----Original Message-----
> > > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On
> > > Behalf
> > > Of Lisovskiy, Stanislav
> > > Sent: perjantai 14. syyskuuta 2018 17.31
> > > To: ville.syrjala@linux.intel.com
> > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville <ville.syrjala@
> > > intel.com>;
> > > Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; dri-
> > > devel@lists.freedesktop.org; Peres, Martin <martin.peres@intel.com>
> > > Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support
> > > 
> > > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav
> > > > wrote:
> > > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > > > > Introduced new XYUV scan-in format for framebuffer and added
> > > > > > support for it to i915(SkyLake+).
> > > > > > 
> > > > > > Stanislav Lisovskiy (2):
> > > > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > > > > 
> > > > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > > >  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > > > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > > 
> > > > > 
> > > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > > This one left in order to get XYUV support.
> > > > 
> > > > Did we figure out userspace for this?
> > > > 
> > > > Was the conflict solved with the other guy (forgot who it is)
> > > > trying
> > > > to add the same format with a different name?
> > > 
> > > Currently for userspace we have VLC(checked with Juha-Pekka) and
> > > also IGT
> > > test case.
> > > 
> > > I think those guys were from ARM and they were adding also support
> > > for
> > > XYUV. The only difference was that they called XYUV, like XYUV8888
> > > something.
> > > Our patches were otherwise identical regarding drm_fourcc.c part, I
> > > don't
> > > see their stuff merged, but I guess it really shouldn't matter, who
> > > does this
> > > first. i915 specific part doesn't conflict with their stuff. To be
> > > honest, I forgot
> > > the guy's name neither could find his email in my mailbox.
> > > So hopefully somebody shows up here.
> > 
> > Stan:
> > Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com> ? 
> > 
> 
> Exactly, found now. Thanks for the hint! 

Yes, that's me.
Not a real conflict here, as long as your patches are ready to be
merged feel free to do it and I will just rebase my series on top of
that.


> 
> > > 
> > > > 
> > > 
> > > --
> > > Best Regards,
> > > 
> > > Lisovskiy Stanislav
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> -- 
> Best Regards,
> 
> Lisovskiy Stanislav
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Cheers,
Alex G
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

[Lisovskiy, Stanislav]

On Fri, 2018-09-14 at 14:59 +0000, Alexandru-Cosmin Gheorghe wrote:
> On Fri, Sep 14, 2018 at 02:49:09PM +0000, Lisovskiy, Stanislav wrote:
> > On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani wrote:
> > > Hi, 
> > > 
> > > > -----Original Message-----
> > > > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org
> > > > ] On
> > > > Behalf
> > > > Of Lisovskiy, Stanislav
> > > > Sent: perjantai 14. syyskuuta 2018 17.31
> > > > To: ville.syrjala@linux.intel.com
> > > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville
> > > > <ville.syrjala@
> > > > intel.com>;
> > > > Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; dri-
> > > > devel@lists.freedesktop.org; Peres, Martin <martin.peres@intel.
> > > > com>
> > > > Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format
> > > > support
> > > > 
> > > > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy,
> > > > > Stanislav
> > > > > wrote:
> > > > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy
> > > > > > wrote:
> > > > > > > Introduced new XYUV scan-in format for framebuffer and
> > > > > > > added
> > > > > > > support for it to i915(SkyLake+).
> > > > > > > 
> > > > > > > Stanislav Lisovskiy (2):
> > > > > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > > > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > > > > > 
> > > > > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > > > >  drivers/gpu/drm/i915/intel_display.c | 15
> > > > > > > +++++++++++++++
> > > > > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > > > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > > > 
> > > > > > 
> > > > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > > > This one left in order to get XYUV support.
> > > > > 
> > > > > Did we figure out userspace for this?
> > > > > 
> > > > > Was the conflict solved with the other guy (forgot who it is)
> > > > > trying
> > > > > to add the same format with a different name?
> > > > 
> > > > Currently for userspace we have VLC(checked with Juha-Pekka)
> > > > and
> > > > also IGT
> > > > test case.
> > > > 
> > > > I think those guys were from ARM and they were adding also
> > > > support
> > > > for
> > > > XYUV. The only difference was that they called XYUV, like
> > > > XYUV8888
> > > > something.
> > > > Our patches were otherwise identical regarding drm_fourcc.c
> > > > part, I
> > > > don't
> > > > see their stuff merged, but I guess it really shouldn't matter,
> > > > who
> > > > does this
> > > > first. i915 specific part doesn't conflict with their stuff. To
> > > > be
> > > > honest, I forgot
> > > > the guy's name neither could find his email in my mailbox.
> > > > So hopefully somebody shows up here.
> > > 
> > > Stan:
> > > Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com> ? 
> > > 
> > 
> > Exactly, found now. Thanks for the hint! 
> 
> Yes, that's me.
> Not a real conflict here, as long as your patches are ready to be
> merged feel free to do it and I will just rebase my series on top of
> that.

I can change DRM_FORMAT_XYUV naming to DRM_FORMAT_XYUV8888 also, so
that my patch series then is compatible with yours.

> 
> 
> > 
> > > > 
> > > > > 
> > > > 
> > > > --
> > > > Best Regards,
> > > > 
> > > > Lisovskiy Stanislav
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > 
> > -- 
> > Best Regards,
> > 
> > Lisovskiy Stanislav
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> 
-- 
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v10 0/2] Add XYUV format support

[Alexandru-Cosmin Gheorghe]

Hi,

On Mon, Sep 17, 2018 at 08:27:18AM +0000, Lisovskiy, Stanislav wrote:
> On Fri, 2018-09-14 at 14:59 +0000, Alexandru-Cosmin Gheorghe wrote:
> > On Fri, Sep 14, 2018 at 02:49:09PM +0000, Lisovskiy, Stanislav wrote:
> > > On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani wrote:
> > > > Hi, 
> > > > 
> > > > > -----Original Message-----
> > > > > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org
> > > > > ] On
> > > > > Behalf
> > > > > Of Lisovskiy, Stanislav
> > > > > Sent: perjantai 14. syyskuuta 2018 17.31
> > > > > To: ville.syrjala@linux.intel.com
> > > > > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville
> > > > > <ville.syrjala@
> > > > > intel.com>;
> > > > > Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; dri-
> > > > > devel@lists.freedesktop.org; Peres, Martin <martin.peres@intel.
> > > > > com>
> > > > > Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format
> > > > > support
> > > > > 
> > > > > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > > > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy,
> > > > > > Stanislav
> > > > > > wrote:
> > > > > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy
> > > > > > > wrote:
> > > > > > > > Introduced new XYUV scan-in format for framebuffer and
> > > > > > > > added
> > > > > > > > support for it to i915(SkyLake+).
> > > > > > > > 
> > > > > > > > Stanislav Lisovskiy (2):
> > > > > > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > > > > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > > > > > > 
> > > > > > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > > > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > > > > >  drivers/gpu/drm/i915/intel_display.c | 15
> > > > > > > > +++++++++++++++
> > > > > > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > > > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > > > > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > > > > 
> > > > > > > 
> > > > > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > > > > This one left in order to get XYUV support.
> > > > > > 
> > > > > > Did we figure out userspace for this?
> > > > > > 
> > > > > > Was the conflict solved with the other guy (forgot who it is)
> > > > > > trying
> > > > > > to add the same format with a different name?
> > > > > 
> > > > > Currently for userspace we have VLC(checked with Juha-Pekka)
> > > > > and
> > > > > also IGT
> > > > > test case.
> > > > > 
> > > > > I think those guys were from ARM and they were adding also
> > > > > support
> > > > > for
> > > > > XYUV. The only difference was that they called XYUV, like
> > > > > XYUV8888
> > > > > something.
> > > > > Our patches were otherwise identical regarding drm_fourcc.c
> > > > > part, I
> > > > > don't
> > > > > see their stuff merged, but I guess it really shouldn't matter,
> > > > > who
> > > > > does this
> > > > > first. i915 specific part doesn't conflict with their stuff. To
> > > > > be
> > > > > honest, I forgot
> > > > > the guy's name neither could find his email in my mailbox.
> > > > > So hopefully somebody shows up here.
> > > > 
> > > > Stan:
> > > > Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com> ? 
> > > > 
> > > 
> > > Exactly, found now. Thanks for the hint! 
> > 
> > Yes, that's me.
> > Not a real conflict here, as long as your patches are ready to be
> > merged feel free to do it and I will just rebase my series on top of
> > that.
> 
> I can change DRM_FORMAT_XYUV naming to DRM_FORMAT_XYUV8888 also, so
> that my patch series then is compatible with yours.

That would be nice.
Thank you.

> 
> > 
> > 
> > > 
> > > > > 
> > > > > > 
> > > > > 
> > > > > --
> > > > > Best Regards,
> > > > > 
> > > > > Lisovskiy Stanislav
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > Intel-gfx@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > 
> > > -- 
> > > Best Regards,
> > > 
> > > Lisovskiy Stanislav
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > 
> > 
> -- 
> Best Regards,
> 
> Lisovskiy Stanislav

-- 
Cheers,
Alex G
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v10 0/2] Add XYUV format support

[Juha-Pekka Heikkilä]

Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:
> On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
>> On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav wrote:
>>> On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
>>>> Introduced new XYUV scan-in format for framebuffer and
>>>> added support for it to i915(SkyLake+).
>>>>
>>>> Stanislav Lisovskiy (2):
>>>>    drm: Introduce new DRM_FORMAT_XYUV
>>>>    drm/i915: Adding YUV444 packed format support for skl+
>>>>
>>>>   drivers/gpu/drm/drm_fourcc.c         |  1 +
>>>>   drivers/gpu/drm/i915/i915_reg.h      |  2 +-
>>>>   drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
>>>>   drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
>>>>   include/uapi/drm/drm_fourcc.h        |  1 +
>>>>   5 files changed, 20 insertions(+), 1 deletion(-)
>>>>
>>>
>>> Ping. There is an IGT patch which got Reviewed-by Ville.
>>> This one left in order to get XYUV support.
>>
>> Did we figure out userspace for this?
>>
>> Was the conflict solved with the other guy (forgot who it is)
>> trying to add the same format with a different name?
> 
> Currently for userspace we have VLC(checked with Juha-Pekka) and
> also IGT test case.

Hei, no. VLC was *not* showing the mode correctly back then when we 
tested. VLC kms plugin is able to initialize the mode and it's all 
stable but VLC didn't have correct video converter to reach matching 
xYUV output. You remember Stan we tried to increase the recursion for 
decoding in case it would help? VLC doesn't have codec which produce 
correct output, one of those xxx -> YUV plug-ins in VLC should be 
patched before VLC can be considered as userspace for this mode.

/Juha-Pekka

> 
> I think those guys were from ARM and they were adding also support for
> XYUV. The only difference was that they called XYUV, like XYUV8888
> something.
> Our patches were otherwise identical regarding drm_fourcc.c part, I
> don't see their stuff merged, but I guess it really shouldn't matter,
> who does this first. i915 specific part doesn't conflict with their
> stuff. To be honest, I forgot the guy's name neither could find his
> email in my mailbox.
> So hopefully somebody shows up here.
> 
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

[Lisovskiy, Stanislav]

On Fri, 2018-09-14 at 20:05 +0300, Juha-Pekka Heikkilä wrote:
> 
> Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:
> > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav
> > > wrote:
> > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > > > Introduced new XYUV scan-in format for framebuffer and
> > > > > added support for it to i915(SkyLake+).
> > > > > 
> > > > > Stanislav Lisovskiy (2):
> > > > >    drm: Introduce new DRM_FORMAT_XYUV
> > > > >    drm/i915: Adding YUV444 packed format support for skl+
> > > > > 
> > > > >   drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > >   drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > >   drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > > > >   drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > >   include/uapi/drm/drm_fourcc.h        |  1 +
> > > > >   5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > 
> > > > 
> > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > This one left in order to get XYUV support.
> > > 
> > > Did we figure out userspace for this?
> > > 
> > > Was the conflict solved with the other guy (forgot who it is)
> > > trying to add the same format with a different name?
> > 
> > Currently for userspace we have VLC(checked with Juha-Pekka) and
> > also IGT test case.
> 
> Hei, no. VLC was *not* showing the mode correctly back then when we 
> tested. VLC kms plugin is able to initialize the mode and it's all 
> stable but VLC didn't have correct video converter to reach matching 
> xYUV output. You remember Stan we tried to increase the recursion
> for 
> decoding in case it would help? VLC doesn't have codec which produce 
> correct output, one of those xxx -> YUV plug-ins in VLC should be 
> patched before VLC can be considered as userspace for this mode.

Ok, I remember we managed to make it work somehow and saw some picture,
so for some reason I thought it is working already. What is our plan
then? Should we try to improve VLC codecs/plugins or may be I should
then work with some other user space case?

> 
> /Juha-Pekka
> 
> > 
> > I think those guys were from ARM and they were adding also support
> > for
> > XYUV. The only difference was that they called XYUV, like XYUV8888
> > something.
> > Our patches were otherwise identical regarding drm_fourcc.c part, I
> > don't see their stuff merged, but I guess it really shouldn't
> > matter,
> > who does this first. i915 specific part doesn't conflict with their
> > stuff. To be honest, I forgot the guy's name neither could find his
> > email in my mailbox.
> > So hopefully somebody shows up here.
> > 
> > > 
-- 
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

[Juha-Pekka Heikkila]

On 17.09.2018 11:25, Lisovskiy, Stanislav wrote:
> On Fri, 2018-09-14 at 20:05 +0300, Juha-Pekka Heikkilä wrote:
>>
>> Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:
>>> On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
>>>> On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav
>>>> wrote:
>>>>> On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
>>>>>> Introduced new XYUV scan-in format for framebuffer and
>>>>>> added support for it to i915(SkyLake+).
>>>>>>
>>>>>> Stanislav Lisovskiy (2):
>>>>>>     drm: Introduce new DRM_FORMAT_XYUV
>>>>>>     drm/i915: Adding YUV444 packed format support for skl+
>>>>>>
>>>>>>    drivers/gpu/drm/drm_fourcc.c         |  1 +
>>>>>>    drivers/gpu/drm/i915/i915_reg.h      |  2 +-
>>>>>>    drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
>>>>>>    drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
>>>>>>    include/uapi/drm/drm_fourcc.h        |  1 +
>>>>>>    5 files changed, 20 insertions(+), 1 deletion(-)
>>>>>>
>>>>>
>>>>> Ping. There is an IGT patch which got Reviewed-by Ville.
>>>>> This one left in order to get XYUV support.
>>>>
>>>> Did we figure out userspace for this?
>>>>
>>>> Was the conflict solved with the other guy (forgot who it is)
>>>> trying to add the same format with a different name?
>>>
>>> Currently for userspace we have VLC(checked with Juha-Pekka) and
>>> also IGT test case.
>>
>> Hei, no. VLC was *not* showing the mode correctly back then when we
>> tested. VLC kms plugin is able to initialize the mode and it's all
>> stable but VLC didn't have correct video converter to reach matching
>> xYUV output. You remember Stan we tried to increase the recursion
>> for
>> decoding in case it would help? VLC doesn't have codec which produce
>> correct output, one of those xxx -> YUV plug-ins in VLC should be
>> patched before VLC can be considered as userspace for this mode.
> 
> Ok, I remember we managed to make it work somehow and saw some picture,
> so for some reason I thought it is working already. What is our plan
> then? Should we try to improve VLC codecs/plugins or may be I should
> then work with some other user space case?
> 

For VLC there are codecs which know about xYUV format but they seem to 
use it for input, I figure nobody so far needed it for output. If want 
to use VLC as userspace demo one of those codecs need to be patched up 
for outputting xYUV. As they already support many other YUV formats I 
wouldn't expect needed change to be significant on code level as KMS 
support is already in VLC.

>>
>> /Juha-Pekka
>>
>>>
>>> I think those guys were from ARM and they were adding also support
>>> for
>>> XYUV. The only difference was that they called XYUV, like XYUV8888
>>> something.
>>> Our patches were otherwise identical regarding drm_fourcc.c part, I
>>> don't see their stuff merged, but I guess it really shouldn't
>>> matter,
>>> who does this first. i915 specific part doesn't conflict with their
>>> stuff. To be honest, I forgot the guy's name neither could find his
>>> email in my mailbox.
>>> So hopefully somebody shows up here.
>>>
>>>>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v10 0/2] Add XYUV format support

[Stanislav Lisovskiy]

Introduced new XYUV scan-in format for framebuffer and
added support for it to i915(SkyLake+).

Stanislav Lisovskiy (2):
  drm: Introduce new DRM_FORMAT_XYUV
  drm/i915: Adding YUV444 packed format support for skl+

 drivers/gpu/drm/drm_fourcc.c         |  1 +
 drivers/gpu/drm/i915/i915_reg.h      |  2 +-
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
 drivers/gpu/drm/i915/intel_sprite.c  |  3 +++
 include/uapi/drm/drm_fourcc.h        |  1 +
 5 files changed, 21 insertions(+), 1 deletion(-)

-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx