From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only
Date: Thu, 20 Sep 2018 17:09:43 +0100 [thread overview]
Message-ID: <20180920160943.GK30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <6109476a-e8fa-6d82-3ed8-3833f0f18615@xs4all.nl>
Hi Hans,
Patch merged, thanks.
On Mon, Aug 27, 2018 at 02:28:50PM +0200, Hans Verkuil wrote:
> The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to
> prevent the CEC framework from retrying the transmit. If the
> transmit was successful, then don't set this flag.
>
> Found by running 'cec-compliance -A' on a beaglebone box.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> drivers/gpu/drm/i2c/tda9950.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/i2c/tda9950.c
> index 5d2f0d548469..4a14fc3b5011 100644
> --- a/drivers/gpu/drm/i2c/tda9950.c
> +++ b/drivers/gpu/drm/i2c/tda9950.c
> @@ -191,7 +191,8 @@ static irqreturn_t tda9950_irq(int irq, void *data)
> break;
> }
> /* TDA9950 executes all retries for us */
> - tx_status |= CEC_TX_STATUS_MAX_RETRIES;
> + if (tx_status != CEC_TX_STATUS_OK)
> + tx_status |= CEC_TX_STATUS_MAX_RETRIES;
> cec_transmit_done(priv->adap, tx_status, arb_lost_cnt,
> nack_cnt, 0, err_cnt);
> break;
> --
> 2.18.0
>
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-09-20 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 12:28 [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only Hans Verkuil
2018-09-11 6:41 ` Hans Verkuil
2018-09-13 9:33 ` Russell King - ARM Linux
2018-09-13 13:16 ` Daniel Vetter
2018-09-13 13:33 ` Hans Verkuil
2018-09-13 13:42 ` Daniel Vetter
2018-09-13 13:48 ` Russell King - ARM Linux
2018-09-13 13:53 ` Hans Verkuil
2018-09-14 8:06 ` Daniel Vetter
2018-09-13 9:26 ` Gustavo Padovan
2018-09-20 16:09 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920160943.GK30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).