From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/5] drm/dp: Implement I2C_M_STOP for i2c-over-aux
Date: Fri, 28 Sep 2018 21:04:01 +0300 [thread overview]
Message-ID: <20180928180403.22499-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20180928180403.22499-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Consult the I2C_M_STOP flag to determine whether to set the MOT bit or
not. Makes it possible to send multiple messages in one go with
stop+start generated between the messages (as opposed nothing or
repstart depending on whether thr address/rw changed).
Not sure anyone has actual use for this but figured I'd handle it
since I started to look at that flag for MST remote i2c xfers.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_dp_helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 37c01b6076ec..e85cea299d2a 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -884,7 +884,8 @@ static void drm_dp_i2c_msg_set_request(struct drm_dp_aux_msg *msg,
{
msg->request = (i2c_msg->flags & I2C_M_RD) ?
DP_AUX_I2C_READ : DP_AUX_I2C_WRITE;
- msg->request |= DP_AUX_I2C_MOT;
+ if (!(i2c_msg->flags & I2C_M_STOP))
+ msg->request |= DP_AUX_I2C_MOT;
}
/*
--
2.16.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-28 18:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 18:03 [PATCH 1/5] drm/dp/mst: Configure no_stop_bit correctly for remote i2c xfers Ville Syrjala
2018-09-28 18:04 ` [PATCH 2/5] drm/dp/mst: Validate REMOTE_I2C_READ harder Ville Syrjala
2018-12-07 23:11 ` Dhinakaran Pandiyan
2018-09-28 18:04 ` Ville Syrjala [this message]
2018-12-11 2:47 ` [PATCH 3/5] drm/dp: Implement I2C_M_STOP for i2c-over-aux Dhinakaran Pandiyan
2018-12-12 10:30 ` Daniel Vetter
2018-12-12 12:12 ` Ville Syrjälä
2018-09-28 18:04 ` [PATCH 4/5] drm/dp/mst: Provide defines for ACK vs. NAK reply type Ville Syrjala
2018-12-08 0:22 ` [Intel-gfx] " Dhinakaran Pandiyan
2018-09-28 18:04 ` [PATCH 5/5] drm/dp/mst: Provide better debugs for NAK replies Ville Syrjala
2018-09-28 21:55 ` kbuild test robot
2018-12-08 0:57 ` [Intel-gfx] " Dhinakaran Pandiyan
2018-12-08 1:05 ` Dhinakaran Pandiyan
2018-12-07 20:45 ` [PATCH 1/5] drm/dp/mst: Configure no_stop_bit correctly for remote i2c xfers Dhinakaran Pandiyan
2018-12-07 22:52 ` [Intel-gfx] " Dhinakaran Pandiyan
2018-12-10 16:39 ` Ville Syrjälä
2018-12-10 20:09 ` [Intel-gfx] " Dhinakaran Pandiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928180403.22499-3-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox