From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 05/18] drm: Add helper to implement legacy dirtyfb Date: Mon, 1 Oct 2018 10:08:26 +0200 Message-ID: <20181001080826.GT11082@phenom.ffwll.local> References: <20180928003020.1737-1-drawat@vmware.com> <20180928003020.1737-5-drawat@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1649E6E0AC for ; Mon, 1 Oct 2018 08:08:31 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id e15-v6so13321926edr.4 for ; Mon, 01 Oct 2018 01:08:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180928003020.1737-5-drawat@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Deepak Rawat Cc: thellstrom@vmware.com, Daniel Vetter , dri-devel@lists.freedesktop.org, linux-graphics-maintainer@vmware.com List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBTZXAgMjcsIDIwMTggYXQgMDU6MzA6MDdQTSAtMDcwMCwgRGVlcGFrIFJhd2F0IHdy b3RlOgo+IEZyb206IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4KPiAKPiBBZGQgYW4g YXRvbWljIGhlbHBlciB0byBpbXBsZW1lbnQgZGlydHlmYiBzdXBwb3J0LiAgVGhpcyBpcyBuZWVk ZWQgdG8KPiBzdXBwb3J0IERTSSBjb21tYW5kLW1vZGUgcGFuZWxzIHdpdGggeDExIHVzZXJzcGFj ZSAoaWUuIHdoZW4gd2UgY2FuJ3QKPiByZWx5IG9uIHBhZ2VmbGlwcyB0byB0cmlnZ2VyIGEgZmx1 c2ggdG8gdGhlIHBhbmVsKS4KPiAKPiB2MjogTW9kaWZpZWQgdGhlIGhlbHBlciB0byB1c2UgcGxh bmUgZmJfZGFtYWdlX2NsaXBzIHByb3BlcnR5IGFuZAo+IHJlbW92ZWQgcGxhbmVfc3RhdGU6OmRp cnR5IGZsYWcuCj4gCj4gdjM6Cj4gLSBVc2UgdWFwaSBkcm1fbW9kZV9yZWN0Lgo+IC0gU3VwcG9y dCBhbm5vdGF0ZSBmbGFncy4KPiAKPiBDYzogdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20K PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogUGVra2Eg UGFhbGFuZW4gPHBwYWFsYW5lbkBnbWFpbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUm9iIENsYXJr IDxyb2JkY2xhcmtAZ21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERlZXBhayBSYXdhdCA8ZHJh d2F0QHZtd2FyZS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZGFtYWdlX2hlbHBl ci5jIHwgMTIxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9kcm0vZHJt X2RhbWFnZV9oZWxwZXIuaCAgICAgfCAgIDQgKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDEyNSBpbnNl cnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGFtYWdlX2hl bHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kYW1hZ2VfaGVscGVyLmMKPiBpbmRleCBiYzcz NGRkYWYxODAuLmVjZjI2Mjc1NTQzZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2RhbWFnZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGFtYWdlX2hlbHBl ci5jCj4gQEAgLTI2LDYgKzI2LDcgQEAKPiAgICoKPiAgICogQXV0aG9yczoKPiAgICogRGVlcGFr IFJhd2F0IDxkcmF3YXRAdm13YXJlLmNvbT4KPiArICogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21h aWwuY29tPgo+ICAgKgo+ICAgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovCj4gIAo+IEBAIC03MCw2ICs3MSwy MSBAQAo+ICAgKiByZWN0YW5nbGVzIGNsaXBwZWQgdG8gJmRybV9wbGFuZV9zdGF0ZS5zcmMuCj4g ICAqLwo+ICAKPiArc3RhdGljIHZvaWQgY29udmVydF9jbGlwX3JlY3RfdG9fcmVjdChjb25zdCBz dHJ1Y3QgZHJtX2NsaXBfcmVjdCAqc3JjLAo+ICsJCQkJICAgICAgc3RydWN0IGRybV9tb2RlX3Jl Y3QgKmRlc3QsCj4gKwkJCQkgICAgICB1aW50MzJfdCBudW1fY2xpcHMsIHVpbnQzMl90IHNyY19p bmMpCj4gK3sKPiArCXdoaWxlIChudW1fY2xpcHMgPiAwKSB7Cj4gKwkJZGVzdC0+eDEgPSBzcmMt PngxOwo+ICsJCWRlc3QtPnkxID0gc3JjLT55MTsKPiArCQlkZXN0LT54MiA9IHNyYy0+eDI7Cj4g KwkJZGVzdC0+eTIgPSBzcmMtPnkyOwo+ICsJCXNyYyArPSBzcmNfaW5jOwo+ICsJCWRlc3QrKzsK PiArCQludW1fY2xpcHMtLTsKPiArCX0KPiArfQo+ICsKPiAgLyoqCj4gICAqIGRybV9wbGFuZV9l bmFibGVfZmJfZGFtYWdlX2NsaXBzIC0gRW5hYmxlcyBwbGFuZSBmYiBkYW1hZ2UgY2xpcHMgcHJv cGVydHkuCj4gICAqIEBwbGFuZTogUGxhbmUgb24gd2hpY2ggdG8gZW5hYmxlIGRhbWFnZSBjbGlw cyBwcm9wZXJ0eS4KPiBAQCAtMTIzLDYgKzEzOSwxMTEgQEAgdm9pZCBkcm1fYXRvbWljX2hlbHBl cl9jaGVja19wbGFuZV9kYW1hZ2Uoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICB9 Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVfZGFtYWdlKTsK PiAgCj4gKy8qKgo+ICsgKiBkcm1fYXRvbWljX2hlbHBlcl9kaXJ0eWZiIC0gSGVscGVyIGZvciBk aXJ0eWZiLgo+ICsgKiBAZmI6IERSTSBmcmFtZWJ1ZmZlci4KPiArICogQGZpbGVfcHJpdjogRHJt IGZpbGUgZm9yIHRoZSBpb2N0bCBjYWxsLgo+ICsgKiBAZmxhZ3M6IERpcnR5IGZiIGFubm90YXRl IGZsYWdzLgo+ICsgKiBAY29sb3I6IENvbG9yIGZvciBhbm5vdGF0ZSBmaWxsLgo+ICsgKiBAY2xp cHM6IERpcnR5IHJlZ2lvbi4KPiArICogQG51bV9jbGlwczogQ291bnQgb2YgY2xpcCBpbiBjbGlw cy4KPiArICoKPiArICogQSBoZWxwZXIgdG8gaW1wbGVtZW50ICZkcm1fZnJhbWVidWZmZXJfZnVu Y3M6OmRpcnR5IHVzaW5nIGRhbWFnZSBpbnRlcmZhY2UKPiArICogZHVyaW5nIHBsYW5lIHVwZGF0 ZS4gU2ltaWxhciB0byBpb2N0bCwgdGhpcyBoZWxwZXIgZG8gYSBmdWxsIHBsYW5lIHVwZGF0ZQo+ ICsgKiB3aGVuIG5vIGNsaXBzIGFyZSBwcm92aWRlZC4KClRoZSBhYm92ZSBrZXJuZWxkb2MgZG9l c24ndCBtYWtlIHNlbnNlIHRvIG1lIC4uLiB3ZSBkbyBoYXZlIGNsaXBzIHByb3ZpZGVkCmhlcmUs IGl0J3MganVzdCBhIGRpZmZlcmVudCBsYXlvdXQuCgo+ICsgKgo+ICsgKiBSZXR1cm5zOiBaZXJv IG9uIHN1Y2Nlc3MsIG5lZ2F0aXZlIGVycm5vIG9uIGZhaWx1cmUuCj4gKyAqLwo+ICtpbnQgZHJt X2F0b21pY19oZWxwZXJfZGlydHlmYihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiArCQkJ ICAgICAgc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYsIHVuc2lnbmVkIGZsYWdzLAo+ICsJCQkg ICAgICB1bnNpZ25lZCBjb2xvciwgc3RydWN0IGRybV9jbGlwX3JlY3QgKmNsaXBzLAo+ICsJCQkg ICAgICB1bnNpZ25lZCBudW1fY2xpcHMpCj4gK3sKPiArCXN0cnVjdCBkcm1fbW9kZXNldF9hY3F1 aXJlX2N0eCBjdHg7Cj4gKwlzdHJ1Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKmRhbWFnZSA9IE5VTEw7 Cj4gKwlzdHJ1Y3QgZHJtX21vZGVfcmVjdCAqcmVjdHMgPSBOVUxMOwo+ICsJc3RydWN0IGRybV9h dG9taWNfc3RhdGUgKnN0YXRlOwo+ICsJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gKwlpbnQg cmV0ID0gMDsKPiArCj4gKwkvKgo+ICsJICogV2hlbiBjYWxsZWQgZnJvbSBpb2N0bCwgd2UgYXJl IGludGVycnVwdGFibGUsIGJ1dCBub3Qgd2hlbiBjYWxsZWQKPiArCSAqIGludGVybmFsbHkgKGll LiBkZWZpbyB3b3JrZXIpCj4gKwkgKi8KPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfaW5pdCgmY3R4 LAo+ICsJCWZpbGVfcHJpdiA/IERSTV9NT0RFU0VUX0FDUVVJUkVfSU5URVJSVVBUSUJMRSA6IDAp Owo+ICsKPiArCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhmYi0+ZGV2KTsKPiArCWlm ICghc3RhdGUpIHsKPiArCQlyZXQgPSAtRU5PTUVNOwo+ICsJCWdvdG8gb3V0Owo+ICsJfQo+ICsJ c3RhdGUtPmFjcXVpcmVfY3R4ID0gJmN0eDsKPiArCj4gKwlpZiAoY2xpcHMpIHsKPiArCQl1aW50 MzJfdCBpbmMgPSAxOwo+ICsKPiArCQlpZiAoZmxhZ3MgJiBEUk1fTU9ERV9GQl9ESVJUWV9BTk5P VEFURV9DT1BZKSB7Cj4gKwkJCWluYyA9IDI7Cj4gKwkJCW51bV9jbGlwcyAvPSAyOwo+ICsJCX0K PiArCj4gKwkJcmVjdHMgPSBrY2FsbG9jKG51bV9jbGlwcywgc2l6ZW9mKCpyZWN0cyksIEdGUF9L RVJORUwpOwo+ICsJCWlmICghcmVjdHMpIHsKPiArCQkJcmV0ID0gLUVOT01FTTsKPiArCQkJZ290 byBvdXQ7Cj4gKwkJfQo+ICsKPiArCQljb252ZXJ0X2NsaXBfcmVjdF90b19yZWN0KGNsaXBzLCBy ZWN0cywgbnVtX2NsaXBzLCBpbmMpOwo+ICsJCWRhbWFnZSA9IGRybV9wcm9wZXJ0eV9jcmVhdGVf YmxvYihmYi0+ZGV2LAo+ICsJCQkJCQkgIG51bV9jbGlwcyAqIHNpemVvZigqcmVjdHMpLAo+ICsJ CQkJCQkgIHJlY3RzKTsKPiArCQlpZiAoSVNfRVJSKGRhbWFnZSkpIHsKPiArCQkJcmV0ID0gUFRS X0VSUihkYW1hZ2UpOwo+ICsJCQlkYW1hZ2UgPSBOVUxMOwo+ICsJCQlnb3RvIG91dDsKPiArCQl9 Cj4gKwl9Cj4gKwo+ICtyZXRyeToKPiArCWRybV9mb3JfZWFjaF9wbGFuZShwbGFuZSwgZmItPmRl dikgewo+ICsJCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlOwo+ICsKPiArCQlp ZiAocGxhbmUtPnN0YXRlLT5mYiAhPSBmYikKPiArCQkJY29udGludWU7Cj4gKwo+ICsJCXBsYW5l X3N0YXRlID0gZHJtX2F0b21pY19nZXRfcGxhbmVfc3RhdGUoc3RhdGUsIHBsYW5lKTsKPiArCQlp ZiAoSVNfRVJSKHBsYW5lX3N0YXRlKSkgewo+ICsJCQlyZXQgPSBQVFJfRVJSKHBsYW5lX3N0YXRl KTsKPiArCQkJZ290byBvdXQ7Cj4gKwkJfQo+ICsKPiArCQlkcm1fcHJvcGVydHlfcmVwbGFjZV9i bG9iKCZwbGFuZV9zdGF0ZS0+ZmJfZGFtYWdlX2NsaXBzLAo+ICsJCQkJCSAgZGFtYWdlKTsKPiAr CX0KPiArCj4gKwlyZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0ZSk7CgpUaGlzIGJsb2Nrcywg d2hpY2ggbWF0Y2hlcyB3aGF0IHVkbCBkb2VzIChvbmUgb2YgdGhlIHZlcnkgZmlyc3QKaW1wbGVt ZW50YXRpb25zIG9mIHRoZSBmYi0+ZGlydHkgY2FsbGJhY2spLiBJIGdvdCBsb3N0IGEgYml0IGlu IHRoZSB2bXdnZngKZGlydHkgaW1wbGVtZW50YXRpb24sIHNvIG5vIGlkZWEgd2hldGhlciB0aGF0 IG9uZSBibG9ja2VkIG9yIG5vdC4KCklmIHRoZSBibG9ja2luZyBoZXJlIGlzIGEgcHJvYmxlbSwg dGhlbiB3ZSBuZWVkIGEgc2VwYXJhdGUgd29ya2VyCnNpbWlsYXJseSB0byB3aGF0IHRoZSBmYmRl diB3b3JrZXIgZG9lcyAoc2luY2UgdXNpbmcgdGhlIGF0b21pYwpub25ibG9ja2luZyBzdHVmZiBo YXMgdWFwaSBzaWRlLWVmZmVjdHMpLgoKRWl0aGVyIHdheSwgcHJvYmFibHkgc29tZXRoaW5nIHdl IG5lZWQgdG8gZG9jdW1lbnQgaW4gdGhlIGtlcm5lbC1kb2MuCi1EYW5pZWwKCj4gKwo+ICtvdXQ6 Cj4gKwlpZiAocmV0ID09IC1FREVBRExLKSB7Cj4gKwkJZHJtX2F0b21pY19zdGF0ZV9jbGVhcihz dGF0ZSk7Cj4gKwkJcmV0ID0gZHJtX21vZGVzZXRfYmFja29mZigmY3R4KTsKPiArCQlpZiAoIXJl dCkKPiArCQkJZ290byByZXRyeTsKPiArCX0KPiArCj4gKwlkcm1fcHJvcGVydHlfYmxvYl9wdXQo ZGFtYWdlKTsKPiArCWtmcmVlKHJlY3RzKTsKPiArCWRybV9hdG9taWNfc3RhdGVfcHV0KHN0YXRl KTsKPiArCj4gKwlkcm1fbW9kZXNldF9kcm9wX2xvY2tzKCZjdHgpOwo+ICsJZHJtX21vZGVzZXRf YWNxdWlyZV9maW5pKCZjdHgpOwo+ICsKPiArCXJldHVybiByZXQ7Cj4gKwo+ICt9Cj4gK0VYUE9S VF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfZGlydHlmYik7Cj4gKwo+ICAvKioKPiAgICogZHJt X2F0b21pY19oZWxwZXJfZGFtYWdlX2l0ZXJfaW5pdCAtIEluaXRpYWxpemUgdGhlIGRhbWFnZSBp dGVyYXRvci4KPiAgICogQGl0ZXI6IFRoZSBpdGVyYXRvciB0byBpbml0aWFsaXplLgo+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZGFtYWdlX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJt X2RhbWFnZV9oZWxwZXIuaAo+IGluZGV4IGFmMTg4Nzk5ODIwZi4uZTRmZTcwMzZjYWIyIDEwMDY0 NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9kYW1hZ2VfaGVscGVyLmgKPiArKysgYi9pbmNsdWRl L2RybS9kcm1fZGFtYWdlX2hlbHBlci5oCj4gQEAgLTY3LDYgKzY3LDEwIEBAIHN0cnVjdCBkcm1f YXRvbWljX2hlbHBlcl9kYW1hZ2VfaXRlciB7Cj4gIHZvaWQgZHJtX3BsYW5lX2VuYWJsZV9mYl9k YW1hZ2VfY2xpcHMoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpOwo+ICB2b2lkIGRybV9hdG9taWNf aGVscGVyX2NoZWNrX3BsYW5lX2RhbWFnZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUs Cj4gIAkJCQkJICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSk7Cj4gK2ludCBk cm1fYXRvbWljX2hlbHBlcl9kaXJ0eWZiKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICsJ CQkgICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwgdW5zaWduZWQgZmxhZ3MsCj4gKwkJ CSAgICAgIHVuc2lnbmVkIGNvbG9yLCBzdHJ1Y3QgZHJtX2NsaXBfcmVjdCAqY2xpcHMsCj4gKwkJ CSAgICAgIHVuc2lnbmVkIG51bV9jbGlwcyk7Cj4gIHZvaWQKPiAgZHJtX2F0b21pY19oZWxwZXJf ZGFtYWdlX2l0ZXJfaW5pdChzdHJ1Y3QgZHJtX2F0b21pY19oZWxwZXJfZGFtYWdlX2l0ZXIgKml0 ZXIsCj4gIAkJCQkgICBjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpvbGRfc3RhdGUsCj4g LS0gCj4gMi4xNy4xCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==