From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/cma-helper: Fix crash in fbdev error path Date: Mon, 1 Oct 2018 10:21:18 +0200 Message-ID: <20181001082118.GX11082@phenom.ffwll.local> References: <20180929171200.24391-1-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0DEFA6E0C1 for ; Mon, 1 Oct 2018 08:21:23 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id f4-v6so13364495edq.3 for ; Mon, 01 Oct 2018 01:21:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180929171200.24391-1-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: Stefan Wahren , Daniel Vetter , dri-devel@lists.freedesktop.org, ssuloev@orpaltech.com List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBTZXAgMjksIDIwMTggYXQgMDc6MTI6MDBQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IFNlcmdleSBTdWxvZXYgcmVwb3J0ZWQgYSBjcmFzaCBoYXBwZW5pbmcgaW4gZHJt X2NsaWVudF9kZXZfaG90cGx1ZygpCj4gd2hlbiBmYmRldiBoYWQgZmFpbGVkIHRvIHJlZ2lzdGVy Lgo+IAo+IFsgICAgOS4xMjQ1OThdIHZjNF9oZG1pIDNmOTAyMDAwLmhkbWk6IEFTb0M6IEZhaWxl ZCB0byBjcmVhdGUgY29tcG9uZW50IGRlYnVnZnMgZGlyZWN0b3J5Cj4gWyAgICA5LjE0NzY2N10g dmM0X2hkbWkgM2Y5MDIwMDAuaGRtaTogdmM0LWhkbWktaGlmaSA8LT4gM2Y5MDIwMDAuaGRtaSBt YXBwaW5nIG9rCj4gWyAgICA5LjE1NTE4NF0gdmM0X2hkbWkgM2Y5MDIwMDAuaGRtaTogQVNvQzog bm8gRE1JIHZlbmRvciBuYW1lIQo+IFsgICAgOS4xNjY1NDRdIHZjNC1kcm0gc29jOmdwdTogYm91 bmQgM2Y5MDIwMDAuaGRtaSAob3BzIHZjNF9oZG1pX29wcyBbdmM0XSkKPiBbICAgIDkuMTczODQw XSB2YzQtZHJtIHNvYzpncHU6IGJvdW5kIDNmODA2MDAwLnZlYyAob3BzIHZjNF92ZWNfb3BzIFt2 YzRdKQo+IFsgICAgOS4xODEwMjldIHZjNC1kcm0gc29jOmdwdTogYm91bmQgM2YwMDQwMDAudHhw IChvcHMgdmM0X3R4cF9vcHMgW3ZjNF0pCj4gWyAgICA5LjE4ODUxOV0gdmM0LWRybSBzb2M6Z3B1 OiBib3VuZCAzZjQwMDAwMC5odnMgKG9wcyB2YzRfaHZzX29wcyBbdmM0XSkKPiBbICAgIDkuMTk1 NjkwXSB2YzQtZHJtIHNvYzpncHU6IGJvdW5kIDNmMjA2MDAwLnBpeGVsdmFsdmUgKG9wcyB2YzRf Y3J0Y19vcHMgW3ZjNF0pCj4gWyAgICA5LjIwMzUyM10gdmM0LWRybSBzb2M6Z3B1OiBib3VuZCAz ZjIwNzAwMC5waXhlbHZhbHZlIChvcHMgdmM0X2NydGNfb3BzIFt2YzRdKQo+IFsgICAgOS4yMTUw MzJdIHZjNC1kcm0gc29jOmdwdTogYm91bmQgM2Y4MDcwMDAucGl4ZWx2YWx2ZSAob3BzIHZjNF9j cnRjX29wcyBbdmM0XSkKPiBbICAgIDkuMjc0Nzg1XSB2YzQtZHJtIHNvYzpncHU6IGJvdW5kIDNm YzAwMDAwLnYzZCAob3BzIHZjNF92M2Rfb3BzIFt2YzRdKQo+IFsgICAgOS4yOTAyNDZdIFtkcm1d IEluaXRpYWxpemVkIHZjNCAwLjAuMCAyMDE0MDYxNiBmb3Igc29jOmdwdSBvbiBtaW5vciAwCj4g WyAgICA5LjI5NzQ2NF0gW2RybV0gU3VwcG9ydHMgdmJsYW5rIHRpbWVzdGFtcCBjYWNoaW5nIFJl diAyICgyMS4xMC4yMDEzKS4KPiBbICAgIDkuMzA0NjAwXSBbZHJtXSBEcml2ZXIgc3VwcG9ydHMg cHJlY2lzZSB2YmxhbmsgdGltZXN0YW1wIHF1ZXJ5Lgo+IFsgICAgOS4zODI4NTZdIHZjNC1kcm0g c29jOmdwdTogW2RybTpkcm1fZmJfaGVscGVyX2ZiZGV2X3NldHVwIFtkcm1fa21zX2hlbHBlcl1d ICpFUlJPUiogRmFpbGVkIHRvIHNldCBmYmRldiBjb25maWd1cmF0aW9uCj4gWyAgIDEwLjQwNDkz N10gVW5hYmxlIHRvIGhhbmRsZSBrZXJuZWwgcGFnaW5nIHJlcXVlc3QgYXQgdmlydHVhbCBhZGRy ZXNzIDAwMzMwYTY1NjM2OTc2OGEKPiBbICAgMTAuNDQxNjIwXSBbMDAzMzBhNjU2MzY5NzY4YV0g YWRkcmVzcyBiZXR3ZWVuIHVzZXIgYW5kIGtlcm5lbCBhZGRyZXNzIHJhbmdlcwo+IFsgICAxMC40 NDkwODddIEludGVybmFsIGVycm9yOiBPb3BzOiA5NjAwMDAwNCBbIzFdIFBSRUVNUFQgU01QCj4g WyAgIDEwLjQ1NDc2Ml0gTW9kdWxlcyBsaW5rZWQgaW46IGJyY21mbWFjIHZjNCBkcm1fa21zX2hl bHBlciBjZmc4MDIxMSBkcm0gcmZraWxsIHNtc2M5NXh4IGJyY211dGlsIHVzYm5ldCBkcm1fcGFu ZWxfb3JpZW50YXRpb25fcXVpcmtzIHJhc3BiZXJyeXBpX2h3bW9uIGJjbTI4MzVfZG1hIGNyYzMy X2NlIHB3bV9iY20yODM1IGJjbTI4MzVfcm5nIHZpcnRfZG1hIHJuZ19jb3JlIGkyY19iY20yODM1 IGlwX3RhYmxlcyB4X3RhYmxlcyBpcHY2Cj4gWyAgIDEwLjQ3NzI5Nl0gQ1BVOiAyIFBJRDogNDUg Q29tbToga3dvcmtlci8yOjEgTm90IHRhaW50ZWQgNC4xOS4wLXJjNSAjMwo+IFsgICAxMC40ODM5 MzRdIEhhcmR3YXJlIG5hbWU6IFJhc3BiZXJyeSBQaSAzIE1vZGVsIEIgUmV2IDEuMiAoRFQpCj4g WyAgIDEwLjQ4OTk2Nl0gV29ya3F1ZXVlOiBldmVudHMgb3V0cHV0X3BvbGxfZXhlY3V0ZSBbZHJt X2ttc19oZWxwZXJdCj4gWyAgIDEwLjU5NjUxNV0gUHJvY2VzcyBrd29ya2VyLzI6MSAocGlkOiA0 NSwgc3RhY2sgbGltaXQgPSAweDAwMDAwMDAwN2U4OTI0ZGMpCj4gWyAgIDEwLjYwMzU5MF0gQ2Fs bCB0cmFjZToKPiBbICAgMTAuNjA2MjU5XSAgZHJtX2NsaWVudF9kZXZfaG90cGx1ZysweDVjLzB4 YjAgW2RybV0KPiBbICAgMTAuNjExMzAzXSAgZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudCsw eDMwLzB4NDAgW2RybV9rbXNfaGVscGVyXQo+IFsgICAxMC42MTc4NDldICBvdXRwdXRfcG9sbF9l eGVjdXRlKzB4YzQvMHgxZTAgW2RybV9rbXNfaGVscGVyXQo+IFsgICAxMC42MjM2MTZdICBwcm9j ZXNzX29uZV93b3JrKzB4MWM4LzB4MzE4Cj4gWyAgIDEwLjYyNzY5NV0gIHdvcmtlcl90aHJlYWQr MHg0OC8weDQyOAo+IFsgICAxMC42MzE0MjBdICBrdGhyZWFkKzB4ZjgvMHgxMjgKPiBbICAgMTAu NjM0NjE1XSAgcmV0X2Zyb21fZm9yaysweDEwLzB4MTgKPiBbICAgMTAuNjM4MjU1XSBDb2RlOiA1 NDAwMDIyMCBmOTQwMTI2MSBhYTEzMDNlMCBiNDAwMDE0MSAoZjk0MDBjMjEpCj4gWyAgIDEwLjY0 NDQ1Nl0gLS0tWyBlbmQgdHJhY2UgYzc1YjRhNGIwZTE0MTkwOCBdLS0tCj4gCj4gVGhlIHJlYXNv biBmb3IgdGhpcyBpcyB0aGF0IGRybV9mYmRldl9jbWFfaW5pdCgpIHJlbW92ZXMgdGhlIGRybV9j bGllbnQKPiB3aGVuIGZiZGV2IHJlZ2lzdHJhdGlvbiBmYWlscywgYnV0IGl0IGRvZXNuJ3QgcmVt b3ZlIHRoZSBjbGllbnQgZnJvbSB0aGUKPiBkcm1fZGV2aWNlIGNsaWVudCBsaXN0LiBTbyB0aGUg Y2xpZW50IGxpc3Qgbm93IGhhcyBhIHBvaW50ZXIgdGhhdCBwb2ludHMKPiBpbnRvIHRoZSB1bmtu b3duIGFuZCB3ZSBoYXZlIGEgJ3VzZSBhZnRlciBmcmVlJyBzaXR1YXRpb24uCj4gCj4gSXQgd2Fz IGRlY2lkZWQgZHVyaW5nIHRoZSBkcm1fY2xpZW50IEFQSSBkaXNjdXNzaW9ucyB0aGF0IGEgY2xp ZW50IHNob3VsZAo+IG5vdCBiZSBhbGxvd2VkIHRvIHJlbW92ZSBpdHNlbGYuIFRoaXMgd2FzIGJh c2VkIG9uIHRoZSBleHBlcmllbmNlIHdpdGgKPiB0aGUgZmJkZXYvZmJjb24gbG9ja2luZyBob3Jy b3Igc2hvdy4KPiAKPiBTbyB0aGUgc29sdXRpb24gaXMgdG8ganVzdCBsZWF2ZSB0aGUgZHJtX2Ns aWVudCBoYW5naW5nIGFyb3VuZCBkb2luZwo+IG5vdGhpbmcgKGl0IGRvZXNuJ3QgaGF2ZSBhbnkg Y2FsbGJhY2tzKSwgYW5kIGxldCBpdCBiZSByZW1vdmVkIHdoZW4KPiBkcm1fZGV2X3VucmVnaXN0 ZXIoKSBpcyBjYWxsZWQuCgpTbGlnaHRseSBjbGVhbmVyIHNvbHV0aW9uOiBTcGxpdCBkcm1fY2xp ZW50X25ldyBpbnRvIGRybV9jbGllbnRfYWxsb2MoKQphbmQgZHJtX2NsaWVudF9hZGQoKS4gQ2Fs bCB0aGUgbGF0ZXIgb25seSB3aGVuIGluaXRpYWxpemF0aW9uIHN1Y2NlZWRzLAphbmQgb25seSBf YWRkKCkgd2lsbCBhZGQgaXQgdG8gdGhlIGRldmljZSBsaXN0LgoKQnV0IHRoaXMgaGVyZSBnZXRz IHRoZSBqb2IgZG9uZSBmb3IgLWZpeGVzLCBzbzoKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKQnV0IGZlZWwgZnJlZSB0byByZXNwaW4gd2l0aCB0 aGUgX2FsbG9jKCkvX2FkZCgpIGlkZWEuCgo+IAo+IEZpeGVzOiA4OTRhNjc3ZjRiM2UgKCJkcm0v Y21hLWhlbHBlcjogVXNlIHRoZSBnZW5lcmljIGZiZGV2IGVtdWxhdGlvbiIpCj4gUmVwb3J0ZWQt Ynk6IFNlcmdleSBTdWxvZXYgPHNzdWxvZXZAb3JwYWx0ZWNoLmNvbT4KPiBDYzogU3RlZmFuIFdh aHJlbiA8c3RlZmFuLndhaHJlbkBpMnNlLmNvbT4KPiBDYzogRXJpYyBBbmhvbHQgPGVyaWNAYW5o b2x0Lm5ldD4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBT aWduZWQtb2ZmLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiAtLS0K PiAKPiBUaGlzIGJ1ZyBpcyBpbiA0LjE5IHNvIGl0IHNob3VsZCBnbyBpbnRvIGRybS1taXNjLWZp eGVzIHJpZ2h0Pwo+IChJIGhhdmUgbmV2ZXIgYXBwbGllZCBhIGZpeCBiZWZvcmUpCgpZdXAuCgpJ ZiB5b3UgZGVjaWRlIHRvIHB1c2ggdGhpcywgYW5kIGRvIHRoZSBfYWxsb2MvYWRkKCkgcmVmYWN0 b3IgYWZ0ZXJ3YXJkcwp5b3UgbmVlZCB0byByZXF1ZXN0IGEgYmFja21lcmdlIGZyb20gZHJtLW1p c2MgbWFpbnRhaW5lcnMgKHNpbmNlIHRoZQpyZWZhY3RvciBzaG91bGQgZ28gaW50byBkcm0tbWlz YyBvZmMpLgoKQ2hlZXJzLCBEYW5pZWwKCj4gCj4gTm9yYWxmLgo+IAo+ICBkcml2ZXJzL2dwdS9k cm0vZHJtX2ZiX2NtYV9oZWxwZXIuYyB8IDE5ICsrKysrKysrKy0tLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV9mYl9jbWFfaGVscGVyLmMKPiBpbmRleCA0N2UwZTJmNjY0MmQuLmQ4MmJiNDc3NmUzYyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jCj4gQEAgLTE2OCwyMiArMTY4LDIx IEBAIHN0cnVjdCBkcm1fZmJkZXZfY21hICpkcm1fZmJkZXZfY21hX2luaXQoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwKPiAgCWZiX2hlbHBlciA9ICZmYmRldl9jbWEtPmZiX2hlbHBlcjsKPiAgCj4g IAlyZXQgPSBkcm1fY2xpZW50X25ldyhkZXYsICZmYl9oZWxwZXItPmNsaWVudCwgImZiZGV2Iiwg TlVMTCk7Cj4gLQlpZiAocmV0KQo+IC0JCWdvdG8gZXJyX2ZyZWU7Cj4gKwlpZiAocmV0KSB7Cj4g KwkJa2ZyZWUoZmJkZXZfY21hKTsKPiArCQlyZXR1cm4gRVJSX1BUUihyZXQpOwo+ICsJfQo+ICAK PiAgCXJldCA9IGRybV9mYl9oZWxwZXJfZmJkZXZfc2V0dXAoZGV2LCBmYl9oZWxwZXIsICZkcm1f ZmJfY21hX2hlbHBlcl9mdW5jcywKPiAgCQkJCQlwcmVmZXJyZWRfYnBwLCBtYXhfY29ubl9jb3Vu dCk7Cj4gIAlpZiAocmV0KQo+IC0JCWdvdG8gZXJyX2NsaWVudF9wdXQ7Cj4gKwkJLyoKPiArCQkg KiBBIGRybV9jbGllbnQgaXMgbm90IGFsbG93ZWQgdG8gcmVtb3ZlIGl0c2VsZiwgc28gaXQgaGFz IHRvCj4gKwkJICogc3RheSBhcm91bmQgdW50aWwgZHJtX2Rldl91bnJlZ2lzdGVyKCkuCj4gKwkJ ICovCj4gKwkJcmV0dXJuIEVSUl9QVFIocmV0KTsKPiAgCj4gIAlyZXR1cm4gZmJkZXZfY21hOwo+ IC0KPiAtZXJyX2NsaWVudF9wdXQ6Cj4gLQlkcm1fY2xpZW50X3JlbGVhc2UoJmZiX2hlbHBlci0+ Y2xpZW50KTsKPiAtZXJyX2ZyZWU6Cj4gLQlrZnJlZShmYmRldl9jbWEpOwo+IC0KPiAtCXJldHVy biBFUlJfUFRSKHJldCk7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTF9HUEwoZHJtX2ZiZGV2X2NtYV9p bml0KTsKPiAgCj4gLS0gCj4gMi4xNS4xCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==