From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: fb-helper: Validate requested pixel format against bpp Date: Wed, 3 Oct 2018 18:51:23 +0300 Message-ID: <20181003155123.GJ9144@intel.com> References: <20181003110457.9318-1-Eugeniy.Paltsev@synopsys.com> <20181003123047.GK9144@intel.com> <1538577004.11140.5.camel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id E75526E156 for ; Wed, 3 Oct 2018 15:51:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Dave Airlie , Sean Paul , Alexey Brodkin , Linux Kernel Mailing List , dri-devel , stable , linux-snps-arc@lists.infradead.org, Eugeniy Paltsev List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBPY3QgMDMsIDIwMTggYXQgMDU6Mjk6MzRQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIE9jdCAzLCAyMDE4IGF0IDQ6MzAgUE0gRXVnZW5peSBQYWx0c2V2Cj4g PGV1Z2VuaXkucGFsdHNldkBzeW5vcHN5cy5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIFdlZCwgMjAx OC0xMC0wMyBhdCAxNTozMCArMDMwMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ID4gPiBPbiBX ZWQsIE9jdCAwMywgMjAxOCBhdCAwMTozNjowMFBNICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3Rl Ogo+ID4gPiA+IE9uIFdlZCwgT2N0IDMsIDIwMTggYXQgMTowNSBQTSBFdWdlbml5IFBhbHRzZXYK PiA+ID4gPiA8RXVnZW5peS5QYWx0c2V2QHN5bm9wc3lzLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPgo+ ID4gPiA+ID4gVmFsaWRhdGUgcmVxdWVzdGVkIHBpeGVsIGZvcm1hdCBhZ2FpbnN0IGJpdHNfcGVy X3BpeGVsIHRvIHJlamVjdAo+ID4gPiA+ID4gaW52YWxpZCBmb3JtYXRzIHdpdGggc3ViY29tcG9u ZW50cyBsZW5ndGggc3VtIGlzIGdyZWF0ZXIgdGhhbiByZXF1ZXN0ZWQKPiA+ID4gPiA+IGJpdHNf cGVyX3BpeGVsLgo+ID4gPiA+ID4KPiA+ID4gPiA+IHdlc3RvbiA1LjAuMCB3aXRoIGZiZGV2IGJh Y2tlbmQgdHJpZXMgdG8gc2V0IHVwIGFuIEFSR0IgeDhyOGc4YjggcGl4ZWwKPiA+ID4gPiA+IGZv cm1hdCB3aXRob3V0IGJpdHNfcGVyX3BpeGVsIHVwZGF0aW5nLiBTbyBpdCBjYW4gcmVxdWVzdAo+ ID4gPiA+ID4geDhyOGc4Yjggd2l0aCAxNiBicHAgd2hpY2ggaXMgb2J2aW91c2x5IGluY29ycmVj dCBhbmQgc2hvdWxkIGJlCj4gPiA+ID4gPiByZWplY3RlZC4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBD Yzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogRXVnZW5p eSBQYWx0c2V2IDxFdWdlbml5LlBhbHRzZXZAc3lub3BzeXMuY29tPgo+ID4gPiA+Cj4gPiA+ID4g ZHJtIGZiZGV2IGVtdWxhdGlvbiBkb2Vzbid0IHN1cHBvcnQgY2hhbmdpbmcgdGhlIHBpeGVsIGZv cm1hdCBhdCBhbGwuCj4gPiA+ID4gSSB0aGluayB3ZSBzaG91bGQgcmVqZWN0IGFsbCBzdWNoIHJl cXVlc3QsIG5vdCBqdXN0IHRoZSBpbnZhbGlkIG9uZXMuCj4gPiA+ID4gQ2FuIHlvdSBwbHMgcmVz cGluPwo+ID4gPgo+ID4gPiBGWUkgSSBvbmNlIHBvc3RlZCBhIHBhdGNoIHRvIHRpZ2h0ZW4gdXAg dGhlIGZiLWhlbHBlciBwaXhlbCBmb3JtYXQKPiA+ID4gc3R1ZmY6Cj4gPiA+IGh0dHBzOi8vcGF0 Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC8yMDMxODkvCj4gPgo+ID4KPiA+IEhpIERhbmll bCwKPiA+Cj4gPiB3aWxsIHlvdSB0YWtlIFZpbGxlJ3MgcGF0Y2ggb3Igc2hvdWxkIEkgY3JlYXRl IHRoZSBuZXcgb25lIHdoaWNoIGlzIG9ubHkgcmVsYXRlZAo+ID4gdG8gbmV3IHBpeGVsIGZvcm1h dCB2YWxpZGF0aW9uIGluIGRybV9mYl9oZWxwZXJfY2hlY2tfdmFyKCkgPwo+IAo+IFZpbGxlJ3Mg cGF0Y2ggaXNuJ3QgdGhlIGJ1Z2ZpeCB3ZSdyZSBsb29raW5nIGZvciwgYnV0IGEgZHJhZnQgdmVy c2lvbgo+IG9mIHdoYXQgYWRkaW5nIHByb3BlciBmb3JtYXQgc3VwcG9ydCBpbiBkcm0ncyBmYmRl diBlbXVsYXRpb24gY291bGQKPiBsb29rIGxpa2UuIFdpdGggbG90cyZsb3RzIG9mIG9wZW4gcXVl c3Rpb25zLgoKQWN0dWFsbHkgaXQgZG9lcyBwcmV0dHkgbXVjaCB3aGF0IHlvdSBzZWVtIHRvIGJl IGFza2luZyBmb3IuCkllLiByZWplY3QgYW55IGF0dGVtcHQgdG8gY2hhbmdlIHRoZSBwaXhlbCBm b3JtYXQuIE5vdCByZWFsbHkKc3VyZSBob3cgdG8gZG8gaXQgbXVjaCBtb3JlIG1pbmltYWxseS4K CkhtbS4gT2ggdGhlcmUgaXMgYSBtb3JlIG1pbmltYWwgd2F5IGFjdHVhbGx5LiBJIG1pc3Rha2Vu bHkgcmVtZW1iZXJlZAp0aGF0IGZiZGV2IGNsb2JiZXJzIGluZm8tPnZhciBhbHJlYWR5IGJlZm9y ZSBjaGVja192YXIoKSwgYnV0IGFjdHVhbGx5Cml0IG9ubHkgZG9lcyB0aGF0IGJlZm9yZSBzZXRf cGFyKCkuIFNvIEkgZ3Vlc3MgYWxsIHdlIHJlYWxseSBuZWVkIGlzCnRvIGNvbXBhcmUgdGhlIGZi X2JpdGZpZWxkcy9iaXRzX3Blcl9waXhlbC9ldGMuIGJldHdlZW4gaW5mby0+dmFyCmFuZCB0aGUg cGFzc2VkIGluIHZhci4KCj4gTm90IGFueXdoZXJlIG5lYXIgcmVhZHkKPiBmb3IgbWVyZ2luZywg YW5kIGRlZmluaXRlbHkgbm90IHN0YWJsZSBiYWNrcG9ydCBtYXRlcmlhbC4KPiAKPiBTbyB5ZXMs IHN0aWxsIHdhbnQgdGhlIG1pbmltYWwgYnVnZml4Lgo+IC1EYW5pZWwKPiAKPiA+Cj4gPgo+ID4g PiA+IFRoYW5rcywgRGFuaWVsCj4gPiA+ID4KPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gIGRyaXZl cnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgfCA3ICsrKysrKysKPiA+ID4gPiA+ICAxIGZpbGUg Y2hhbmdlZCwgNyBpbnNlcnRpb25zKCspCj4gPiA+ID4gPgo+ID4gPiA+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Zi X2hlbHBlci5jCj4gPiA+ID4gPiBpbmRleCAxNmVjOTNiNzVkYmYuLjRmMzlkYTA3ZjA1MyAxMDA2 NDQKPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiA+ID4g PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiA+ID4gPiA+IEBAIC0x NjEwLDYgKzE2MTAsMTMgQEAgaW50IGRybV9mYl9oZWxwZXJfY2hlY2tfdmFyKHN0cnVjdCBmYl92 YXJfc2NyZWVuaW5mbyAqdmFyLAo+ID4gPiA+ID4gICAgICAgICAgICAgICAgIHJldHVybiAtRUlO VkFMOwo+ID4gPiA+ID4gICAgICAgICB9Cj4gPiA+ID4gPgo+ID4gPiA+ID4gKyAgICAgICBpZiAo KHZhci0+Z3JlZW4ubGVuZ3RoICsgdmFyLT5ibHVlLmxlbmd0aCArIHZhci0+cmVkLmxlbmd0aCAr Cj4gPiA+ID4gPiArICAgICAgICAgICB2YXItPnRyYW5zcC5sZW5ndGgpID4gdmFyLT5iaXRzX3Bl cl9waXhlbCkgewo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIERSTV9ERUJVRygiZmIgcmVxdWVz dGVkIHBpeGVsIGZvcm1hdCBjYW4ndCBmaXQgaW4gJWQgYnBwXG4iLAo+ID4gPiA+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICB2YXItPmJpdHNfcGVyX3BpeGVsKTsKPiA+ID4gPiA+ICsgICAg ICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ID4gPiA+ICsgICAgICAgfQo+ID4gPiA+ID4g Kwo+ID4gPiA+ID4gICAgICAgICBzd2l0Y2ggKHZhci0+Yml0c19wZXJfcGl4ZWwpIHsKPiA+ID4g PiA+ICAgICAgICAgY2FzZSAxNjoKPiA+ID4gPiA+ICAgICAgICAgICAgICAgICBkZXB0aCA9ICh2 YXItPmdyZWVuLmxlbmd0aCA9PSA2KSA/IDE2IDogMTU7Cj4gPiA+ID4gPiAtLQo+ID4gPiA+ID4g Mi4xNC40Cj4gPiA+ID4gPgo+ID4gPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiA+ID4gPiA+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiA+ID4g PiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gPiA+IGh0dHBzOi8vdXJs ZGVmZW5zZS5wcm9vZnBvaW50LmNvbS92Mi91cmw/dT1odHRwcy0zQV9fbGlzdHMuZnJlZWRlc2t0 b3Aub3JnX21haWxtYW5fbGlzdGluZm9fZHJpLTJEZGV2ZWwmZD1Ed0lEQXcmYz1EUEw2X1hfNkpr WEZ4N0FYV3FCMHRnJnI9WmxKTgo+ID4gPiA+ID4gMU1yaVBVVGtCS0NyUFN4NjdHbWFwbEVVR2NB RWs5eVB0Q0xkVVhJJm09ZjEyWnlFRVNJZWF2dHFDVUt1dGlaOUY2eHRSRkMyVVV2ZHFuTTR5d0J4 OCZzPUNQUzh0YU1pWWJJZ1hvLWZ4aHFFck9KWHZPNlBNVHptci1CTm5HSklveTAmZT0KPiA+ID4g Pgo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiAtLQo+ID4gPiA+IERhbmllbCBWZXR0ZXIKPiA+ID4g PiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiA+ID4gPiArNDEgKDApIDc5 IDM2NSA1NyA0OCAtIGh0dHBzOi8vdXJsZGVmZW5zZS5wcm9vZnBvaW50LmNvbS92Mi91cmw/dT1o dHRwLTNBX19ibG9nLmZmd2xsLmNoJmQ9RHdJREF3JmM9RFBMNl9YXzZKa1hGeDdBWFdxQjB0ZyZy PVpsSk4xTXJpUFVUa0JLQ3JQU3g2Nwo+ID4gPiA+IEdtYXBsRVVHY0FFazl5UHRDTGRVWEkmbT1m MTJaeUVFU0llYXZ0cUNVS3V0aVo5RjZ4dFJGQzJVVXZkcW5NNHl3Qng4JnM9VnQ4T1g5czlsalNL NkdEZ2Jud3NGLVlkMzVmYkJVZmU4U0JWMmpQblZhUSZlPQo+ID4gPiA+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+ID4gZHJpLWRldmVsIG1haWxp bmcgbGlzdAo+ID4gPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gPiBo dHRwczovL3VybGRlZmVuc2UucHJvb2Zwb2ludC5jb20vdjIvdXJsP3U9aHR0cHMtM0FfX2xpc3Rz LmZyZWVkZXNrdG9wLm9yZ19tYWlsbWFuX2xpc3RpbmZvX2RyaS0yRGRldmVsJmQ9RHdJREF3JmM9 RFBMNl9YXzZKa1hGeDdBWFdxQjB0ZyZyPVpsSk4xTQo+ID4gPiA+IHJpUFVUa0JLQ3JQU3g2N0dt YXBsRVVHY0FFazl5UHRDTGRVWEkmbT1mMTJaeUVFU0llYXZ0cUNVS3V0aVo5RjZ4dFJGQzJVVXZk cW5NNHl3Qng4JnM9Q1BTOHRhTWlZYklnWG8tZnhocUVyT0pYdk82UE1Uem1yLUJObkdKSW95MCZl PQo+ID4gPgo+ID4gPgo+ID4gLS0KPiA+ICBFdWdlbml5IFBhbHRzZXYKPiAKPiAKPiAKPiAtLSAK PiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4g KzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaAoKLS0gClZpbGxlIFN5 cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK