From: "Guido Günther" <agx@sigxcpu.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Emil Velikov <emil.l.velikov@gmail.com>,
The etnaviv authors <etnaviv@lists.freedesktop.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH libdrm] tests: Test mapping different caching types on etnaviv
Date: Thu, 4 Oct 2018 16:53:48 +0200 [thread overview]
Message-ID: <20181004145348.GA2826@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <1538660591.3515.14.camel@pengutronix.de>
Hi,
On Thu, Oct 04, 2018 at 03:43:11PM +0200, Lucas Stach wrote:
> Am Donnerstag, den 04.10.2018, 14:20 +0100 schrieb Emil Velikov:
> > [adding etnaviv@ for bigger exposure]
> >
> > Hi Guido,
> >
> > > On Fri, 14 Sep 2018 at 13:06, Guido Günther <agx@sigxcpu.org> wrote:
> > >
> > > This makes it simple to test if all cache types are mappable.
> > >
> > > > > Signed-off-by: Guido Günther <guido.gunther@puri.sm>
> > > ---
> > > Prompted by
> > >
> > > https://lists.freedesktop.org/archives/etnaviv/2018-September/001946.html
> > >
> > > tests/etnaviv/etnaviv_bo_cache_test.c | 26 ++++++++++++++++++++++++++
> > > 1 file changed, 26 insertions(+)
> > >
> >
> > Patch looks spot on, sadly my etnaviv knowledge is a bit limited.
> >
> > Ideally one of the etna devs will double-check it, but from my POV
> > > Acked-by: Emil Velikov <emil.velikov@collabora.com>
>
> Nope, this test has nothing to do with the BO cache, which is a
> userspace buffer cache layer, while the caching modes map to how CPU
> accesses to the buffer mmap space are treated by the hardware.
>
> So if we want to keep this test, it needs to be split into a separate
> test.
After sending this I also realized that it would might be better suited
for igt-gpu-tools. Would it fit in there? If so'd rework it and add it
there.
Cheers,
-- Guido
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-10-04 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 12:05 [PATCH libdrm] tests: Test mapping different caching types on etnaviv Guido Günther
2018-10-04 13:20 ` Emil Velikov
2018-10-04 13:43 ` Lucas Stach
2018-10-04 14:53 ` Guido Günther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004145348.GA2826@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox