From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH v2 2/2] drm/sun4i: tcon: prevent tcon->panel dereference
 if null
Date: Thu, 4 Oct 2018 21:56:05 +0200
Message-ID: <20181004195605.txvbkshvxklyzxyb@flea>
References: <9a545739-eed5-7af1-3b75-108bdd3427a2@micronovasrl.com>
 <20181003142458.33120-1-giulio.benetti@micronovasrl.com>
 <20181003142458.33120-2-giulio.benetti@micronovasrl.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0785336093=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54])
 by gabe.freedesktop.org (Postfix) with ESMTP id 0C0576E63A
 for <dri-devel@lists.freedesktop.org>; Thu,  4 Oct 2018 19:56:07 +0000 (UTC)
In-Reply-To: <20181003142458.33120-2-giulio.benetti@micronovasrl.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Giulio Benetti <giulio.benetti@micronovasrl.com>
Cc: David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org


--===============0785336093==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="p6k4kmrvnmdrrg4l"
Content-Disposition: inline


--p6k4kmrvnmdrrg4l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 03, 2018 at 04:24:58PM +0200, Giulio Benetti wrote:
> If using tcon with VGA,

We don't have support for VGA at the moment. Or are you talking about
using a VGA bridge?

> tcon->panel will be null(0), this will cause segmentation fault when
> trying to dereference tcon->panel->connector.

It's not a segmentation fault, but a null pointer dereference. And
that case will also happen with bridges.

Maxime

--=20
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--p6k4kmrvnmdrrg4l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlu2cFQACgkQ0rTAlCFN
r3TSxw/8Dziy1NiInMstE2LiZhh8Lwqi77TDLFHYbY0jmc86gPC3nQ+HHAldfF3d
HYWS7ubeG8FkNnyg4327nGC2pR3iSmWXhNWQlqPx9rggDANSAT/Nv7fo0ZbValL4
iyacp43k4hrWhSpZuPsAvFq349Qh06HsGsQkU/3tS/uTa2hntW1170eA3s+re+BW
I2R+DDzRkzkwgNjUTHFW/vG4iG6hlzZbmsi9FgIOg3jNKXNAniveLGOQNICfra62
DdHh3RxGhRjkuqFt8snOM/Y4MkC0BnadnEwyCRBVg9KAfQe0BQv7p3EyGr8n6QW6
ExOjK3HxsWCDYOcnrqR9AvbuYIZGzMOSUkUBKInar2yY3UFXmd/QGG6dT6hjJS7I
8qMExOjZkRN5/oHpMYb93gF3MfW3Z63nfaHCcRPitNnlvANBo36nZqvXHLiVxlZf
dNJbw0p1v+mhPNPiIMmnBQiL17xwUqSC/R69U8XXY3FbPBAGGqu6VZORtv2isbKC
AJA3mAZGJfIiNr8YJytHU4GTazN/9cUQhLBz+XE8d3W63B8oZSbmPwUc26NK5W7h
eCezPgMWjxUYX/orSkiocW9NXRUcIDhBSOnq8wlzb6cIAMX00Nz4bFo/2+BHAgn4
Ujpmxecr5cS/Gyc7f+e3zXJ/GkzXrFgRrTudPq0xS6VqZfoO/tk=
=JJRK
-----END PGP SIGNATURE-----

--p6k4kmrvnmdrrg4l--

--===============0785336093==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0785336093==--