From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 4/6] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0 Date: Fri, 5 Oct 2018 16:53:33 +0200 Message-ID: <20181005145333.GG31561@phenom.ffwll.local> References: <20181005092606.21100-1-alexandru-cosmin.gheorghe@arm.com> <20181005092606.21100-5-alexandru-cosmin.gheorghe@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F0DF6E841 for ; Fri, 5 Oct 2018 14:53:38 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id z21-v6so7462335edb.11 for ; Fri, 05 Oct 2018 07:53:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181005092606.21100-5-alexandru-cosmin.gheorghe@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru-Cosmin Gheorghe Cc: Charles Xu , nd , Matt Szczesiak , "airlied@linux.ie" , Liviu Dudau , "dri-devel@lists.freedesktop.org" , David Garbett , "seanpaul@chromium.org" , Lisa Wu , "daniel.vetter@ffwll.ch" , "malidp@foss.arm.com" , Ayan Halder , "james qian wang (Arm Technology China)" List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBPY3QgMDUsIDIwMTggYXQgMDk6MjY6NTdBTSArMDAwMCwgQWxleGFuZHJ1LUNvc21p biBHaGVvcmdoZSB3cm90ZToKPiBGb3IgZm9ybWF0cyB0aGF0IGFyZSBzdXBwb3J0ZWQgb25seSB3 aXRoIG5vbi1saW5lYXIgbW9kaWZpZXJzIGl0Cj4gZG9lc24ndCBtYWtlIHRvIG11Y2ggc2Vuc2Ug dG8gZGVmaW5lIGNwcCBvciBjaGFyX3Blcl9ibG9jaywgc28gdGhhdAo+IHdpbGwgYmUgc2V0IHRv IDAuCj4gCj4gVGhpcyBwYXRjaCBhZGRzIGEgcmVzdHJpY3Rpb24gdG8gZm9yY2UgaGF2aW5nIGEg bW9kaWZpZXIgYXR0YWNoZWQgd2hlbgo+IGNwcC9jaGFyX3Blcl9ibG9jayBpcyAwLCBhbmQgdG8g YnlwYXNzIGNoZWNraW5nIHRoZSBwaXRjaCByZXN0cmljdGlvbi4KPiAKPiBUaGlzIGhhZCBiZWVu IGRpc2N1c3NlZCBoZXJlLgo+IFsxXSBodHRwczovL3Blb3BsZS5mcmVlZGVza3RvcC5vcmcvfmNi cmlsbC9kcmktbG9nLz9jaGFubmVsPWRyaS1kZXZlbCZoaWdobGlnaHRfbmFtZXM9JmRhdGU9MjAx OC0wOS0xMyZzaG93X2h0bWw9dHJ1ZQo+IAo+IFNpZ25lZC1vZmYtYnk6IEFsZXhhbmRydSBHaGVv cmdoZSA8YWxleGFuZHJ1LWNvc21pbi5naGVvcmdoZUBhcm0uY29tPgo+IFJldmlld2VkLWJ5OiBM aXZpdSBEdWRhdSA8bGl2aXUuZHVkYXVAYXJtLmNvbT4KCkNhbiB3ZSByZXF1aXJlIHRoYXQgdGhl IGRyaXZlciBzdXBwbGllcyBhIG1vcmUgYWNjdXJhdGUgZHJtX2Zvcm1hdF9pbmZvCnRocm91Z2gg Z2V0X2Zvcm1hdF9pbnRvIGluIHRoZXNlIGNhc2VzPyBJJ20gaG9waW5nIHRoYXQgd29ya3MsIGFu ZCB0aGUKYWZiYyBzdHVmZiBpc24ndCBlbnRpcmVseSByYW5kb20gYWxpZ25tZW50IDotKQoKVGhl biB3ZSB3b3VsZG4ndCBuZWVkIHRoZXNlIGVzY2FwZSBoYXRjaGVzIGhlcmUgSSB0aGluay4KLURh bmllbAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jIHwgNiArKysr Ky0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiBpbmRleCA0ZTE0MDEzNzg4Y2QuLjY2ZWMxMjZi N2ZhZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiBAQCAtMjAwLDYgKzIwMCwx MCBAQCBzdGF0aWMgaW50IGZyYW1lYnVmZmVyX2NoZWNrKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs Cj4gIAkJCQkJZHJtX2Zvcm1hdF9pbmZvX2Jsb2NrX3dpZHRoKGluZm8sIGkpICoKPiAgCQkJCQlk cm1fZm9ybWF0X2luZm9fYmxvY2tfaGVpZ2h0KGluZm8sIGkpKTsKPiAgCj4gKwkJaWYgKCFibG9j a19zaXplICYmIChyLT5tb2RpZmllcltpXSA9PSBEUk1fRk9STUFUX01PRF9MSU5FQVIpKSB7Cj4g KwkJCURSTV9ERUJVR19LTVMoIkZvcm1hdCByZXF1aXJlcyBub24tbGluZWFyIG1vZGlmaWVyIGZv ciBwbGFuZSAlZFxuIiwgaSk7Cj4gKwkJCXJldHVybiAtRUlOVkFMOwo+ICsJCX0KPiAgCQlpZiAo IXItPmhhbmRsZXNbaV0pIHsKPiAgCQkJRFJNX0RFQlVHX0tNUygibm8gYnVmZmVyIG9iamVjdCBo YW5kbGUgZm9yIHBsYW5lICVkXG4iLCBpKTsKPiAgCQkJcmV0dXJuIC1FSU5WQUw7Cj4gQEAgLTIx MSw3ICsyMTUsNyBAQCBzdGF0aWMgaW50IGZyYW1lYnVmZmVyX2NoZWNrKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsCj4gIAkJaWYgKCh1aW50NjRfdCkgaGVpZ2h0ICogci0+cGl0Y2hlc1tpXSArIHIt Pm9mZnNldHNbaV0gPiBVSU5UX01BWCkKPiAgCQkJcmV0dXJuIC1FUkFOR0U7Cj4gIAo+IC0JCWlm IChyLT5waXRjaGVzW2ldIDwgbWluX3BpdGNoKSB7Cj4gKwkJaWYgKGJsb2NrX3NpemUgJiYgci0+ cGl0Y2hlc1tpXSA8IG1pbl9waXRjaCkgewo+ICAJCQlEUk1fREVCVUdfS01TKCJiYWQgcGl0Y2gg JXUgZm9yIHBsYW5lICVkXG4iLCByLT5waXRjaGVzW2ldLCBpKTsKPiAgCQkJcmV0dXJuIC1FSU5W QUw7Cj4gIAkJfQo+IC0tIAo+IDIuMTguMAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUg RW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=