From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/2] drm: Add CRTC background color property
Date: Thu, 11 Oct 2018 14:30:29 +0300
Message-ID: <20181011113029.GW9144@intel.com>
References: <20181010235051.16693-1-matthew.d.roper@intel.com>
 <20181010235051.16693-2-matthew.d.roper@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20181010235051.16693-2-matthew.d.roper@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: wei.c.li@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, harish.krupo.kps@intel.com
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCBPY3QgMTAsIDIwMTggYXQgMDQ6NTA6NTBQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90
ZToKPiBTb21lIGRpc3BsYXkgY29udHJvbGxlcnMgY2FuIGJlIHByb2dyYW1tZWQgdG8gcHJlc2Vu
dCBub24tYmxhY2sgY29sb3JzCj4gZm9yIHBpeGVscyBub3QgY292ZXJlZCBieSBhbnkgcGxhbmUg
KG9yIHBpeGVscyBjb3ZlcmVkIGJ5IHRoZQo+IHRyYW5zcGFyZW50IHJlZ2lvbnMgb2YgaGlnaGVy
IHBsYW5lcykuICBDb21wb3NpdG9ycyB0aGF0IHdhbnQgYSBVSSB3aXRoCj4gYSBzb2xpZCBjb2xv
ciBiYWNrZ3JvdW5kIGNhbiBwb3RlbnRpYWxseSBzYXZlIG1lbW9yeSBiYW5kd2lkdGggYnkKPiBz
ZXR0aW5nIHRoZSBDUlRDIGJhY2tncm91bmQgcHJvcGVydHkgYW5kIHVzaW5nIHNtYWxsZXIgcGxh
bmVzIHRvIGRpc3BsYXkKPiB0aGUgcmVzdCBvZiB0aGUgY29udGVudC4KPiAKPiBUbyBhdm9pZCBj
b25mdXNpb24gYmV0d2VlbiBkaWZmZXJlbnQgd2F5cyBvZiBlbmNvZGluZyBSR0IgZGF0YSwgd2UK
PiBkZWZpbmUgYSBzdGFuZGFyZCA2NC1iaXQgZm9ybWF0IHRoYXQgc2hvdWxkIGJlIHVzZWQgZm9y
IHRoaXMgcHJvcGVydHkncwo+IHZhbHVlLiAgSGVscGVyIGZ1bmN0aW9ucyBhbmQgbWFjcm9zIGFy
ZSBwcm92aWRlZCB0byBnZW5lcmF0ZSBhbmQgZGlzc2VjdAo+IHZhbHVlcyBpbiB0aGlzIHN0YW5k
YXJkIGZvcm1hdCB3aXRoIHZhcnlpbmcgY29tcG9uZW50IHByZWNpc2lvbiB2YWx1ZXMuCj4gCj4g
Q2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogd2VpLmMubGlAaW50ZWwu
Y29tCj4gQ2M6IGhhcmlzaC5rcnVwby5rcHNAaW50ZWwuY29tCj4gU2lnbmVkLW9mZi1ieTogTWF0
dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv
ZHJtL2RybV9hdG9taWNfc3RhdGVfaGVscGVyLmMgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9k
cm1fYXRvbWljX3VhcGkuYyAgICAgICAgIHwgIDUgKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2Ry
bV9tb2RlX2NvbmZpZy5jICAgICAgICAgfCAgNiArKysrKysKPiAgaW5jbHVkZS9kcm0vZHJtX2Ny
dGMuaCAgICAgICAgICAgICAgICAgICAgfCAxNyArKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRl
L2RybS9kcm1fbW9kZV9jb25maWcuaCAgICAgICAgICAgICB8ICA1ICsrKysrCj4gIGluY2x1ZGUv
dWFwaS9kcm0vZHJtX21vZGUuaCAgICAgICAgICAgICAgIHwgMjYgKysrKysrKysrKysrKysrKysr
KysrKysrKysKPiAgNiBmaWxlcyBjaGFuZ2VkLCA2MCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAt
LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hlbHBlci5jIGIvZHJpdmVy
cy9ncHUvZHJtL2RybV9hdG9taWNfc3RhdGVfaGVscGVyLmMKPiBpbmRleCAzYmE5OTYwNjlkNjku
LjJmOGM1NTY2ODA4OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19z
dGF0ZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hl
bHBlci5jCj4gQEAgLTEwMSw2ICsxMDEsNyBAQCB2b2lkIF9fZHJtX2F0b21pY19oZWxwZXJfY3J0
Y19kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJc3RhdGUtPnBsYW5l
c19jaGFuZ2VkID0gZmFsc2U7Cj4gIAlzdGF0ZS0+Y29ubmVjdG9yc19jaGFuZ2VkID0gZmFsc2U7
Cj4gIAlzdGF0ZS0+Y29sb3JfbWdtdF9jaGFuZ2VkID0gZmFsc2U7Cj4gKwlzdGF0ZS0+Ymdjb2xv
cl9jaGFuZ2VkID0gZmFsc2U7Cj4gIAlzdGF0ZS0+enBvc19jaGFuZ2VkID0gZmFsc2U7Cj4gIAlz
dGF0ZS0+Y29tbWl0ID0gTlVMTDsKPiAgCXN0YXRlLT5ldmVudCA9IE5VTEw7Cj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9k
cm1fYXRvbWljX3VhcGkuYwo+IGluZGV4IGQ1YjdmMzE1MDk4Yy4uMzk5ZjBlYWQ1MzcwIDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYwo+ICsrKyBiL2RyaXZl
cnMvZ3B1L2RybS9kcm1fYXRvbWljX3VhcGkuYwo+IEBAIC00NjcsNiArNDY3LDkgQEAgc3RhdGlj
IGludCBkcm1fYXRvbWljX2NydGNfc2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywK
PiAgCQkJcmV0dXJuIC1FRkFVTFQ7Cj4gIAo+ICAJCXNldF9vdXRfZmVuY2VfZm9yX2NydGMoc3Rh
dGUtPnN0YXRlLCBjcnRjLCBmZW5jZV9wdHIpOwo+ICsJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBj
b25maWctPmJnY29sb3JfcHJvcGVydHkpIHsKPiArCQlzdGF0ZS0+YmFja2dyb3VuZF9jb2xvciA9
IHZhbDsKPiArCQlzdGF0ZS0+Ymdjb2xvcl9jaGFuZ2VkID0gdHJ1ZTsKPiAgCX0gZWxzZSBpZiAo
Y3J0Yy0+ZnVuY3MtPmF0b21pY19zZXRfcHJvcGVydHkpIHsKPiAgCQlyZXR1cm4gY3J0Yy0+ZnVu
Y3MtPmF0b21pY19zZXRfcHJvcGVydHkoY3J0Yywgc3RhdGUsIHByb3BlcnR5LCB2YWwpOwo+ICAJ
fSBlbHNlIHsKPiBAQCAtNDk5LDYgKzUwMiw4IEBAIGRybV9hdG9taWNfY3J0Y19nZXRfcHJvcGVy
dHkoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCSp2YWwgPSAoc3RhdGUtPmdhbW1hX2x1dCkg
PyBzdGF0ZS0+Z2FtbWFfbHV0LT5iYXNlLmlkIDogMDsKPiAgCWVsc2UgaWYgKHByb3BlcnR5ID09
IGNvbmZpZy0+cHJvcF9vdXRfZmVuY2VfcHRyKQo+ICAJCSp2YWwgPSAwOwo+ICsJZWxzZSBpZiAo
cHJvcGVydHkgPT0gY29uZmlnLT5iZ2NvbG9yX3Byb3BlcnR5KQo+ICsJCSp2YWwgPSBzdGF0ZS0+
YmFja2dyb3VuZF9jb2xvcjsKPiAgCWVsc2UgaWYgKGNydGMtPmZ1bmNzLT5hdG9taWNfZ2V0X3By
b3BlcnR5KQo+ICAJCXJldHVybiBjcnRjLT5mdW5jcy0+YXRvbWljX2dldF9wcm9wZXJ0eShjcnRj
LCBzdGF0ZSwgcHJvcGVydHksIHZhbCk7Cj4gIAllbHNlCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9kcm1fbW9kZV9jb25maWcuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9jb25m
aWcuYwo+IGluZGV4IGVlODA3ODhmMmM0MC4uNzVlMzc2NzU1MTc2IDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9kcm1fbW9kZV9jb25maWcuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9k
cm1fbW9kZV9jb25maWcuYwo+IEBAIC0zNTIsNiArMzUyLDEyIEBAIHN0YXRpYyBpbnQgZHJtX21v
ZGVfY3JlYXRlX3N0YW5kYXJkX3Byb3BlcnRpZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAg
CQlyZXR1cm4gLUVOT01FTTsKPiAgCWRldi0+bW9kZV9jb25maWcubW9kaWZpZXJzX3Byb3BlcnR5
ID0gcHJvcDsKPiAgCj4gKwlwcm9wID0gZHJtX3Byb3BlcnR5X2NyZWF0ZV9yYW5nZShkZXYsIDAs
ICJCQUNLR1JPVU5EX0NPTE9SIiwKPiArCQkJCQkgMCwgR0VOTUFTS19VTEwoNjMsIDApKTsKPiAr
CWlmICghcHJvcCkKPiArCQlyZXR1cm4gLUVOT01FTTsKPiArCWRldi0+bW9kZV9jb25maWcuYmdj
b2xvcl9wcm9wZXJ0eSA9IHByb3A7Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gZGlmZiAt
LWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jcnRjLmggYi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4g
aW5kZXggYjIxNDM3YmM5NWJmLi5kZGZkYWQ5Y2NlY2IgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9k
cm0vZHJtX2NydGMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jcnRjLmgKPiBAQCAtMTY4LDYg
KzE2OCwxMSBAQCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgewo+ICAJICogZHJpdmVycyB0byBzdGVl
ciB0aGUgYXRvbWljIGNvbW1pdCBjb250cm9sIGZsb3cuCj4gIAkgKi8KPiAgCWJvb2wgY29sb3Jf
bWdtdF9jaGFuZ2VkIDogMTsKPiArCS8qKgo+ICsJICogQGJnY29sb3JfY2hhbmdlZDogQmFja2dy
b3VuZCBjb2xvciB2YWx1ZSBoYXMgY2hhbmdlZC4gIFVzZWQgYnkKPiArCSAqIGRyaXZlcnMgdG8g
c3RlZXIgdGhlIGF0b21pYyBjb21taXQgY29udHJvbCBmbG93Lgo+ICsJICovCj4gKwlib29sIGJn
Y29sb3JfY2hhbmdlZCA6IDE7Cj4gIAo+ICAJLyoqCj4gIAkgKiBAbm9fdmJsYW5rOgo+IEBAIC0y
NzQsNiArMjc5LDE4IEBAIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSB7Cj4gIAkgKi8KPiAgCXN0cnVj
dCBkcm1fcHJvcGVydHlfYmxvYiAqZ2FtbWFfbHV0Owo+ICAKPiArCS8qKgo+ICsJICogQGJhY2tn
cm91bmRfY29sb3I6Cj4gKwkgKgo+ICsJICogUkdCIHZhbHVlIHJlcHJlc2VudGluZyB0aGUgcGlw
ZSdzIGJhY2tncm91bmQgY29sb3IuICBUaGUgYmFja2dyb3VuZAo+ICsJICogY29sb3IgKGFrYSAi
Y2FudmFzIGNvbG9yIikgb2YgYSBwaXBlIGlzIHRoZSBjb2xvciB0aGF0IHdpbGwgYmUgdXNlZAo+
ICsJICogZm9yIHBpeGVscyBub3QgY292ZXJlZCBieSBhIHBsYW5lLCBvciBjb3ZlcmVkIGJ5IHRy
YW5zcGFyZW50IHBpeGVscwo+ICsJICogb2YgYSBwbGFuZS4gIFRoZSB2YWx1ZSBoZXJlIHNob3Vs
ZCBiZSBidWlsdCB2aWEgZHJtX3JnYmEoKTsKPiArCSAqIGluZGl2aWR1YWwgY29sb3IgY29tcG9u
ZW50cyBjYW4gYmUgZXh0cmFjdGVkIHdpdGggZGVzaXJlZCBwcmVjaXNpb24KPiArCSAqIHZpYSB0
aGUgRFJNX1JHQkFfKigpIG1hY3Jvcy4KPiArCSAqLwo+ICsJdTY0IGJhY2tncm91bmRfY29sb3I7
Cj4gKwo+ICAJLyoqCj4gIAkgKiBAdGFyZ2V0X3ZibGFuazoKPiAgCSAqCj4gZGlmZiAtLWdpdCBh
L2luY2x1ZGUvZHJtL2RybV9tb2RlX2NvbmZpZy5oIGIvaW5jbHVkZS9kcm0vZHJtX21vZGVfY29u
ZmlnLmgKPiBpbmRleCA5MjhlNDE3MmEwYmIuLmMzZjU3YTllNWIzMSAxMDA2NDQKPiAtLS0gYS9p
bmNsdWRlL2RybS9kcm1fbW9kZV9jb25maWcuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9tb2Rl
X2NvbmZpZy5oCj4gQEAgLTgwNyw2ICs4MDcsMTEgQEAgc3RydWN0IGRybV9tb2RlX2NvbmZpZyB7
Cj4gIAkgKi8KPiAgCXN0cnVjdCBkcm1fcHJvcGVydHkgKndyaXRlYmFja19vdXRfZmVuY2VfcHRy
X3Byb3BlcnR5Owo+ICAKPiArCS8qKgo+ICsJICogQGJnY29sb3JfcHJvcGVydHk6IFJHQkEgYmFj
a2dyb3VuZCBjb2xvciBmb3IgQ1JUQy4KPiArCSAqLwo+ICsJc3RydWN0IGRybV9wcm9wZXJ0eSAq
Ymdjb2xvcl9wcm9wZXJ0eTsKPiArCj4gIAkvKiBkdW1iIGlvY3RsIHBhcmFtZXRlcnMgKi8KPiAg
CXVpbnQzMl90IHByZWZlcnJlZF9kZXB0aCwgcHJlZmVyX3NoYWRvdzsKPiAgCWJvb2wgcXVpcmtf
YWRkZmJfcHJlZmVyX3hiZ3JfMzBicHA7Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvdWFwaS9kcm0v
ZHJtX21vZGUuaCBiL2luY2x1ZGUvdWFwaS9kcm0vZHJtX21vZGUuaAo+IGluZGV4IGQzZTBmZTMx
ZWZjNS4uNjZlMmUyYzI2MzBlIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvdWFwaS9kcm0vZHJtX21v
ZGUuaAo+ICsrKyBiL2luY2x1ZGUvdWFwaS9kcm0vZHJtX21vZGUuaAo+IEBAIC04ODgsNiArODg4
LDMyIEBAIHN0cnVjdCBkcm1fbW9kZV9yZXZva2VfbGVhc2Ugewo+ICAJX191MzIgbGVzc2VlX2lk
Owo+ICB9Owo+ICAKPiArLyoKPiArICogUHV0IFJHQkEgdmFsdWVzIGludG8gYSBzdGFuZGFyZCA2
NC1iaXQgcmVwcmVzZW50YXRpb24gdGhhdCBjYW4gYmUgdXNlZAo+ICsgKiBmb3IgaW9jdGwgcGFy
YW1ldGVycywgaW50ZXItZHJpdmVyIGNvbW1tdW5pY2F0aW9uLCBldGMuICBJZiB0aGUgY29tcG9u
ZW50Cj4gKyAqIHZhbHVlcyBiZWluZyBwcm92aWRlZCBjb250YWluIGxlc3MgdGhhbiAxNiBiaXRz
IG9mIHByZWNpc2lvbiwgdGhleSdsbAo+ICsgKiBiZSBzaGlmdGVkIGludG8gdGhlIG1vc3Qgc2ln
bmlmaWNhbnQgYml0cy4KPiArICovCj4gK3N0YXRpYyBpbmxpbmUgX191NjQKPiArZHJtX3JnYmEo
X191OCBicGMsIF9fdTE2IHJlZCwgX191MTYgZ3JlZW4sIF9fdTE2IGJsdWUsIF9fdTE2IGFscGhh
KQo+ICt7Cj4gKwlpbnQgbXNiX3NoaWZ0ID0gMTYgLSBicGM7Cj4gKwo+ICsJcmV0dXJuIChfX3U2
NClhbHBoYSA8PCBtc2Jfc2hpZnQgPDwgNDggfAo+ICsJICAgICAgIChfX3U2NClibHVlICA8PCBt
c2Jfc2hpZnQgPDwgMzIgfAo+ICsJICAgICAgIChfX3U2NClncmVlbiA8PCBtc2Jfc2hpZnQgPDwg
MTYgfAo+ICsJICAgICAgIChfX3U2NClyZWQgICA8PCBtc2Jfc2hpZnQ7CgpJIHdvdWxkIHN0aWxs
IGNhbGwgdGhhdCBhYmdyIGluIGRybSB0ZXJtaW5vbG9neSAoZWcuIHdoZW4gY29tcGFyZWQKdG8g
dGhlIGZvdXJjY3MpLiBBbmQgSSdkIHN0aWxsIHByZWZlciB0aGUgYXJnYiBvcmRlciBhcyBpdCdz
IHdoYXQKb3VyIGhhcmR3YXJlIGV4cGVjdHMgYW55d2F5IDopIFdvdWxkIG1ha2UgbWUgbGVzcyBj
b25mdXNlZCB3aGVuCmxvb2tpbmcgYXQgYSA2NGJpdCBoZXggY29sb3IgdmFsdWUgYXQgbGVhc3Qu
CgoKPiArfQo+ICsKPiArLyoKPiArICogRXh0cmFjdCB0aGUgc3BlY2lmaWVkIG51bWJlciBvZiBi
aXRzIG9mIGEgc3BlY2lmaWMgY29sb3IgY29tcG9uZW50IGZyb20gYQo+ICsgKiBzdGFuZGFyZCA2
NC1iaXQgUkdCQSB2YWx1ZS4KPiArICovCj4gKyNkZWZpbmUgRFJNX1JHQkFfUkVEKGMsIG51bWJp
dHMpICAgKF9fdTE2KSgoYyAmIDB4RkZGRnVsbCkgICAgID4+ICgxNi1udW1iaXRzKSkKPiArI2Rl
ZmluZSBEUk1fUkdCQV9HUkVFTihjLCBudW1iaXRzKSAoX191MTYpKChjICYgMHhGRkZGdWxsPDwx
NikgPj4gKDMyLW51bWJpdHMpKQo+ICsjZGVmaW5lIERSTV9SR0JBX0JMVUUoYywgbnVtYml0cykg
IChfX3UxNikoKGMgJiAweEZGRkZ1bGw8PDMyKSA+PiAoNDgtbnVtYml0cykpCj4gKyNkZWZpbmUg
RFJNX1JHQkFfQUxQSEEoYywgbnVtYml0cykgKF9fdTE2KSgoYyAmIDB4RkZGRnVsbDw8NDgpID4+
ICg2NC1udW1iaXRzKSkKPiArCj4gICNpZiBkZWZpbmVkKF9fY3BsdXNwbHVzKQo+ICB9Cj4gICNl
bmRpZgo+IC0tIAo+IDIuMTQuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0
cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu
L2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs
aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz
a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK