dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6D16D0 panel
Date: Thu, 11 Oct 2018 13:37:04 +0200	[thread overview]
Message-ID: <20181011113704.GA18397@ravnborg.org> (raw)
In-Reply-To: <CACRpkdY4fL9a1wozxSALi7S1Fab3ovV6BognxLHUJvdWur4HWA@mail.gmail.com>

> > > +     if (IS_ERR(s6->supply))
> > > +             return PTR_ERR(s6->supply);
> >
> > This cannot be -EPROBE_DEFER?
> 
> It can and then it bails out here and retries later.
> 
> I don't quite get the question, sorry.
> 
> > > +     if (IS_ERR(s6->reset_gpio)) {
> > > +             ret = PTR_ERR(s6->reset_gpio);
> > > +             if (ret != -EPROBE_DEFER)
> > > +                     dev_err(dev, "failed to request GPIO: %d\n", ret);
> > > +             return ret;
> > > +     }
> >
> > Like this..
> 
> -EPROBE_DEFER is only tested to not produce error prints
> unnecessarily. In the regulator case, the regulator core already
> displays an error.
This was what I missed above (that we only check -EPROBE_DEFER to avoid printing).
So my question was just me confusing things.

Thanks for the explanation.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2018-10-11 11:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 10:58 [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0 Linus Walleij
2018-10-08 10:58 ` [PATCH 2/2] drm/panel: Add driver for Samsung S6D16D0 panel Linus Walleij
2018-10-09  8:29   ` Andrzej Hajda
2018-10-09 18:46     ` Linus Walleij
2018-10-10  6:37       ` Andrzej Hajda
2018-10-19 13:52       ` Linus Walleij
2018-10-09 19:43   ` Sam Ravnborg
2018-10-11  9:03     ` Linus Walleij
2018-10-11 11:37       ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011113704.GA18397@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linus.walleij@linaro.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox