From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org, mesa-dev@lists.freedesktop.org
Cc: Rob Clark <robclark@freedesktop.org>
Subject: [PATCH libdrm] xf86drmHash: remove redundant zero init
Date: Thu, 11 Oct 2018 19:18:10 -0400 [thread overview]
Message-ID: <20181011231810.1363-1-robdclark@gmail.com> (raw)
From: Rob Clark <robclark@freedesktop.org>
drmMalloc() is already calloc()
Signed-off-by: Rob Clark <robclark@freedesktop.org>
---
Small micro-optimization that I noticed while doing some perf work..
I should probably look at promoting amdgpu's handle_table to core
libdrm and replacing a couple of libdrm_freedreno's xf86drmHash
tables over to that. There is still at least one hashtable (in
some libdrm_freedreno patches I'm working on finalizing) where
handle_table would not be appropriate (ie. key is a ptr).. but the
answer there might be importing a better hashtable implementation
into libdrm.
Related note, once I land a libdrm_freedreno patchset (hopefully
tomorrow or over the weekend), I'll have interest in making a
libdrm release so I can start landing mesa patches that will
depend on that.. so if anyone else wants me to wait a few days
so they can push something before the next libdrm release, please
let me know.
xf86drmHash.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/xf86drmHash.c b/xf86drmHash.c
index b2fa414e..39900e7e 100644
--- a/xf86drmHash.c
+++ b/xf86drmHash.c
@@ -109,12 +109,7 @@ void *drmHashCreate(void)
table = drmMalloc(sizeof(*table));
if (!table) return NULL;
table->magic = HASH_MAGIC;
- table->entries = 0;
- table->hits = 0;
- table->partials = 0;
- table->misses = 0;
- for (i = 0; i < HASH_SIZE; i++) table->buckets[i] = NULL;
return table;
}
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2018-10-11 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 23:18 Rob Clark [this message]
2018-10-12 10:53 ` [Mesa-dev] [PATCH libdrm] xf86drmHash: remove redundant zero init Eric Engestrom
2018-10-12 13:04 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011231810.1363-1-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mesa-dev@lists.freedesktop.org \
--cc=robclark@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox