From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Outreachy kernel] [PATCH DRM] drm: Shift * to be adjacent to pointer name Date: Tue, 16 Oct 2018 14:37:41 +0200 Message-ID: <20181016123741.GX31561@phenom.ffwll.local> References: <20181015212644.GA28579@armorer> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 820A66E207 for ; Tue, 16 Oct 2018 12:37:45 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id z21-v6so21127247edb.11 for ; Tue, 16 Oct 2018 05:37:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, outreachy-kernel@googlegroups.com, Mamta Shukla , daniel.vetter@ffwll.ch, sean@poorly.run List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMTI6MzA6MTZQTSArMDIwMCwgSnVsaWEgTGF3YWxsIHdy b3RlOgo+IAo+IAo+IE9uIFR1ZSwgMTYgT2N0IDIwMTgsIE1hbXRhIFNodWtsYSB3cm90ZToKPiAK PiA+IFNoaWZ0ICogdG8gYmUgYWRqYWNlbnQgdG8gcG9pbnRlciBuYW1lIHRvIGZvbGxvdyBMaW51 eCBjb2Rpbmcgc3R5bGUuCj4gPiBJc3N1ZSBmb3VuZCB3aXRoIGNoZWNrcGF0Y2gucGwKPiA+IEVS Uk9SOiAiZm9vICogYmFyIiBzaG91bGQgYmUgImZvbyAqYmFyIgo+IAo+IFRoZSBwYXRjaCBsb29r cyBPSywgYnV0IGF0IHRoaXMgcG9pbnQsIHlvdSBrbm93IGhvdyB0byBzZW5kIGEgcGF0Y2gsIHNv IGl0Cj4gd291bGQgYmUgYmV0dGVyIHRvIGZvY3VzIG9uIGNoYW5nZXMgdGhhdCBhcmUgbW9yZSBj b21wbGV4IHRoYW4gd2hpdGVzcGFjZQo+IGlzc3Vlcy4KCkNhbid0IGh1cnQgdG8gdGVzdC1kcml2 ZSBwYXRjaCBzdWJtaXNzaW9uIHRvIGEgbm9uLW91dHJlYWNoeSBtYWlsaW5nIGxpc3QKd2l0aCBz b21ldGhpbmcgc2ltcGxlIDotKQoKVGhhbmtzIGZvciB5b3VyIHBhdGNoLCBhcHBsaWVkIHRvIGRy bS1taXNjLW5leHQgKGZvciA0LjIxLzUuMSBtb3N0Cmxpa2VseSkuCi1EYW5pZWwKCj4gCj4ganVs aWEKPiAKPiAKPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBNYW10YSBTaHVrbGEgPG1hbXRhc2h1a2xh NTU1QGdtYWlsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fbWVtb3J5LmMg fCAxMCArKysrKy0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNSBk ZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9tZW1v cnkuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbWVtb3J5LmMKPiA+IGluZGV4IGQ2OWU0ZmMuLjQw YzQzNDkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX21lbW9yeS5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX21lbW9yeS5jCj4gPiBAQCAtNTEsNyArNTEsNyBAQAo+ ID4gICNlbmRpZgo+ID4KPiA+ICBzdGF0aWMgdm9pZCAqYWdwX3JlbWFwKHVuc2lnbmVkIGxvbmcg b2Zmc2V0LCB1bnNpZ25lZCBsb25nIHNpemUsCj4gPiAtCQkgICAgICAgc3RydWN0IGRybV9kZXZp Y2UgKiBkZXYpCj4gPiArCQkgICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICB7Cj4g PiAgCXVuc2lnbmVkIGxvbmcgaSwgbnVtX3BhZ2VzID0KPiA+ICAJICAgIFBBR0VfQUxJR04oc2l6 ZSkgLyBQQUdFX1NJWkU7Cj4gPiBAQCAtOTQsMjYgKzk0LDI2IEBAIHN0YXRpYyB2b2lkICphZ3Bf cmVtYXAodW5zaWduZWQgbG9uZyBvZmZzZXQsIHVuc2lnbmVkIGxvbmcgc2l6ZSwKPiA+ICB9Cj4g Pgo+ID4gIC8qKiBXcmFwcGVyIGFyb3VuZCBhZ3BfZnJlZV9tZW1vcnkoKSAqLwo+ID4gLXZvaWQg ZHJtX2ZyZWVfYWdwKHN0cnVjdCBhZ3BfbWVtb3J5ICogaGFuZGxlLCBpbnQgcGFnZXMpCj4gPiAr dm9pZCBkcm1fZnJlZV9hZ3Aoc3RydWN0IGFncF9tZW1vcnkgKmhhbmRsZSwgaW50IHBhZ2VzKQo+ ID4gIHsKPiA+ICAJYWdwX2ZyZWVfbWVtb3J5KGhhbmRsZSk7Cj4gPiAgfQo+ID4KPiA+ICAvKiog V3JhcHBlciBhcm91bmQgYWdwX2JpbmRfbWVtb3J5KCkgKi8KPiA+IC1pbnQgZHJtX2JpbmRfYWdw KHN0cnVjdCBhZ3BfbWVtb3J5ICogaGFuZGxlLCB1bnNpZ25lZCBpbnQgc3RhcnQpCj4gPiAraW50 IGRybV9iaW5kX2FncChzdHJ1Y3QgYWdwX21lbW9yeSAqaGFuZGxlLCB1bnNpZ25lZCBpbnQgc3Rh cnQpCj4gPiAgewo+ID4gIAlyZXR1cm4gYWdwX2JpbmRfbWVtb3J5KGhhbmRsZSwgc3RhcnQpOwo+ ID4gIH0KPiA+Cj4gPiAgLyoqIFdyYXBwZXIgYXJvdW5kIGFncF91bmJpbmRfbWVtb3J5KCkgKi8K PiA+IC1pbnQgZHJtX3VuYmluZF9hZ3Aoc3RydWN0IGFncF9tZW1vcnkgKiBoYW5kbGUpCj4gPiAr aW50IGRybV91bmJpbmRfYWdwKHN0cnVjdCBhZ3BfbWVtb3J5ICpoYW5kbGUpCj4gPiAgewo+ID4g IAlyZXR1cm4gYWdwX3VuYmluZF9tZW1vcnkoaGFuZGxlKTsKPiA+ICB9Cj4gPgo+ID4gICNlbHNl IC8qICBDT05GSUdfQUdQICAqLwo+ID4gIHN0YXRpYyBpbmxpbmUgdm9pZCAqYWdwX3JlbWFwKHVu c2lnbmVkIGxvbmcgb2Zmc2V0LCB1bnNpZ25lZCBsb25nIHNpemUsCj4gPiAtCQkJICAgICAgc3Ry dWN0IGRybV9kZXZpY2UgKiBkZXYpCj4gPiArCQkJICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRl dikKPiA+ICB7Cj4gPiAgCXJldHVybiBOVUxMOwo+ID4gIH0KPiA+IC0tCj4gPiAxLjkuMQo+ID4K PiA+IC0tCj4gPiBZb3UgcmVjZWl2ZWQgdGhpcyBtZXNzYWdlIGJlY2F1c2UgeW91IGFyZSBzdWJz Y3JpYmVkIHRvIHRoZSBHb29nbGUgR3JvdXBzICJvdXRyZWFjaHkta2VybmVsIiBncm91cC4KPiA+ IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBncm91cCBhbmQgc3RvcCByZWNlaXZpbmcgZW1haWxz IGZyb20gaXQsIHNlbmQgYW4gZW1haWwgdG8gb3V0cmVhY2h5LWtlcm5lbCt1bnN1YnNjcmliZUBn b29nbGVncm91cHMuY29tLgo+ID4gVG8gcG9zdCB0byB0aGlzIGdyb3VwLCBzZW5kIGVtYWlsIHRv IG91dHJlYWNoeS1rZXJuZWxAZ29vZ2xlZ3JvdXBzLmNvbS4KPiA+IFRvIHZpZXcgdGhpcyBkaXNj dXNzaW9uIG9uIHRoZSB3ZWIgdmlzaXQgaHR0cHM6Ly9ncm91cHMuZ29vZ2xlLmNvbS9kL21zZ2lk L291dHJlYWNoeS1rZXJuZWwvMjAxODEwMTUyMTI2NDQuR0EyODU3OSU0MGFybW9yZXIuCj4gPiBG b3IgbW9yZSBvcHRpb25zLCB2aXNpdCBodHRwczovL2dyb3Vwcy5nb29nbGUuY29tL2Qvb3B0b3V0 Lgo+ID4KCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK