From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/atomic_helper: Stop modesets on
 unregistered connectors harder
Date: Tue, 16 Oct 2018 14:48:27 +0200
Message-ID: <20181016124827.GY31561@phenom.ffwll.local>
References: <20181016023306.27417-1-lyude@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20181016023306.27417-1-lyude@redhat.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Maxime Ripard <maxime.ripard@bootlin.com>, dri-devel@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: dri-devel@lists.freedesktop.org

T24gTW9uLCBPY3QgMTUsIDIwMTggYXQgMTA6MzM6MDZQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3cm90
ZToKPiBVbmZvcnR1bmF0ZWx5LCBpdCBhcHBlYXJzIG91ciBmaXggaW46Cj4gY29tbWl0IGI1ZDI5
ODQzZDhlZiAoImRybS9hdG9taWNfaGVscGVyOiBBbGxvdyBEUE1TIE9uPC0+T2ZmIGNoYW5nZXMK
PiBmb3IgdW5yZWdpc3RlcmVkIGNvbm5lY3RvcnMiKQo+IAo+IFdoaWNoIGF0dGVtcHRlZCB0byB3
b3JrIGFyb3VuZCB0aGUgcHJvYmxlbXMgaW50cm9kdWNlZCBieToKPiBjb21taXQgNGQ4MDI3Mzk3
NmJmICgiZHJtL2F0b21pY19oZWxwZXI6IERpc2FsbG93IG5ldyBtb2Rlc2V0cyBvbgo+IHVucmVn
aXN0ZXJlZCBjb25uZWN0b3JzIikKPiAKPiBJcyBzdGlsbCBub3QgdGhlIHJpZ2h0IHNvbHV0aW9u
LCBhcyBtb2Rlc2V0cyBjYW4gc3RpbGwgYmUgdHJpZ2dlcmVkCj4gb3V0c2lkZSBvZiBkcm1fYXRv
bWljX3NldF9jcnRjX2Zvcl9jb25uZWN0b3IoKS4KPiAKPiBTbyBpbiBvcmRlciB0byBmaXggdGhp
cywgd2hpbGUgc3RpbGwgYmVpbmcgY2FyZWZ1bCB0aGF0IHdlIGRvbid0IGJyZWFrCj4gbW9kZXNl
dHMgdGhhdCBhIGRyaXZlciBtYXkgcGVyZm9ybSBiZWZvcmUgYmVpbmcgcmVnaXN0ZXJlZCB3aXRo
Cj4gdXNlcnNwYWNlLCB3ZSByZXBsYWNlIGNvbm5lY3Rvci0+cmVnaXN0ZXJlZCB3aXRoIGEgdHJp
c3RhdGUgbWVtYmVyLAo+IGNvbm5lY3Rvci0+cmVnaXN0cmF0aW9uX3N0YXRlLiBUaGlzIGFsbG93
cyB1cyB0byBrZWVwIHRyYWNrIG9mIHdoZXRoZXIKPiBvciBub3QgYSBjb25uZWN0b3IgaXMgc3Rp
bGwgaW5pdGlhbGl6aW5nIGFuZCBoYXNuJ3QgYmVlbiBleHBvc2VkIHRvCj4gdXNlcnNwYWNlLCBp
cyBjdXJyZW50bHkgcmVnaXN0ZXJlZCBhbmQgZXhwb3NlZCB0byB1c2Vyc3BhY2UsIG9yIGhhcyBi
ZWVuCj4gbGVnaXRpbWF0ZWx5IHJlbW92ZWQgZnJvbSB0aGUgc3lzdGVtIGFmdGVyIGhhdmluZyBv
bmNlIGJlZW4gcHJlc2VudC4KPiAKPiBVc2luZyB0aGlzIGluZm8sIHdlIGNhbiBwcmV2ZW50IHVz
ZXJzcGFjZSBmcm9tIHBlcmZvcm1pbmcgbmV3IG1vZGVzZXRzCj4gb24gdW5yZWdpc3RlcmVkIGNv
bm5lY3RvcnMgd2hpbGUgc3RpbGwgYWxsb3dpbmcgdGhlIGRyaXZlciB0byBwZXJmb3JtCj4gbW9k
ZXNldHMgb24gdW5yZWdpc3RlcmVkIGNvbm5lY3RvcnMgYmVmb3JlIHRoZSBkcml2ZXIgaGFzIGZp
bmlzaGVkIGJlaW5nCj4gcmVnaXN0ZXJlZC4KPiAKPiBGaXhlczogYjVkMjk4NDNkOGVmICgiZHJt
L2F0b21pY19oZWxwZXI6IEFsbG93IERQTVMgT248LT5PZmYgY2hhbmdlcyBmb3IgdW5yZWdpc3Rl
cmVkIGNvbm5lY3RvcnMiKQo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu
dXguaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNo
Pgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gQ2M6IHN0YWJs
ZUB2Z2VyLmtlcm5lbC5vcmcKPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+
IFNpZ25lZC1vZmYtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4gLS0tCj4gIGRy
aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgNjAgKysrKysrKysrKysrKysrKysr
KysrLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY191YXBpLmMgICB8IDIxIC0tLS0t
LS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jICAgICB8IDEwICsrLS0tCj4g
IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jIHwgIDggKystLQo+ICBpbmNsdWRl
L2RybS9kcm1fY29ubmVjdG9yLmggICAgICAgICB8IDY4ICsrKysrKysrKysrKysrKysrKysrKysr
KysrKystCj4gIDUgZmlsZXMgY2hhbmdlZCwgMTI3IGluc2VydGlvbnMoKyksIDQwIGRlbGV0aW9u
cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIu
YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggNmY2Njc3N2Rj
YTRiLi42Y2FkZWFmMjhhZTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t
aWNfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+
IEBAIC01MjksNiArNTI5LDM1IEBAIG1vZGVfdmFsaWQoc3RydWN0IGRybV9hdG9taWNfc3RhdGUg
KnN0YXRlKQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQKPiArdW5yZWdpc3Rl
cmVkX2Nvbm5lY3Rvcl9jaGVjayhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gKwkJ
CSAgICAgc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiArCQkJICAgICBzdHJ1Y3Qg
ZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqb2xkX2Nvbm5fc3RhdGUsCj4gKwkJCSAgICAgc3RydWN0IGRy
bV9jb25uZWN0b3Jfc3RhdGUgKm5ld19jb25uX3N0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2Ny
dGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gKwo+ICsJ
aWYgKCFkcm1fY29ubmVjdG9yX3VucmVnaXN0ZXJlZChjb25uZWN0b3IpKQo+ICsJCXJldHVybiAw
Owo+ICsKPiArCWNydGMgPSBuZXdfY29ubl9zdGF0ZS0+Y3J0YzsKPiArCWlmICghY3J0YykKPiAr
CQlyZXR1cm4gMDsKPiArCj4gKwljcnRjX3N0YXRlID0gZHJtX2F0b21pY19nZXRfbmV3X2NydGNf
c3RhdGUoc3RhdGUsIGNydGMpOwo+ICsJaWYgKCFjcnRjX3N0YXRlIHx8ICFkcm1fYXRvbWljX2Ny
dGNfbmVlZHNfbW9kZXNldChjcnRjX3N0YXRlKSkKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlpZiAo
Y3J0Y19zdGF0ZS0+bW9kZV9jaGFuZ2VkKSB7Cj4gKwkJRFJNX0RFQlVHX0FUT01JQygiW0NPTk5F
Q1RPUjolZDolc10gY2FuJ3QgY2hhbmdlIG1vZGUgb24gdW5yZWdpc3RlcmVkIGNvbm5lY3Rvclxu
IiwKPiArCQkJCSBjb25uZWN0b3ItPmJhc2UuaWQsIGNvbm5lY3Rvci0+bmFtZSk7Cj4gKwkJcmV0
dXJuIC1FSU5WQUw7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gIC8qKgo+ICAg
KiBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0IC0gdmFsaWRhdGUgc3RhdGUgb2JqZWN0
IGZvciBtb2Rlc2V0IGNoYW5nZXMKPiAgICogQGRldjogRFJNIGRldmljZQo+IEBAIC02ODQsMTgg
KzcxMywzMyBAQCBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0KHN0cnVjdCBkcm1fZGV2
aWNlICpkZXYsCj4gIAkJCXJldHVybiByZXQ7Cj4gIAl9Cj4gIAo+IC0JLyoKPiAtCSAqIEl0ZXJh
dGUgb3ZlciBhbGwgY29ubmVjdG9ycyBhZ2FpbiwgdG8gbWFrZSBzdXJlIGF0b21pY19jaGVjaygp
Cj4gLQkgKiBoYXMgYmVlbiBjYWxsZWQgb24gdGhlbSB3aGVuIGEgbW9kZXNldCBpcyBmb3JjZWQu
Cj4gLQkgKi8KPiAgCWZvcl9lYWNoX29sZG5ld19jb25uZWN0b3JfaW5fc3RhdGUoc3RhdGUsIGNv
bm5lY3Rvciwgb2xkX2Nvbm5lY3Rvcl9zdGF0ZSwgbmV3X2Nvbm5lY3Rvcl9zdGF0ZSwgaSkgewo+
ICAJCWNvbnN0IHN0cnVjdCBkcm1fY29ubmVjdG9yX2hlbHBlcl9mdW5jcyAqZnVuY3MgPSBjb25u
ZWN0b3ItPmhlbHBlcl9wcml2YXRlOwo+ICAKPiAtCQlpZiAoY29ubmVjdG9yc19tYXNrICYgQklU
KGkpKQo+IC0JCQljb250aW51ZTsKPiArCQkvKiBNYWtlIHN1cmUgYXRvbWljX2NoZWNrKCkgaXMg
Y2FsbGVkIG9uIGFueSB1bmNoZWNrZWQKPiArCQkgKiBjb25uZWN0b3JzIHdoZW4gYSBtb2Rlc2V0
IGhhcyBiZWVuIGZvcmNlZAo+ICsJCSAqLwo+ICsJCWlmIChjb25uZWN0b3JzX21hc2sgJiBCSVQo
aSkgJiYgZnVuY3MtPmF0b21pY19jaGVjaykgewo+ICsJCQlyZXQgPSBmdW5jcy0+YXRvbWljX2No
ZWNrKGNvbm5lY3RvciwKPiArCQkJCQkJICBuZXdfY29ubmVjdG9yX3N0YXRlKTsKPiArCQkJaWYg
KHJldCkKPiArCQkJCXJldHVybiByZXQ7Cj4gKwkJfQo+ICAKPiAtCQlpZiAoZnVuY3MtPmF0b21p
Y19jaGVjaykKPiAtCQkJcmV0ID0gZnVuY3MtPmF0b21pY19jaGVjayhjb25uZWN0b3IsIG5ld19j
b25uZWN0b3Jfc3RhdGUpOwo+ICsJCS8qCj4gKwkJICogUHJldmVudCB1c2Vyc3BhY2UgZnJvbSB0
dXJuaW5nIG9uIG5ldyBkaXNwbGF5cyBvciBzZXR0aW5nCj4gKwkJICogbmV3IG1vZGVzIHVzaW5n
IGNvbm5lY3RvcnMgd2hpY2ggaGF2ZSBiZWVuIHJlbW92ZWQgZnJvbQo+ICsJCSAqIHVzZXJzcGFj
ZS4gVGhpcyBpcyByYWN5IHNpbmNlIGFuIHVucGx1ZyBjb3VsZCBoYXBwZW4gYXQgYW55Cj4gKwkJ
ICogdGltZSBpbmNsdWRpbmcgYWZ0ZXIgdGhpcyBjaGVjaywgYnV0IHRoYXQncyBPSzogd2Ugb25s
eQo+ICsJCSAqIGNhcmUgYWJvdXQgcHJldmVudGluZyB1c2Vyc3BhY2UgZnJvbSB0cnlpbmcgdG8g
c2V0IGludmFsaWQKPiArCQkgKiBzdGF0ZSB1c2luZyBkZXN0cm95ZWQgY29ubmVjdG9ycyB0aGF0
IGl0J3MgYmVlbiBub3RpZmllZAo+ICsJCSAqIGFib3V0LiBObyBvbmUgY2FuIHNhdmUgdXMgYWZ0
ZXIgdGhlIGF0b21pYyBjaGVjayBjb21wbGV0ZXMKPiArCQkgKiBidXQgb3Vyc2VsdmVzLgo+ICsJ
CSAqLwo+ICsJCXJldCA9IHVucmVnaXN0ZXJlZF9jb25uZWN0b3JfY2hlY2soc3RhdGUsCj4gKwkJ
CQkJCSAgIGNvbm5lY3RvciwKPiArCQkJCQkJICAgb2xkX2Nvbm5lY3Rvcl9zdGF0ZSwKPiArCQkJ
CQkJICAgbmV3X2Nvbm5lY3Rvcl9zdGF0ZSk7CgpJIGV4cGVjdCBhIGZ1bmN0aW9uYWwgcmV2ZXJ0
IG9mIGI1ZDI5ODQzZDhlZiAoImRybS9hdG9taWNfaGVscGVyOiBBbGxvdwpEUE1TIE9uPC0+T2Zm
IGNoYW5nZXMgZm9yIHVucmVnaXN0ZXJlZCBjb25uZWN0b3JzIiksIGJ1dCB3aXRoCmRybV9jb25u
ZWN0b3JfdW5yZWdpc3RlcmVkKCkgaW5zdGVhZCBvZiB0aGUgUkVBRF9PTkNFLiBUaGlzIGhlcmUg
aXMKZW50aXJlbHkgZGlmZmVyZW50LCBhbmQgSSdtIG5vdCBjbGVhciBvbiB3aHkuCgpBc2lkZSBm
cm9tIHRoaXMgbG9va3MgZ29vZCB0byBtZS4KCltzbmlwXQoKPiArLyoqCj4gKyAqIGRybV9jb25u
ZWN0b3JfdW5yZWdpc3RlcmVkIC0gaGFzIHRoZSBjb25uZWN0b3IgYmVlbiB1bnJlZ2lzdGVyZWQg
ZnJvbQo+ICsgKiB1c2Vyc3BhY2U/Cj4gKyAqIEBjb25uZWN0b3I6IERSTSBjb25uZWN0b3IKPiAr
ICoKPiArICogQ2hlY2tzIHdoZXRoZXIgb3Igbm90IEBjb25uZWN0b3IgaGFzIGJlZW4gdW5yZWdp
c3RlcmVkIGZyb20gdXNlcnNwYWNlLgo+ICsgKgo+ICsgKiBSZXR1cm5zOgo+ICsgKiBUcnVlIGlm
IHRoZSBjb25uZWN0b3Igd2FzIHVucmVnaXN0ZXJlZCwgZmFsc2UgaWYgdGhlIGNvbm5lY3RvciBp
cwo+ICsgKiByZWdpc3RlcmVkIG9yIGhhcyBub3QgeWV0IGJlZW4gcmVnaXN0ZXJlZCB3aXRoIHVz
ZXJzcGFjZS4KPiArICovCj4gK3N0YXRpYyBpbmxpbmUgYm9vbCBkcm1fY29ubmVjdG9yX3VucmVn
aXN0ZXJlZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQoKQmlrZXNoZWQ6IEknZCBj
YWxsIHRoaXMgZHJtX2Nvbm5lY3Rvcl9pc191bnJlZ2lzdGVyZWQoKS4gQyBpcyBpbXBlcmF0aXZl
LApmdW5jdGlvbnMgd2l0aG91dCB2ZXJicyBhbHdheXMgbG9vayBhIGJpdCBmdW5ueSB0byBtZSA6
LSkKCkZlZWwgZnJlZSB0byBpZ25vcmUgdGhlIGJpa2VzaGVkLgoKQ2hlZXJzLCBEYW5pZWwKCj4g
K3sKPiArCXJldHVybiBSRUFEX09OQ0UoY29ubmVjdG9yLT5yZWdpc3RyYXRpb25fc3RhdGUpID09
Cj4gKwkJRFJNX0NPTk5FQ1RPUl9VTlJFR0lTVEVSRUQ7Cj4gK30KPiArCj4gIGNvbnN0IGNoYXIg
KmRybV9nZXRfY29ubmVjdG9yX3N0YXR1c19uYW1lKGVudW0gZHJtX2Nvbm5lY3Rvcl9zdGF0dXMg
c3RhdHVzKTsKPiAgY29uc3QgY2hhciAqZHJtX2dldF9zdWJwaXhlbF9vcmRlcl9uYW1lKGVudW0g
c3VicGl4ZWxfb3JkZXIgb3JkZXIpOwo+ICBjb25zdCBjaGFyICpkcm1fZ2V0X2RwbXNfbmFtZShp
bnQgdmFsKTsKPiAtLSAKPiAyLjE3LjIKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu
Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs
aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz
a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK