From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Patch v4 5/8] drm/omap: Add global state as a private atomic object Date: Fri, 19 Oct 2018 09:10:12 +0200 Message-ID: <20181019071012.GQ31561@phenom.ffwll.local> References: <20181012201703.29065-1-bparrot@ti.com> <20181012201703.29065-6-bparrot@ti.com> <20181016122946.GU31561@phenom.ffwll.local> <20181018131130.GB1566@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE8E56E1D9 for ; Fri, 19 Oct 2018 07:10:16 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id d15-v6so30483478edq.6 for ; Fri, 19 Oct 2018 00:10:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181018131130.GB1566@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Benoit Parrot Cc: linux-kernel@vger.kernel.org, Jyri Sarha , Peter Ujfalusi , Tomi Valkeinen , dri-devel@lists.freedesktop.org, Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTgsIDIwMTggYXQgMDg6MTE6MzBBTSAtMDUwMCwgQmVub2l0IFBhcnJvdCB3 cm90ZToKPiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+IHdyb3RlIG9uIFR1ZSBbMjAx OC1PY3QtMTYgMTQ6Mjk6NDYgKzAyMDBdOgo+ID4gT24gRnJpLCBPY3QgMTIsIDIwMTggYXQgMDM6 MTc6MDBQTSAtMDUwMCwgQmVub2l0IFBhcnJvdCB3cm90ZToKPiA+ID4gR2xvYmFsIHNoYXJlZCBy ZXNvdXJjZXMgKGxpa2UgaHcgb3ZlcmxheXMpIGZvciBvbWFwZHJtIGFyZSBpbXBsZW1lbnRlZAo+ ID4gPiBhcyBhIHBhcnQgb2YgYXRvbWljIHN0YXRlIHVzaW5nIHRoZSBkcm1fcHJpdmF0ZV9vYmog aW5mcmFzdHJ1Y3R1cmUKPiA+ID4gYXZhaWxhYmxlIGluIHRoZSBhdG9taWMgY29yZS4KPiA+ID4g Cj4gPiA+IG9tYXBfZ2xvYmFsX3N0YXRlIGlzIGludHJvZHVjZWQgYXMgYSBkcm0gYXRvbWljIHBy aXZhdGUgb2JqZWN0LiBUaGUgdHdvCj4gPiA+IGZ1bmNzIG9tYXBfZ2V0X2dsb2JhbF9zdGF0ZSgp IGFuZCBvbWFwX2dldF9leGlzdGluZ19nbG9iYWxfc3RhdGUoKSBhcmUKPiA+ID4gdGhlIHR3byB2 YXJpYW50cyB0aGF0IHdpbGwgYmUgdXNlZCB0byBhY2Nlc3Mgb21hcF9nbG9iYWxfc3RhdGUuCj4g PiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBCZW5vaXQgUGFycm90IDxicGFycm90QHRpLmNvbT4K PiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jIHwgOTcg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiA+ID4gIGRyaXZlcnMvZ3B1 L2RybS9vbWFwZHJtL29tYXBfZHJ2LmggfCAyMyArKysrKysrKysKPiA+ID4gIDIgZmlsZXMgY2hh bmdlZCwgMTE5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gCj4gPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jIGIvZHJpdmVycy9ncHUv ZHJtL29tYXBkcm0vb21hcF9kcnYuYwo+ID4gPiBpbmRleCAyOTIxY2M5MGYyZDguLjk0NjU4ZWM3 OWM3NiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYu Ywo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jCj4gPiA+IEBA IC0xMjksNiArMTI5LDk0IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfY29uZmlnX2Z1 bmNzIG9tYXBfbW9kZV9jb25maWdfZnVuY3MgPSB7Cj4gPiA+ICAJLmF0b21pY19jb21taXQgPSBk cm1fYXRvbWljX2hlbHBlcl9jb21taXQsCj4gPiA+ICB9Owo+ID4gPiAgCj4gPiA+ICsvKiBHbG9i YWwvc2hhcmVkIG9iamVjdCBzdGF0ZSBmdW5jcyAqLwo+ID4gPiArCj4gPiA+ICsvKgo+ID4gPiAr ICogVGhpcyBpcyBhIGhlbHBlciB0aGF0IHJldHVybnMgdGhlIHByaXZhdGUgc3RhdGUgY3VycmVu dGx5IGluIG9wZXJhdGlvbi4KPiA+ID4gKyAqIE5vdGUgdGhhdCB0aGlzIHdvdWxkIHJldHVybiB0 aGUgIm9sZF9zdGF0ZSIgaWYgY2FsbGVkIGluIHRoZSBhdG9taWMgY2hlY2sKPiA+ID4gKyAqIHBh dGgsIGFuZCB0aGUgIm5ld19zdGF0ZSIgYWZ0ZXIgdGhlIGF0b21pYyBzd2FwIGhhcyBiZWVuIGRv bmUuCj4gPiA+ICsgKi8KPiA+ID4gK3N0cnVjdCBvbWFwX2dsb2JhbF9zdGF0ZSAqCj4gPiA+ICtv bWFwX2dldF9leGlzdGluZ19nbG9iYWxfc3RhdGUoc3RydWN0IG9tYXBfZHJtX3ByaXZhdGUgKnBy aXYpCj4gPiA+ICt7Cj4gPiA+ICsJcmV0dXJuIHRvX29tYXBfZ2xvYmFsX3N0YXRlKHByaXYtPmds b2Jfb2JqLnN0YXRlKTsKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiArLyoKPiA+ID4gKyAqIFRoaXMg YWNxdWlyZXMgdGhlIG1vZGVzZXQgbG9jayBzZXQgYXNpZGUgZm9yIGdsb2JhbCBzdGF0ZSwgY3Jl YXRlcwo+ID4gPiArICogYSBuZXcgZHVwbGljYXRlZCBwcml2YXRlIG9iamVjdCBzdGF0ZS4KPiA+ ID4gKyAqLwo+ID4gPiArc3RydWN0IG9tYXBfZ2xvYmFsX3N0YXRlICpfX211c3RfY2hlY2sKPiA+ ID4gK29tYXBfZ2V0X2dsb2JhbF9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqcykKPiA+ ID4gK3sKPiA+ID4gKwlzdHJ1Y3Qgb21hcF9kcm1fcHJpdmF0ZSAqcHJpdiA9IHMtPmRldi0+ZGV2 X3ByaXZhdGU7Cj4gPiA+ICsJc3RydWN0IGRybV9wcml2YXRlX3N0YXRlICpwcml2X3N0YXRlOwo+ ID4gPiArCWludCByZXQ7Cj4gPiA+ICsKPiA+ID4gKwlpZiAoIWRybV9tb2Rlc2V0X2lzX2xvY2tl ZCgmcHJpdi0+Z2xvYl9vYmpfbG9jaykpIHsKPiA+ID4gKwkJcmV0ID0gZHJtX21vZGVzZXRfbG9j aygmcHJpdi0+Z2xvYl9vYmpfbG9jaywgcy0+YWNxdWlyZV9jdHgpOwo+ID4gPiArCQlpZiAocmV0 KSB7Cj4gPiA+ICsJCQlEQkcoImdldHRpbmcgcHJpdi0+Z2xvYl9vYmpfbG9jayAoJXApIGZhaWxl ZCAlZCIsCj4gPiA+ICsJCQkgICAgJnByaXYtPmdsb2Jfb2JqX2xvY2ssIHJldCk7Cj4gPiA+ICsJ CQlyZXR1cm4gRVJSX1BUUihyZXQpOwo+ID4gPiArCQl9Cj4gPiA+ICsJfQo+ID4gPiArCj4gPiA+ ICsJcHJpdl9zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X3ByaXZhdGVfb2JqX3N0YXRlKHMsICZwcml2 LT5nbG9iX29iaik7Cj4gPiAKPiA+IE9uZSBvZiB0aGUgcmVmYWN0b3JzIEkgaGFkIGluIG1pbmQg KGFuZCB3aGljaCB3b3VsZCBiZSBwb3NzaWJsZSBub3cgdGhhdAo+ID4gcHJpdmF0ZSBzdGF0ZSBz dHJ1Y3RzIGFyZSBpbXBsZW1lbnRlZCBhcyBwcm9wZXJseSBzdHJ1Y3RzLCBpbnN0ZWFkIG9mIHZv aWQKPiA+ICogcG9pbnRlcnMpOiBBZGQgYSBkcm1fbW9kZXNldF9sb2NrIHRvIGRybV9wcml2YXRl X29iaiBhbmQgYXZvaWQgaGF2aW5nIHRvCj4gPiBkdXBsaWNhdGUgdGhhdCBvdmVyIGFsbCBpbXBs ZW1lbnRhdGlvbnMuIE5vdCBldmVyeW9uZSB3YW50cyBhIHBlci1vYmoKPiA+IGxvY2ssIGJ1dCBu byBvbmUgd2lsbCBiZSBodXJ0IGJ5IGhhdmluZyBhIHBlci1vYmogbG9jayAtIGRybV9tb2Rlc2V0 X2xvY2sKPiA+IGlzIHZlcnkgZXh0ZW5zaWJsZSBpbiB0aGF0IHdheS4gQW5kIHdlIGNvdWxkIGRy b3AgdGhlIGN1c3RvbSBsb2NraW5nIGNvZGUKPiA+IGV2ZXJ5b25lIGhhcyB0byByb2xsIHRoZW1z ZWx2ZXMuCj4gCj4gVGhhbmtzIGZvciB0aGUgZmVlZGJhY2suIEkgd2FzIHdvbmRlcmluZyB0aGUg c2FtZSB3aGVuIEkgd2FzICJkdXBsaWNhdGluZyIKPiB0aGlzIGNvZGUuIEkgd2lsbCB0YWtlIHRo aXMgdW5kZXIgYWR2aXNlbWVudCwgYnV0IEkgd291bGQgcHJvYmFibHkgc2VlIHRoYXQKPiBhcyBh IHNlcGFyYXRlIHBhdGNoIHNldCwgZWl0aGVyIGJlZm9yZSBvciBhZnRlciB0aGlzIG9uZSA6KSAK ClN1cmUuIEFsc28gbm90ZSB0aGF0IHRoaXMgY2FtZSB1cCB3aXRoIGEgcmVjZW50IHZjNCBwYXRj aCBzZXJpZXMgYnkgQm9yaXMKQnJlemlsbGlvbiAiW1JGQyBQQVRDSF0gZHJtL3ZjNDogQWRkIGEg bG9hZCB0cmFja2VyIHRvIHByZXZlbnQgSFZTCnVuZGVyZmxvdyBlcnJvcnMiLCBzbyBtYXliZSB5 b3UgZm9sa3MgY2FuIHdvcmsgdG9nZXRoZXIuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=