From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 1/3] drm/atomic: Add a generic infrastructure to track underrun errors Date: Fri, 26 Oct 2018 15:36:15 +0200 Message-ID: <20181026133615.GN21967@phenom.ffwll.local> References: <20181025124546.22145-1-boris.brezillon@bootlin.com> <20181025124546.22145-2-boris.brezillon@bootlin.com> <20181026103337.GJ21967@phenom.ffwll.local> <20181026143656.43fec345@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46F866E471 for ; Fri, 26 Oct 2018 13:36:19 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id r1-v6so1306130edd.7 for ; Fri, 26 Oct 2018 06:36:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181026143656.43fec345@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBPY3QgMjYsIDIwMTggYXQgMDI6MzY6NTZQTSArMDIwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOgo+IEhpIERhbmllbCwKPiAKPiBPbiBGcmksIDI2IE9jdCAyMDE4IDEyOjMzOjM3ICsw MjAwCj4gRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90ZToKPiAKPiA+IE9uIFRo dSwgT2N0IDI1LCAyMDE4IGF0IDAyOjQ1OjQ0UE0gKzAyMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90 ZToKPiA+ID4gRGlzcGxheSBjb250cm9sbGVycyB1c3VhbGx5IHByb3ZpZGUgYSBsb3QgZmVhdHVy ZXMgbGlrZSBvdmVybGF5IHBsYW5lcywKPiA+ID4gaGFyZHdhcmUgc2NhbGVycywgaGFyZHdhcmUg cm90YXRpb25zLCAuLi4KPiA+ID4gTW9zdCBvZiB0aGUgdGltZSB0aG9zZSBmZWF0dXJlcyB3b3Jr IGp1c3QgZmluZSB3aGVuIGVuYWJsZWQKPiA+ID4gaW5kZXBlbmRlbnRseSwgYnV0IGFjdGl2YXRp bmcgYWxsIG9mIHRoZW0gYXQgdGhlIHNhbWUgdGltZSB0ZW5kIHRvCj4gPiA+IHNob3cgb3RoZXIg bGltaXRhdGlvbnMgbGlrZSB0aGUgbGltaXRlZCBtZW1vcnkgYnVzIG9yIHNjYWxlcgo+ID4gPiBi YW5kd2lkdGguCj4gPiA+IAo+ID4gPiBUaGlzIHNvcnQgb2YgYmFuZHdpZHRoIGVzdGltYXRpb24g aXMgaGFyZCB0byBnZXQgcmlnaHQsIGFuZCB3ZQo+ID4gPiBzb21ldGltZXMgZmFpbCB0byBwcmVk aWN0IHRoYXQgYSBzcGVjaWZpYyB3b3JrbG9hZCB3aWxsIG5vdCBwYXNzLAo+ID4gPiB3aGljaCB3 aWxsIG1vc3QgbGlrZWx5IHJlc3VsdCBpbiB1bmRlcnJ1biBlcnJvcnMgc29tZXdoZXJlIGluIHRo ZQo+ID4gPiBkaXNwbGF5IHBpcGVsaW5lIChtb3N0IG9mIHRoZSB0aW1lIGF0IHRoZSBDUlRDIGxl dmVsKS4KPiA+ID4gCj4gPiA+IFRoaXMgcGF0aCBhaW1zIGF0IG1ha2luZyB1bmRlcnJ1biBlcnJv ciB0cmFja2luZyBnZW5lcmljIGFuZCBleHBvc2luZwo+ID4gPiB1bmRlcnJ1biBlcnJvcnMgdG8g dXNlcnNwYWNlIHRocm91Z2ggYSBkZWJ1Z2ZzIGZpbGUuCj4gPiA+IAo+ID4gPiBUaGlzIHdheSwg Q0kgdG9vbHMgbGlrZSBJR1QsIGNhbiB0cnkgdG8gZW5hYmxlIGEgYnVuY2ggb2YgZmVhdHVyZXMg YW5kCj4gPiA+IGlmIHN1Y2ggdW5kZXJydW4gZXJyb3JzIGFyZSByZXBvcnRlZCBhZnRlciB0aGUg c2V0dGluZ3MgaGF2ZSBiZWVuCj4gPiA+IGFjY2VwdGVkIGFuZCBhcHBsaWVkIGJ5IHRoZSBLTVMg aW5mcmFzdHJ1Y3R1cmUuIFdoZW4gdGhhdCBoYXBwZW5zIGl0Cj4gPiA+IG1lYW5zIHRoZSBsb2Fk IHRyYWNraW5nIGFsZ29yaXRobSBuZWVkcyBzb21lIHR3ZWFraW5nL2ZpeGluZy4KPiA+ID4gCj4g PiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3Rs aW4uY29tPgo+ID4gPiAtLS0KPiA+ID4gQ2hhbmdlcyBpbiB2MjoKPiA+ID4gLSBOZXcgcGF0Y2gg IAo+ID4gCj4gPiBIbSwgbm90IHdoYXQgSSB0aG91Z2h0IG9mZi4gVGhpcyBpcyBkZWZpbml0ZWx5 IG5vdCBnb2luZyB0byBiZSByZXVzYWJsZQo+ID4gZm9yIGk5MTUsIHRoZSBvbmx5IG90aGVyIGRy aXZlciB3aXRoIHVuZGVycnVuIHJlcG9ydGluZywgc2luY2Ugd2UgaGF2ZQo+ID4gdG9ucyBvZiB1 bmRlcnJ1biBzb3VyY2VzIChub3QganVzdCBvbmUpLiBBbmQgd2UgbmVlZCB0byBtYXNrL3VubWFz ayB0aGVtCj4gPiBpbmRpdmlkdWFsbHkuCj4gCj4gSSBhZ3JlZSBpdCdzIG5vdCBwZXJmZWN0LCBi dXQgSSBkaWQgaXQgdGhpcyB3YXkgc28gdGhhdCBob3BlZnVsbHkgd2UnbGwKPiBiZSBhYmxlIHRv IHVzZSBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfdGFpbCgpIGF0IHNvbWUgcG9pbnQgaW5zdGVh ZCBvZgo+IGhhdmluZyBvdXIgb3duIGltcGxlbWVudGF0aW9uLgoKSSBleHBlY3QgZXZlcnkgbm9u LXRyaXZpYWwgZHJpdmVyIHRvIG5lZWQgdG8gb3ZlcndyaXRlIGNvbW1pdF90YWlsLiBUaGF0J3MK dGhlIGVudGlyZSBwb2ludCBmb3IgaGF2aW5nIGNyZWF0ZWQgaXQuIEV4Y2VwdGlvbnMgYXJlIGp1 c3QgdGhlIHZlcnksIHZlcnkKc2ltcGxlIG9uZXMgd2l0aG91dCBhbnl0aGluZyBmYW5jeS4KCj4g SWYgdGhlcmUncyBhIHdheSB0byBhZGQgcHJlL3Bvc3RfY29tbWl0KCkgaG9va3MgKG1heWJlIHRo ZXkgYWxyZWFkeQo+IGV4aXN0PykgYXQgdmFyaW91cyBsZXZlbHMgb2YgdGhlIGRpc3BsYXkgcGlw ZWxpbmUgdGhhdCBnZXQgY2FsbGVkIGV2ZW4KPiB3aGVuIHRoZSBhc3NvY2lhdGVkIHN0YXRlIGhh cyAqbm90KiBjaGFuZ2VkLCB0aGVuIEkgbWlnaHQgYmUgYWJsZSB0bwo+IHBsYWNlIG15IG1hc2sv dW5tYXNrL2NsZWFyIG9wZXJhdGlvbnMgdGhlcmUuIEkgcmVhbGx5IG5lZWQgdGhhdCB0bwo+IHBy b3Blcmx5IHVubWFzayB0aGUgdW5kZXJydW4gaW50ZXJydXB0LCBvdGhlcndpc2UgdW5kZXJydW5z IG1pZ2h0IG5vdCBiZQo+IGRldGVjdGVkIGFmdGVyIHRoZSBmaXJzdCBtb2Rlc2V0IGlmIG5vdGhp bmcgY2hhbmdlZCBpbiBzdWItcGFydHMgb2YgdGhlCj4gcGlwZWxpbmUuCgpKdXN0IG92ZXJ3cml0 ZSBjb21taXRfdGFpbC4gVGhhdCdzIHdoeSBpdCBleGlzdHMuCgo+ID4gSXQncyBhbHNvIG1pZGxh eWVyIG1pc3Rha2UsIHNpbmNlIHlvdSdyZSBzdHVmZiB5b3VyIGNhbGxiYWNrcyBpbnRvIHRoZQo+ ID4gZHJtX21vZGVfY29uZmlnX2Z1bmNzIGNvcmUgc3RydWN0dXJlICh3aGljaCBzaG91bGQgb25s eSBiZSB1c2VkIGZvciB1YXBpCj4gPiBpbnRlcmZhY2VzLCBub3QgaGVscGVyIHN0dWZmKS4KPiAK PiBPa2F5Lgo+IAo+ID4gCj4gPiBXaGF0IEkgaGFkIGluIG1pbmQgaXMganVzdCBhIHNpbXBsZSBm dW5jdGlvbiB3aGljaCBzcGV3cyBpbnRvIGRtZXNnIChzbwo+ID4gdGhhdCBpOTE1IGNvdWxkIHVz ZSBpdCkgYW5kIGluY3JlbWVudHMgdGhlIHVuZGVycnVuIGNvdW50ZXIgaW4gZGVidWdmcy4KPiA+ IEV2ZXJ5dGhpbmcgZWxzZSBuZWVkcyB0byBiZSBoYW5kbGVkIGluIGRyaXZlcnMgSSB0aGluay4g RS5nLgo+ID4gCj4gPiBkcm1fbW9kZV9jb25maWdfcmVwb3J0X3VuZGVycnVuKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gPiAJCQkJY29uc3QgY2hhciAqc291cmNlKTsKPiA+IAo+ID4gYW5kIHRo ZW4gcm9sbGluZyBpdCBvdXQgZm9yIGk5MTUgdG9vIChvdGhlcndpc2UgdGhlcmUncyByZWFsbHkg bm8gcG9pbnQgaW4KPiA+IHRoZSBjb21tb24gaW5mcmFzdHJ1Y3R1cmUpLgo+IAo+IE1vZGlmeWlu ZyB0aGUgaTkxNSBkcml2ZXIgd2FzIGEgYml0IHByZW1hdHVyZSBzaW5jZSBJIGRpZG4ndCBoYXZl IHlvdXIKPiBmZWVkYmFjayBvbiB0aGUgZ2VuZXJhbCBhcHByb2FjaC4gQW5kIGdpdmVuIHlvdXIg cmV2aWV3LCBJJ20gZ2xhZCBJCj4gZGlkbid0IHN0YXJ0IHRoaXMgY29udmVyc2lvbiA6LVAuCj4g Cj4gQW55d2F5LCBJIHdhcyBub3QgY29udmluY2VkIGhhdmluZyBhIGdlbmVyaWMgaW5mcmFzdHJ1 Y3R1cmUgdG8gcmVwb3J0Cj4gdW5kZXJydW4gZXJyb3JzIHdhcyBuZWVkZWQgaW4gdGhlIGZpcnN0 IHBsYWNlLiBUaGUgZmFjdCB0aGF0IHRoZXNlCj4gZXJyb3JzIGFyZSB2ZXJ5IEhXLXNwZWNpZmlj LCBhbmQgdGhhdCBkYXRhIGF0dGFjaGVkIHRvIHN1Y2ggZXZlbnRzCj4gbWlnaHQgYmUgdXNlZnVs IHRvIHVuZGVyc3RhbmQgd2hhdCBhY3R1YWxseSBoYXBwZW5lZCBtYWtlcyBtZSB0aGluayB3ZQo+ IGRvbid0IHJlYWxseSBuZWVkIHRoaXMgZ2VuZXJpYyB1bmRlcnJ1biByZXBvcnRpbmcgaGVscGVy Lgo+IAo+IEFsc28gbm90ZSB0aGF0IElHVCB0ZXN0cyBhcmUgbGlrZWx5IHRvIGJlIEhXIHNwZWNp ZmljIHRvbywgYmVjYXVzZSB0aGUKPiB3b3JrbG9hZCBuZWVkZWQgdG8gdHJpZ2dlciB1bmRlcnJ1 biBlcnJvcnMgaXMgbGlrZWx5IHRvIGRlcGVuZCBvbiB0aGUKPiBwbGF0Zm9ybSB5b3UncmUgcnVu bmluZyBvbi4gQW5kIGlmIHlvdSBhbHJlYWR5IGhhdmUgdG8gd3JpdGUgeW91ciBvd24KPiB0ZXN0 cywgSSBkb24ndCBzZWUgY2xlYXIgYmVuZWZpdCBpbiBleHBvc2luZyB1bmRlcnJ1biBlcnJvcnMK PiBnZW5lcmljYWxseS4KClNlZSBteSBvdGhlciByZXBseSBpbiB0aGUgZWFybGllciB0aHJlYWQ6 IFRoYXQncyB3aHkgd2UncmUganVzdCBkdW1waW5nCmVycm9ycyBpbnRvIGRtZXNnLCBhbmQgY2F0 Y2hpbmcgYW55IHN1Y2ggdGhpbmcgaW4gb3VyIHJ1bm5lcnMuIFdlIGRvIG5vdApoYXZlIGFueSBz cGVjaWZpYyB1bmRlcnJ1biB0ZXN0cywgd2UgdHJlYXQgdGhlIGVudGlyZSBpZ3QgdGVzdCBzdWl0 ZSBvZgprbXMgdGVzdHMgYXMgb3VyIHVuZGVycnVuIHRlc3Qgc3VpdGUuCgpFeHRlbmRpbmcgdGhh dCB3aXRoIG1vcmUgbmFzdHkgY29ybmVyIGNhc2VzIGlzIG9idmlvdXNseSBncmVhdCwgYW5kIHdp bGwKYmVuZWZpdCBldmVyeW9uZS4gQnV0IEkgZG9uJ3QgdGhpbmsgeW91IHdhbnQgYW4gaWd0IHRl c3RjYXNlIHRoYXQgbG9va3MKc3BlY2lmaWNhbGx5IGZvciB1bmRlcnJ1bnMuIFdlIGRvIHVzZSBj cmMgdG8gaHVudCBmb3Igc3BlY2lmaWMgaXNzdWVzLCBidXQKYWdhaW4gdGhhdCdzIHBvcnRhYmxl IGJldHdlZW4gZHJpdmVycy4KCj4gQW55d2F5LCB0aGlzIGlzIGp1c3QgbXkgb3BpbmlvbiwgYW5k IGlmIHlvdSB0aGluayB3ZSBhY3R1YWxseSBuZWVkIHRoZQo+IGRybV9tb2RlX2NvbmZpZ19yZXBv cnRfdW5kZXJydW4oKSBmdW5jdGlvbiwgSSdsbCBpbXBsZW1lbnQgaXQuCgpJIGRvIHRoaW5rIGhh dmluZyBzb21lIHN0YW5kYXJkIGluIGhvdyB0aGVzZSBlcnJvcnMgYXJlIHJlcG9ydGVkIHdvdWxk IGJlCnVzZWZ1bCwgZXZlbiBpZiBpdCdzIGp1c3QgYSBzcGVjaWFsIERSTV9VTkRFUlJVTl9FUlJP UigpIG1hY3JvLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK