From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/3] drm/atomic: Use explicit old/new state in drm_atomic_crtc_check() Date: Mon, 5 Nov 2018 10:29:11 +0100 Message-ID: <20181105092911.GG21967@phenom.ffwll.local> References: <20181101184646.14753-1-ville.syrjala@linux.intel.com> <20181101184646.14753-2-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C01E6E013 for ; Mon, 5 Nov 2018 09:29:15 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id a14-v6so2672770edr.7 for ; Mon, 05 Nov 2018 01:29:15 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181101184646.14753-2-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMDEsIDIwMTggYXQgMDg6NDY6NDVQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IENvbnZlcnQgZHJtX2F0b21pY19jcnRjX2NoZWNrKCkgb3ZlciB0byB1c2luZyBl eHBsaWNpdCBvbGQgdnMuIG5ldwo+IGNydGMgc3RhdGVzLiBBdm9pZHMgdGhlIGNvbmZ1c2lvbiBv ZiAid2hhdCBkb2VzIGNydGMtPnN0YXRlIG1lYW4KPiBhZ2Fpbj8iLgoKWWVhaCBtdWNoIGJldHRl ci4KCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVy QGZmd2xsLmNoPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8IDI2ICsr KysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25z KCspLCAxMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBpbmRleCAwNjRjNDgw NzU5MTcuLmRkZTY5NjE4MWVmZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IEBAIC0zMTUsOSAr MzE1LDExIEBAIGRybV9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlLAo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19nZXRfY3J0Y19zdGF0 ZSk7Cj4gIAo+IC1zdGF0aWMgaW50IGRybV9hdG9taWNfY3J0Y19jaGVjayhzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMsCj4gLQkJc3RydWN0IGRybV9jcnRjX3N0YXRlICpzdGF0ZSkKPiArc3RhdGljIGlu dCBkcm1fYXRvbWljX2NydGNfY2hlY2soY29uc3Qgc3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRf Y3J0Y19zdGF0ZSwKPiArCQkJCSBjb25zdCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm5ld19jcnRj X3N0YXRlKQo+ICB7Cj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBuZXdfY3J0Y19zdGF0ZS0+ Y3J0YzsKPiArCj4gIAkvKiBOT1RFOiB3ZSBleHBsaWNpdGx5IGRvbid0IGVuZm9yY2UgY29uc3Ry YWludHMgc3VjaCBhcyBwcmltYXJ5Cj4gIAkgKiBsYXllciBjb3ZlcmluZyBlbnRpcmUgc2NyZWVu LCBzaW5jZSB0aGF0IGlzIHNvbWV0aGluZyB3ZSB3YW50Cj4gIAkgKiB0byBhbGxvdyAob24gaHcg dGhhdCBzdXBwb3J0cyBpdCkuICBGb3IgaHcgdGhhdCBkb2VzIG5vdCwgaXQKPiBAQCAtMzI2LDcg KzMyOCw3IEBAIHN0YXRpYyBpbnQgZHJtX2F0b21pY19jcnRjX2NoZWNrKHN0cnVjdCBkcm1fY3J0 YyAqY3J0YywKPiAgCSAqIFRPRE86IEFkZCBnZW5lcmljIG1vZGVzZXQgc3RhdGUgY2hlY2tzIG9u Y2Ugd2Ugc3VwcG9ydCB0aG9zZS4KPiAgCSAqLwo+ICAKPiAtCWlmIChzdGF0ZS0+YWN0aXZlICYm ICFzdGF0ZS0+ZW5hYmxlKSB7Cj4gKwlpZiAobmV3X2NydGNfc3RhdGUtPmFjdGl2ZSAmJiAhbmV3 X2NydGNfc3RhdGUtPmVuYWJsZSkgewo+ICAJCURSTV9ERUJVR19BVE9NSUMoIltDUlRDOiVkOiVz XSBhY3RpdmUgd2l0aG91dCBlbmFibGVkXG4iLAo+ICAJCQkJIGNydGMtPmJhc2UuaWQsIGNydGMt Pm5hbWUpOwo+ICAJCXJldHVybiAtRUlOVkFMOwo+IEBAIC0zMzYsMTQgKzMzOCwxNCBAQCBzdGF0 aWMgaW50IGRybV9hdG9taWNfY3J0Y19jaGVjayhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkg KiBhcyB0aGlzIGlzIGEga2VybmVsLWludGVybmFsIGRldGFpbCB0aGF0IHVzZXJzcGFjZSBzaG91 bGQgbmV2ZXIKPiAgCSAqIGJlIGFibGUgdG8gdHJpZ2dlci4gKi8KPiAgCWlmIChkcm1fY29yZV9j aGVja19mZWF0dXJlKGNydGMtPmRldiwgRFJJVkVSX0FUT01JQykgJiYKPiAtCSAgICBXQVJOX09O KHN0YXRlLT5lbmFibGUgJiYgIXN0YXRlLT5tb2RlX2Jsb2IpKSB7Cj4gKwkgICAgV0FSTl9PTihu ZXdfY3J0Y19zdGF0ZS0+ZW5hYmxlICYmICFuZXdfY3J0Y19zdGF0ZS0+bW9kZV9ibG9iKSkgewo+ ICAJCURSTV9ERUJVR19BVE9NSUMoIltDUlRDOiVkOiVzXSBlbmFibGVkIHdpdGhvdXQgbW9kZSBi bG9iXG4iLAo+ICAJCQkJIGNydGMtPmJhc2UuaWQsIGNydGMtPm5hbWUpOwo+ICAJCXJldHVybiAt RUlOVkFMOwo+ICAJfQo+ICAKPiAgCWlmIChkcm1fY29yZV9jaGVja19mZWF0dXJlKGNydGMtPmRl diwgRFJJVkVSX0FUT01JQykgJiYKPiAtCSAgICBXQVJOX09OKCFzdGF0ZS0+ZW5hYmxlICYmIHN0 YXRlLT5tb2RlX2Jsb2IpKSB7Cj4gKwkgICAgV0FSTl9PTighbmV3X2NydGNfc3RhdGUtPmVuYWJs ZSAmJiBuZXdfY3J0Y19zdGF0ZS0+bW9kZV9ibG9iKSkgewo+ICAJCURSTV9ERUJVR19BVE9NSUMo IltDUlRDOiVkOiVzXSBkaXNhYmxlZCB3aXRoIG1vZGUgYmxvYlxuIiwKPiAgCQkJCSBjcnRjLT5i YXNlLmlkLCBjcnRjLT5uYW1lKTsKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiBAQCAtMzU5LDcgKzM2 MSw4IEBAIHN0YXRpYyBpbnQgZHJtX2F0b21pY19jcnRjX2NoZWNrKHN0cnVjdCBkcm1fY3J0YyAq Y3J0YywKPiAgCSAqIGFuZCBsZWdhY3kgcGFnZV9mbGlwIElPQ1RMIHdoaWNoIGFsc28gcmVqZWN0 IHNlcnZpY2Ugb24gYSBkaXNhYmxlZAo+ICAJICogcGlwZS4KPiAgCSAqLwo+IC0JaWYgKHN0YXRl LT5ldmVudCAmJiAhc3RhdGUtPmFjdGl2ZSAmJiAhY3J0Yy0+c3RhdGUtPmFjdGl2ZSkgewo+ICsJ aWYgKG5ld19jcnRjX3N0YXRlLT5ldmVudCAmJgo+ICsJICAgICFuZXdfY3J0Y19zdGF0ZS0+YWN0 aXZlICYmICFvbGRfY3J0Y19zdGF0ZS0+YWN0aXZlKSB7Cj4gIAkJRFJNX0RFQlVHX0FUT01JQygi W0NSVEM6JWQ6JXNdIHJlcXVlc3RpbmcgZXZlbnQgYnV0IG9mZlxuIiwKPiAgCQkJCSBjcnRjLT5i YXNlLmlkLCBjcnRjLT5uYW1lKTsKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiBAQCAtOTY1LDcgKzk2 OCw4IEBAIGludCBkcm1fYXRvbWljX2NoZWNrX29ubHkoc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlKQo+ICAJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gIAlzdHJ1Y3QgZHJtX3BsYW5l X3N0YXRlICpwbGFuZV9zdGF0ZTsKPiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiAtCXN0cnVj dCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq b2xkX2NydGNfc3RhdGU7Cj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRl Owo+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm47Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rv cl9zdGF0ZSAqY29ubl9zdGF0ZTsKPiAgCWludCBpLCByZXQgPSAwOwo+IEBAIC05ODEsOCArOTg1 LDggQEAgaW50IGRybV9hdG9taWNfY2hlY2tfb25seShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAq c3RhdGUpCj4gIAkJfQo+ICAJfQo+ICAKPiAtCWZvcl9lYWNoX25ld19jcnRjX2luX3N0YXRlKHN0 YXRlLCBjcnRjLCBjcnRjX3N0YXRlLCBpKSB7Cj4gLQkJcmV0ID0gZHJtX2F0b21pY19jcnRjX2No ZWNrKGNydGMsIGNydGNfc3RhdGUpOwo+ICsJZm9yX2VhY2hfb2xkbmV3X2NydGNfaW5fc3RhdGUo c3RhdGUsIGNydGMsIG9sZF9jcnRjX3N0YXRlLCBuZXdfY3J0Y19zdGF0ZSwgaSkgewo+ICsJCXJl dCA9IGRybV9hdG9taWNfY3J0Y19jaGVjayhvbGRfY3J0Y19zdGF0ZSwgbmV3X2NydGNfc3RhdGUp Owo+ICAJCWlmIChyZXQpIHsKPiAgCQkJRFJNX0RFQlVHX0FUT01JQygiW0NSVEM6JWQ6JXNdIGF0 b21pYyBjb3JlIGNoZWNrIGZhaWxlZFxuIiwKPiAgCQkJCQkgY3J0Yy0+YmFzZS5pZCwgY3J0Yy0+ bmFtZSk7Cj4gQEAgLTEwMTAsOCArMTAxNCw4IEBAIGludCBkcm1fYXRvbWljX2NoZWNrX29ubHko c3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICAJfQo+ICAKPiAgCWlmICghc3RhdGUt PmFsbG93X21vZGVzZXQpIHsKPiAtCQlmb3JfZWFjaF9uZXdfY3J0Y19pbl9zdGF0ZShzdGF0ZSwg Y3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+IC0JCQlpZiAoZHJtX2F0b21pY19jcnRjX25lZWRzX21v ZGVzZXQoY3J0Y19zdGF0ZSkpIHsKPiArCQlmb3JfZWFjaF9uZXdfY3J0Y19pbl9zdGF0ZShzdGF0 ZSwgY3J0YywgbmV3X2NydGNfc3RhdGUsIGkpIHsKPiArCQkJaWYgKGRybV9hdG9taWNfY3J0Y19u ZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRlKSkgewo+ICAJCQkJRFJNX0RFQlVHX0FUT01JQygi W0NSVEM6JWQ6JXNdIHJlcXVpcmVzIGZ1bGwgbW9kZXNldFxuIiwKPiAgCQkJCQkJIGNydGMtPmJh c2UuaWQsIGNydGMtPm5hbWUpOwo+ICAJCQkJcmV0dXJuIC1FSU5WQUw7Cj4gLS0gCj4gMi4xOC4x Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBk cmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==