From mboxrd@z Thu Jan  1 00:00:00 1970
From: Manasi Navare <manasi.d.navare@intel.com>
Subject: Re: [v6 1/4] i915/dp/fec: Add fec_enable to the crtc
 state.
Date: Mon, 5 Nov 2018 16:36:45 -0800
Message-ID: <20181106003645.GA3828@intel.com>
References: <20181105233150.1972-1-anusha.srivatsa@intel.com>
 <20181105233150.1972-2-anusha.srivatsa@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20181105233150.1972-2-anusha.srivatsa@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gTW9uLCBOb3YgMDUsIDIwMTggYXQgMDM6MzE6NDdQTSAtMDgwMCwgQW51c2hhIFNyaXZhdHNh
IHdyb3RlOgo+IEZvciBEUCAxLjQgYW5kIGFib3ZlLCBEaXNwbGF5IFN0cmVhbSBjb21wcmVzc2lv
biBjYW4gYmUKPiBlbmFibGVkIG9ubHkgaWYgRm9yd2FyZCBFcnJvciBDb3JyZWN0aW4gY2FuIGJl
IHBlcmZvcm1lZC4KPiAKPiBBZGQgYSBjcnRjIHN0YXRlIGZvciBGRUMuIEN1cnJlbnRseSwgdGhl
IHN0YXRlCj4gaXMgZGV0ZXJtaW5lZCBieSBwbGF0Zm9ybSwgRFAgYW5kIERTQyBiZWluZwo+IGVu
YWJsZWQuIE1vdmluZyBmb3J3YXJkIHdlIGNhbiB1c2UgdGhlIHN0YXRlCj4gdG8gaGF2ZSBlcnJv
ciBjb3JyZWN0aW9uIG9uIG90aGVyIHNjZW5hcmlvcyB0b28KPiBpZiBuZWVkZWQuCj4gCj4gdjI6
Cj4gLSBDb250cm9sIGNvbXByZXNzaW9uX2VuYWJsZSB3aXRoIHRoZSBmZWNfZW5hYmxlCj4gcGFy
YW1ldGVyIGluIGNydGMgc3RhdGUgYW5kIHdpdGggaW50ZWxfZHBfc3VwcG9ydHNfZmVjKCkKPiAo
VmlsbGUpCj4gCj4gLSBpbnRlbF9kcF9jYW5fZmVjKCkvaW50ZWxfZHBfc3VwcG9ydHNfZmVjKCko
bWFuYXNpKQo+IAo+IHYzOiBDaGVjayBmb3IgRkVDIHN1cHBvcnQgYWxvbmcgd2l0aCBzZXR0aW5n
IGNydGMgc3RhdGUuCj4gCj4gdjQ6IGFkZCBjaGVja3MgdG8gaW50ZWxfZHBfc291cmNlX3N1cHBv
cnRzX2RzYy4obWFuYXNpKQo+IC0gTW92ZSBpbnRlbF9kcF9zdXBwb3J0c19mZWMoKSBjbG9zZXIg
dG8KPiBpbnRlbF9kcF9zdXBwb3J0c19kc2MoKSAoQW51c2hhKQo+IAo+IFN1Z2dlc3RlZC1ieTog
VmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IGRyaS1k
ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3ly
amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51
eC5pbnRlbC5jb20+Cj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5j
b20+Cj4gU2lnbmVkLW9mZi1ieTogQW51c2hhIFNyaXZhdHNhIDxhbnVzaGEuc3JpdmF0c2FAaW50
ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICB8IDI4ICsr
KysrKysrKysrKysrKysrKysrKysrKystLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZHJ2LmggfCAgMyArKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAzIGRl
bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
cC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDczYzAwYzVhY2Yx
NC4uNjBlMzIzNjYyZWVhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTU0NSw3
ICs1NDUsNyBAQCBpbnRlbF9kcF9tb2RlX3ZhbGlkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25u
ZWN0b3IsCj4gIAkJCWRzY19zbGljZV9jb3VudCA9Cj4gIAkJCQlkcm1fZHBfZHNjX3NpbmtfbWF4
X3NsaWNlX2NvdW50KGludGVsX2RwLT5kc2NfZHBjZCwKPiAgCQkJCQkJCQl0cnVlKTsKPiAtCQl9
IGVsc2Ugewo+ICsJCX0gZWxzZSBpZiAoZHJtX2RwX3Npbmtfc3VwcG9ydHNfZmVjKGludGVsX2Rw
LT5mZWNfY2FwYWJsZSkpIHsKPiAgCQkJZHNjX21heF9vdXRwdXRfYnBwID0KPiAgCQkJCWludGVs
X2RwX2RzY19nZXRfb3V0cHV0X2JwcChtYXhfbGlua19jbG9jaywKPiAgCQkJCQkJCSAgICBtYXhf
bGFuZXMsCj4gQEAgLTE3MTAsMTMgKzE3MTAsMjcgQEAgc3RydWN0IGxpbmtfY29uZmlnX2xpbWl0
cyB7Cj4gIAlpbnQgbWluX2JwcCwgbWF4X2JwcDsKPiAgfTsKPiAgCj4gK3N0YXRpYyBib29sIGlu
dGVsX2RwX3NvdXJjZV9zdXBwb3J0c19mZWMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAr
ewo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBkcF90b19kaWdfcG9y
dChpbnRlbF9kcCk7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19p
OTE1KGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2KTsKPiArCWVudW0gcG9ydCBwb3J0ID0gZGlnX3Bv
cnQtPmJhc2UucG9ydDsKPiArCj4gKwlyZXR1cm4gSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSAm
JiBwb3J0ICE9IFBPUlRfQTsKPiArfQo+ICsKPiArc3RhdGljIGJvb2wgaW50ZWxfZHBfc3VwcG9y
dHNfZmVjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gK3sKPiArCXJldHVybiBpbnRlbF9k
cF9zb3VyY2Vfc3VwcG9ydHNfZmVjKGludGVsX2RwKSAmJgo+ICsJCWRybV9kcF9zaW5rX3N1cHBv
cnRzX2ZlYyhpbnRlbF9kcC0+ZmVjX2NhcGFibGUpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgYm9vbCBp
bnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNfZHNjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4g
IAkJCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiAgewo+
ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZHBfdG9faTkxNShpbnRlbF9k
cCk7Cj4gIAo+IC0JLyogRklYTUU6IEZFQyBuZWVkZWQgZm9yIGV4dGVybmFsIERQIHVudGlsIHRo
ZW4gcmVqZWN0IERTQyBvbiBEUCAqLwo+IC0JaWYgKCFpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHAp
KQo+ICsJaWYgKCFpbnRlbF9kcF9zdXBwb3J0c19mZWMoaW50ZWxfZHApICYmICFpbnRlbF9kcF9p
c19lZHAoaW50ZWxfZHApKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gIAlyZXR1cm4gSU5URUxf
R0VOKGRldl9wcml2KSA+PSAxMCAmJgo+IEBAIC0xODg2LDkgKzE5MDAsMTcgQEAgc3RhdGljIGJv
b2wgaW50ZWxfZHBfZHNjX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAs
Cj4gIAl1MTYgZHNjX21heF9vdXRwdXRfYnBwID0gMDsKPiAgCXU4IGRzY19kcF9zbGljZV9jb3Vu
dCA9IDA7Cj4gIAo+ICsJcGlwZV9jb25maWctPmZlY19lbmFibGUgPSAhaW50ZWxfZHBfaXNfZWRw
KGludGVsX2RwKTsKCmZlY19lbmFibGUgc3RhdGUgYmUgc2V0IGJhc2VkIG9uICFpbnRlbF9kcF9p
c19lZHAoKSAmJiBpbnRlbF9kcF9zdXBwb3J0c19mZWMoKQpCZWNhdXNlIHdlIGVuYWJsZSBmZWMg
aW4gYXRvbWljIG9jbW1pdCBqdXN0IGJhc2VkIG9uIHRoaXMgY3J0Y19zdGF0ZS0+ZmVjX2VuYWJs
ZSBzbwppdCBzaG91bGQgZGVmaW5pdGVseSBiZSBzZXQgYmFzZWQgb24gaW50ZWxfZHBfc3VwcG9y
dHNfZmVjKCkKCj4gKwo+ICAJaWYgKCFpbnRlbF9kcF9zdXBwb3J0c19kc2MoaW50ZWxfZHAsIHBp
cGVfY29uZmlnKSkKPiAgCQlyZXR1cm4gZmFsc2U7Cj4gIAo+ICsJLyogRFNDIG5vdCBzdXBwb3J0
ZWQgaWYgZXh0ZXJuYWwgRFAgc2luayBkb2VzIG5vdCBzdXBwb3J0IEZFQyAqLwo+ICsJaWYgKHBp
cGVfY29uZmlnLT5mZWNfZW5hYmxlICYmICFpbnRlbF9kcF9zdXBwb3J0c19mZWMoaW50ZWxfZHAp
KSB7CgpUaGVuIGhlcmUganVzdCBjaGVjayBmb3IgaWYgKHBpcGVfY29uZmlnLT5mZWNfZW5hYmxl
KQoKTWFuYXNpCgo+ICsJCURSTV9ERUJVR19LTVMoIlNpbmsgZG9lcyBub3Qgc3VwcG9ydCBGb3J3
YXJkIEVycm9yIENvcnJlY3Rpb24sIGRpc2FibGluZyBEaXNwbGF5IENvbXByZXNzaW9uXG4iKTsK
PiArCQlyZXR1cm4gZmFsc2U7Cj4gKwl9Cj4gKwo+ICAJLyogRFNDIG5vdCBzdXBwb3J0ZWQgZm9y
IERTQyBzaW5rIEJQQyA8IDggKi8KPiAgCWlmIChsaW1pdHMtPm1heF9icHAgPCAzICogRFBfRFND
X01JTl9TVVBQT1JURURfQlBDKSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygiTm8gRFNDIHN1cHBvcnQg
Zm9yIGxlc3MgdGhhbiA4YnBjXG4iKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4
IGRkMjJjZGVhYTY3My4uOTk3YmVhNWZkZjE2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2
LmgKPiBAQCAtOTQ1LDYgKzk0NSw5IEBAIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlIHsKPiAgCQl1
OCBzbGljZV9jb3VudDsKPiAgCX0gZHNjX3BhcmFtczsKPiAgCXN0cnVjdCBkcm1fZHNjX2NvbmZp
ZyBkcF9kc2NfY2ZnOwo+ICsKPiArCS8qIEZvcndhcmQgRXJyb3IgY29ycmVjdGlvbiBTdGF0ZSAq
Lwo+ICsJYm9vbCBmZWNfZW5hYmxlOwo+ICB9Owo+ICAKPiAgc3RydWN0IGludGVsX2NydGMgewo+
IC0tIAo+IDIuMTkuMQo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl
bC1nZngK