From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 3/3] drm/vc4: Add a load tracker to prevent HVS underflow errors Date: Thu, 8 Nov 2018 17:50:58 +0100 Message-ID: <20181108175058.4038de03@bbrezillon> References: <20181025124546.22145-1-boris.brezillon@bootlin.com> <20181025124546.22145-4-boris.brezillon@bootlin.com> <87bm7bm3k8.fsf@anholt.net> <20181105123648.4fe6d838@bbrezillon> <8736sbo7qu.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id E2BC289AB5 for ; Thu, 8 Nov 2018 16:51:09 +0000 (UTC) In-Reply-To: <8736sbo7qu.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAwOCBOb3YgMjAxOCAwODoyNjo0OSAtMDgwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gPj4gPiArc3RhdGljIHZvaWQgdmM0X3BsYW5lX2NhbGNfbG9hZChz dHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiA+PiA+ICt7Cj4gPj4gPiArCXVuc2lnbmVk IGludCBodnNfbG9hZF9zaGlmdCwgdnJlZnJlc2gsIGk7Cj4gPj4gPiArCXN0cnVjdCBkcm1fZnJh bWVidWZmZXIgKmZiID0gc3RhdGUtPmZiOwo+ID4+ID4gKwlzdHJ1Y3QgdmM0X3BsYW5lX3N0YXRl ICp2YzRfc3RhdGU7Cj4gPj4gPiArCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsK PiA+PiA+ICsJdW5zaWduZWQgaW50IHZzY2FsZV9mYWN0b3I7Cj4gPj4gPiArCj4gPj4gPiArCXZj NF9zdGF0ZSA9IHRvX3ZjNF9wbGFuZV9zdGF0ZShzdGF0ZSk7Cj4gPj4gPiArCWNydGNfc3RhdGUg PSBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jcnRjX3N0YXRlKHN0YXRlLT5zdGF0ZSwKPiA+PiA+ ICsJCQkJCQkJc3RhdGUtPmNydGMpOwo+ID4+ID4gKwl2cmVmcmVzaCA9IGRybV9tb2RlX3ZyZWZy ZXNoKCZjcnRjX3N0YXRlLT5hZGp1c3RlZF9tb2RlKTsKPiA+PiA+ICsKPiA+PiA+ICsJLyogVGhl IEhWUyBpcyBhYmxlIHRvIHByb2Nlc3MgMiBwaXhlbHMvY3ljbGUgd2hlbiBzY2FsaW5nIHRoZSBz b3VyY2UsCj4gPj4gPiArCSAqIDQgcGl4ZWxzL2N5Y2xlIG90aGVyd2lzZS4KPiA+PiA+ICsJICog QWxwaGEgYmxlbmRpbmcgc3RlcCBzZWVtcyB0byBiZSBwaXBlbGluZWQgYW5kIGl0J3MgYWx3YXlz IG9wZXJhdGluZwo+ID4+ID4gKwkgKiBhdCA0IHBpeGVscy9jeWNsZSwgc28gdGhlIGxpbWl0aW5n IGFzcGVjdCBoZXJlIHNlZW1zIHRvIGJlIHRoZQo+ID4+ID4gKwkgKiBzY2FsZXIgYmxvY2suCj4g Pj4gPiArCSAqIEhWUyBsb2FkIGlzIGV4cHJlc3NlZCBpbiBjbGstY3ljbGVzL3NlYyAoQUtBIEh6 KS4KPiA+PiA+ICsJICovCj4gPj4gPiArCWlmICh2YzRfc3RhdGUtPnhfc2NhbGluZ1swXSAhPSBW QzRfU0NBTElOR19OT05FIHx8Cj4gPj4gPiArCSAgICB2YzRfc3RhdGUtPnhfc2NhbGluZ1sxXSAh PSBWQzRfU0NBTElOR19OT05FIHx8Cj4gPj4gPiArCSAgICB2YzRfc3RhdGUtPnlfc2NhbGluZ1sw XSAhPSBWQzRfU0NBTElOR19OT05FIHx8Cj4gPj4gPiArCSAgICB2YzRfc3RhdGUtPnlfc2NhbGlu Z1sxXSAhPSBWQzRfU0NBTElOR19OT05FKQo+ID4+ID4gKwkJaHZzX2xvYWRfc2hpZnQgPSAxOwo+ ID4+ID4gKwllbHNlCj4gPj4gPiArCQlodnNfbG9hZF9zaGlmdCA9IDI7Cj4gPj4gPiArCj4gPj4g PiArCXZjNF9zdGF0ZS0+bWVtYnVzX2xvYWQgPSAwOwo+ID4+ID4gKwl2YzRfc3RhdGUtPmh2c19s b2FkID0gMDsKPiA+PiA+ICsJZm9yIChpID0gMDsgaSA8IGZiLT5mb3JtYXQtPm51bV9wbGFuZXM7 IGkrKykgewo+ID4+ID4gKwkJdW5zaWduZWQgbG9uZyBwaXhlbHNfbG9hZDsgICAgCj4gPj4gCj4g Pj4gSSdtIHNjYXJlZCBhbnkgdGltZSBJIHNlZSBsb25ncy4gIERvIHlvdSB3YW50IDMyIG9yIDY0 IGJpdHMgaGVyZT8gIAo+ID4KPiA+IEkganVzdCBhc3N1bWVkIGEgMzJiaXQgdW5zaWduZWQgdmFy IHdvdWxkIGJlIGVub3VnaCwgc28gdW5zaWduZWQgbG9uZwo+ID4gc2VlbWVkIGp1c3QgZmluZS4g SSBjYW4gdXNlIHUzMiBvciB1NjQgaWYgeW91IHByZWZlci4gIAo+IAo+IFllcywgcGxlYXNlLiAg U2VlIGFsc28gTWF4aW1lJ3MgcmVjZW50IHRyb3VibGUgd2l0aCBhIDY0LWJpdCBrZXJuZWwuCgpX aWxsIHVzZSB1MzIgdGhlbi4KCj4gCj4gPj4gPiArCQkvKiBFdmVuIGlmIHRoZSBiYW5kd2lkdGgv cGxhbmUgcmVxdWlyZWQgZm9yIGEgc2luZ2xlIGZyYW1lIGlzCj4gPj4gPiArCQkgKgo+ID4+ID4g KwkJICogdmM0X3N0YXRlLT5zcmNfd1tpXSAqIHZjNF9zdGF0ZS0+c3JjX2hbaV0gKiBjcHAgKiB2 cmVmcmVzaAo+ID4+ID4gKwkJICoKPiA+PiA+ICsJCSAqIHdoZW4gZG93bnNjYWxpbmcsIHdlIGhh dmUgdG8gcmVhZCBtb3JlIHBpeGVscyBwZXIgbGluZSBpbgo+ID4+ID4gKwkJICogdGhlIHRpbWUg ZnJhbWUgcmVzZXJ2ZWQgZm9yIGEgc2luZ2xlIGxpbmUsIHNvIHRoZSBiYW5kd2lkdGgKPiA+PiA+ ICsJCSAqIGRlbWFuZCBjYW4gYmUgcHVuY3R1YWxseSBoaWdoZXIuIFRvIGFjY291bnQgZm9yIHRo YXQsIHdlCj4gPj4gPiArCQkgKiBjYWxjdWxhdGUgdGhlIGRvd24tc2NhbGluZyBmYWN0b3IgYW5k IG11bHRpcGx5IHRoZSBwbGFuZQo+ID4+ID4gKwkJICogbG9hZCBieSB0aGlzIG51bWJlci4gV2Un cmUgbGlrZWx5IG92ZXItZXN0aW1hdGluZyB0aGUgcmVhZAo+ID4+ID4gKwkJICogZGVtYW5kLCBi dXQgdGhhdCdzIGJldHRlciB0aGFuIHVuZGVyLWVzdGltYXRpbmcgaXQuCj4gPj4gPiArCQkgKi8K PiA+PiA+ICsJCXZzY2FsZV9mYWN0b3IgPSBESVZfUk9VTkRfVVAodmM0X3N0YXRlLT5zcmNfaFtp XSwKPiA+PiA+ICsJCQkJCSAgICAgdmM0X3N0YXRlLT5jcnRjX2gpOwo+ID4+ID4gKwkJcGl4ZWxz X2xvYWQgPSB2YzRfc3RhdGUtPnNyY193W2ldICogdmM0X3N0YXRlLT5zcmNfaFtpXSAqCj4gPj4g PiArCQkJICAgICAgdnNjYWxlX2ZhY3RvcjsgICAgCj4gPj4gCj4gPj4gSWYgd2UncmUgdXBzY2Fs aW5nIChjb21tb24gZm9yIHZpZGVvLCByaWdodD8pLCBhcmVuJ3Qgd2UgdW5kZXItY291bnRpbmcK PiA+PiB0aGUgY29zdD8gIFlvdSBuZWVkIHRvIHNjYWxlL2NvbG9yc3BhY2UtY29udmVydCBjcnRj X3cgKiBjcnRjX2ggYXQgMgo+ID4+IHBpeGVscyBwZXIgY3ljbGUuICAKPiA+Cj4gPiBUaGF0J3Mg bm90IGVudGlyZWx5IGNsZWFyIHRvIG1lLiBJJ20gbm90IHN1cmUgd2hhdCB0aGUgc2NhbGVyIGRv ZXMgd2hlbgo+ID4gdXBzY2FsaW5nLiBBcmUgdGhlIHNhbWUgcGl4ZWxzIHJlYWQgc2V2ZXJhbCB0 aW1lcyBmcm9tIHRoZSBtZW1vcnk/IElmCj4gPiB0aGF0J3MgdGhlIGNhc2UsIHRoZW4gdGhlIG1l bWJ1cyBsb2FkIHNob3VsZCBpbmRlZWQgYmUgYmFzZWQgb24gdGhlCj4gPiBjcnRjX3csaC4gIAo+ IAo+IEknbSBnb2luZyB0byBwdW50IG9uIHRoaXMgcXVlc3Rpb24gYmVjYXVzZSB0aGF0IHdvdWxk IGJlIGEgKmxvdCogb2YKPiB2ZXJpbG9nIHRyYWNpbmcgdG8gZmlndXJlIG91dCBmb3IgbWUgKGFu ZCBJJ20gbm90IHN1cmUgSSdkIGV2ZW4gdHJ1c3QKPiB3aGF0IEkgY2FtZSB1cCB3aXRoKS4KPiAK PiA+IEFsc28sIHdoZW4gdGhlIHNwZWMgc2F5cyB0aGUgSFZTIGNhbiBwcm9jZXNzIDRwaXhlbHMv Y3ljbGVzLCBpcyBpdCA0Cj4gPiBpbnB1dCBwaXhlbHMgb3IgNCBvdXRwdXQgcGl4ZWxzIHBlciBj eWNsZT8gIAo+IAo+IFdlbGwsIGl0J3MgNCBwaXhlbHMgcGVyIGN5Y2xlIHdoZW4gbm90IHNjYWxp bmcsIHNvIGJvdGggOikKClNvcnJ5LCBJIG1lYW50IDJwaXhlbHMvY3ljbGUgOikuCgo+IAo+IEkg dGhpbmsgdGhlIHNjYWxpbmcgcGlwZWxpbmUgaXMgZG9pbmcgdHdvIG91dHB1dCBwaXhlbHMgcGVy IGN5Y2xlLgo+IE5vdGhpbmcgZWxzZSB3b3VsZCBtYWtlIHNlbnNlIHRvIG1lLgoKT2theSwgc28g dGhlIEhWUyBsb2FkIHNob3VsZCBiZSBiYXNlZCBvbiBjcnRjX3cvaCBhbmQgdGhlIG1lbWJ1cyBs b2FkCnNob3VsZCBiZSBiYXNlZCBvbiBzcmNfdy9oIGFuZCB0aGUgc2NhbGluZyByYXRpbywgcmln aHQ/Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=