From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Brezillon <boris.brezillon@bootlin.com>
Subject: Re: [PATCH 3/4] drm/v3d: Clean up the reservation object setup.
Date: Tue, 13 Nov 2018 11:22:49 +0100
Message-ID: <20181113112249.532ed593@bbrezillon>
References: <20181108161654.19888-1-eric@anholt.net>
 <20181108161654.19888-4-eric@anholt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54])
 by gabe.freedesktop.org (Postfix) with ESMTP id 59CD06E312
 for <dri-devel@lists.freedesktop.org>; Tue, 13 Nov 2018 10:22:50 +0000 (UTC)
In-Reply-To: <20181108161654.19888-4-eric@anholt.net>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Eric Anholt <eric@anholt.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCAgOCBOb3YgMjAxOCAwODoxNjo1MyAtMDgwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv
bHQubmV0PiB3cm90ZToKCj4gVGhlIGV4dHJhIHRvX3YzZF9ibygpIGNhbGxzIGNhbWUgZnJvbSBj
b3B5aW5nIHRoaXMgZnJvbSB0aGUgdmM0Cj4gZHJpdmVyLCB3aGljaCBzdG9yZWQgdGhlIGNtYSBn
ZW0gb2JqZWN0IGluIHRoZSBzdHJ1Y3RzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEVyaWMgQW5ob2x0
IDxlcmljQGFuaG9sdC5uZXQ+CgpSZXZpZXdlZC1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5i
cmV6aWxsb25AYm9vdGxpbi5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9n
ZW0uYyB8IDMyICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFu
Z2VkLCAxMSBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv
ZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9n
ZW0uYwo+IGluZGV4IGI4OGM5NjkxMTQ1My4uZDBkZmRjYmJkNDJjIDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS92M2QvdjNkX2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3YzZC92
M2RfZ2VtLmMKPiBAQCAtMjE0LDEwICsyMTQsOCBAQCB2M2RfYXR0YWNoX29iamVjdF9mZW5jZXMo
c3RydWN0IHYzZF9leGVjX2luZm8gKmV4ZWMpCj4gIAlpbnQgaTsKPiAgCj4gIAlmb3IgKGkgPSAw
OyBpIDwgZXhlYy0+Ym9fY291bnQ7IGkrKykgewo+IC0JCWJvID0gdG9fdjNkX2JvKCZleGVjLT5i
b1tpXS0+YmFzZSk7Cj4gLQo+ICAJCS8qIFhYWDogVXNlIHNoYXJlZCBmZW5jZXMgZm9yIHJlYWQt
b25seSBvYmplY3RzLiAqLwo+IC0JCXJlc2VydmF0aW9uX29iamVjdF9hZGRfZXhjbF9mZW5jZShi
by0+cmVzdiwgb3V0X2ZlbmNlKTsKPiArCQlyZXNlcnZhdGlvbl9vYmplY3RfYWRkX2V4Y2xfZmVu
Y2UoZXhlYy0+Ym9baV0tPnJlc3YsIG91dF9mZW5jZSk7Cj4gIAl9Cj4gIH0KPiAgCj4gQEAgLTIy
OCwxMSArMjI2LDggQEAgdjNkX3VubG9ja19ib19yZXNlcnZhdGlvbnMoc3RydWN0IGRybV9kZXZp
Y2UgKmRldiwKPiAgewo+ICAJaW50IGk7Cj4gIAo+IC0JZm9yIChpID0gMDsgaSA8IGV4ZWMtPmJv
X2NvdW50OyBpKyspIHsKPiAtCQlzdHJ1Y3QgdjNkX2JvICpibyA9IHRvX3YzZF9ibygmZXhlYy0+
Ym9baV0tPmJhc2UpOwo+IC0KPiAtCQl3d19tdXRleF91bmxvY2soJmJvLT5yZXN2LT5sb2NrKTsK
PiAtCX0KPiArCWZvciAoaSA9IDA7IGkgPCBleGVjLT5ib19jb3VudDsgaSsrKQo+ICsJCXd3X211
dGV4X3VubG9jaygmZXhlYy0+Ym9baV0tPnJlc3YtPmxvY2spOwo+ICAKPiAgCXd3X2FjcXVpcmVf
ZmluaShhY3F1aXJlX2N0eCk7Cj4gIH0KPiBAQCAtMjUxLDEzICsyNDYsMTMgQEAgdjNkX2xvY2tf
Ym9fcmVzZXJ2YXRpb25zKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIHsKPiAgCWludCBjb250
ZW5kZWRfbG9jayA9IC0xOwo+ICAJaW50IGksIHJldDsKPiAtCXN0cnVjdCB2M2RfYm8gKmJvOwo+
ICAKPiAgCXd3X2FjcXVpcmVfaW5pdChhY3F1aXJlX2N0eCwgJnJlc2VydmF0aW9uX3d3X2NsYXNz
KTsKPiAgCj4gIHJldHJ5Ogo+ICAJaWYgKGNvbnRlbmRlZF9sb2NrICE9IC0xKSB7Cj4gLQkJYm8g
PSB0b192M2RfYm8oJmV4ZWMtPmJvW2NvbnRlbmRlZF9sb2NrXS0+YmFzZSk7Cj4gKwkJc3RydWN0
IHYzZF9ibyAqYm8gPSBleGVjLT5ib1tjb250ZW5kZWRfbG9ja107Cj4gKwo+ICAJCXJldCA9IHd3
X211dGV4X2xvY2tfc2xvd19pbnRlcnJ1cHRpYmxlKCZiby0+cmVzdi0+bG9jaywKPiAgCQkJCQkJ
ICAgICAgIGFjcXVpcmVfY3R4KTsKPiAgCQlpZiAocmV0KSB7Cj4gQEAgLTI3MCwxOSArMjY1LDE2
IEBAIHYzZF9sb2NrX2JvX3Jlc2VydmF0aW9ucyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJ
CWlmIChpID09IGNvbnRlbmRlZF9sb2NrKQo+ICAJCQljb250aW51ZTsKPiAgCj4gLQkJYm8gPSB0
b192M2RfYm8oJmV4ZWMtPmJvW2ldLT5iYXNlKTsKPiAtCj4gLQkJcmV0ID0gd3dfbXV0ZXhfbG9j
a19pbnRlcnJ1cHRpYmxlKCZiby0+cmVzdi0+bG9jaywgYWNxdWlyZV9jdHgpOwo+ICsJCXJldCA9
IHd3X211dGV4X2xvY2tfaW50ZXJydXB0aWJsZSgmZXhlYy0+Ym9baV0tPnJlc3YtPmxvY2ssCj4g
KwkJCQkJCSAgYWNxdWlyZV9jdHgpOwo+ICAJCWlmIChyZXQpIHsKPiAgCQkJaW50IGo7Cj4gIAo+
IC0JCQlmb3IgKGogPSAwOyBqIDwgaTsgaisrKSB7Cj4gLQkJCQlibyA9IHRvX3YzZF9ibygmZXhl
Yy0+Ym9bal0tPmJhc2UpOwo+IC0JCQkJd3dfbXV0ZXhfdW5sb2NrKCZiby0+cmVzdi0+bG9jayk7
Cj4gLQkJCX0KPiArCQkJZm9yIChqID0gMDsgaiA8IGk7IGorKykKPiArCQkJCXd3X211dGV4X3Vu
bG9jaygmZXhlYy0+Ym9bal0tPnJlc3YtPmxvY2spOwo+ICAKPiAgCQkJaWYgKGNvbnRlbmRlZF9s
b2NrICE9IC0xICYmIGNvbnRlbmRlZF9sb2NrID49IGkpIHsKPiAtCQkJCWJvID0gdG9fdjNkX2Jv
KCZleGVjLT5ib1tjb250ZW5kZWRfbG9ja10tPmJhc2UpOwo+ICsJCQkJc3RydWN0IHYzZF9ibyAq
Ym8gPSBleGVjLT5ib1tjb250ZW5kZWRfbG9ja107Cj4gIAo+ICAJCQkJd3dfbXV0ZXhfdW5sb2Nr
KCZiby0+cmVzdi0+bG9jayk7Cj4gIAkJCX0KPiBAQCAtMzAzLDkgKzI5NSw3IEBAIHYzZF9sb2Nr
X2JvX3Jlc2VydmF0aW9ucyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJICogYmVmb3JlIHdl
IGNvbW1pdCB0aGUgQ0wgdG8gdGhlIGhhcmR3YXJlLgo+ICAJICovCj4gIAlmb3IgKGkgPSAwOyBp
IDwgZXhlYy0+Ym9fY291bnQ7IGkrKykgewo+IC0JCWJvID0gdG9fdjNkX2JvKCZleGVjLT5ib1tp
XS0+YmFzZSk7Cj4gLQo+IC0JCXJldCA9IHJlc2VydmF0aW9uX29iamVjdF9yZXNlcnZlX3NoYXJl
ZChiby0+cmVzdiwgMSk7Cj4gKwkJcmV0ID0gcmVzZXJ2YXRpb25fb2JqZWN0X3Jlc2VydmVfc2hh
cmVkKGV4ZWMtPmJvW2ldLT5yZXN2LCAxKTsKPiAgCQlpZiAocmV0KSB7Cj4gIAkJCXYzZF91bmxv
Y2tfYm9fcmVzZXJ2YXRpb25zKGRldiwgZXhlYywgYWNxdWlyZV9jdHgpOwo+ICAJCQlyZXR1cm4g
cmV0OwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp
LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==