From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: Re: [PATCH 4/4] drm/msm: Optimize adreno_show_object() Date: Tue, 20 Nov 2018 08:56:22 -0700 Message-ID: <20181120155622.GG31792@jcrouse-lnx.qualcomm.com> References: <1542713851-14375-1-git-send-email-smasetty@codeaurora.org> <1542713851-14375-4-git-send-email-smasetty@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1542713851-14375-4-git-send-email-smasetty-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sharat Masetty Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMjAsIDIwMTggYXQgMDU6MDc6MzFQTSArMDUzMCwgU2hhcmF0IE1hc2V0dHkg d3JvdGU6Cj4gV2hlbiB0aGUgdXNlcnNwYWNlIHRyaWVzIHRvIHJlYWQgdGhlIGNyYXNoc3RhdGUg ZHVtcCwgdGhlIHJlYWQgc2lkZQo+IGltcGxlbWVudGF0aW9uIGluIHRoZSBkcml2ZXIgY3VycmVu dGx5IGFzY2lpODUgZW5jb2RlcyBhbGwgdGhlIGJpbmFyeQo+IGJ1ZmZlcnMgYW5kIGl0IGRvZXMg dGhpcyBlYWNoIHRpbWUgdGhlIHJlYWQgc3lzdGVtIGNhbGwgaXMgY2FsbGVkLgo+IEEgdXNlcnNw YWNlIHRvb2wgbGlrZSBjYXQgdHlwaWNhbGx5IGRvZXMgYSBwYWdlIGJ5IHBhZ2UgcmVhZCBhbmQg dGhlCj4gbnVtYmVyIG9mIHJlYWQgY2FsbHMgZGVwZW5kcyBvbiB0aGUgc2l6ZSBvZiB0aGUgZGF0 YSBjYXB0dXJlZCBieSB0aGUKPiBkcml2ZXIuIFRoaXMgaXMgY2VydGFpbmx5IG5vdCBkZXNpcmFi bGUgYW5kIGRvZXMgbm90IHNjYWxlIHdlbGwgd2l0aAo+IGxhcmdlIGNhcHR1cmVzLgo+IAo+IFRo aXMgcGF0Y2ggZW5jb2RlcyB0aGUgYnVmZmVyIG9ubHkgb25jZSBpbiB0aGUgcmVhZCBwYXRoLiBX aXRoIHRoaXMgdGhlcmUKPiBpcyBhbiBpbW1lZGlhdGUgPjEwWCBzcGVlZCBpbXByb3ZlbWVudCBp biBjcmFzaHN0YXRlIHNhdmUgdGltZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTaGFyYXQgTWFzZXR0 eSA8c21hc2V0dHlAY29kZWF1cm9yYS5vcmc+CgpSZXZpZXdlZC1ieTogSm9yZGFuIENyb3VzZSA8 amNyb3VzZUBjb2RlYXVyb3JhLm9yZz4KCkkgbGlrZSB0aGlzIGEgbG90LgoKPiAtLS0KPiBDaGFu Z2VzIGZyb20gdjE6Cj4gCUFkZHJlc3NlZCBjb21tZW50cyBmcm9tIEpvcmRhbiBDcm91c2UKPiAK PiAgZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYWRyZW5vX2dwdS5jIHwgODAgKysrKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2dwdS5o ICAgICAgICAgICB8ICAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCA2MCBpbnNlcnRpb25zKCspLCAy MSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJl bm8vYWRyZW5vX2dwdS5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYWRyZW5vX2dwdS5j Cj4gaW5kZXggYmJmOGQzZS4uNzc0OTk2NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v bXNtL2FkcmVuby9hZHJlbm9fZ3B1LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVu by9hZHJlbm9fZ3B1LmMKPiBAQCAtNDQxLDExICs0NDEsMTUgQEAgdm9pZCBhZHJlbm9fZ3B1X3N0 YXRlX2Rlc3Ryb3koc3RydWN0IG1zbV9ncHVfc3RhdGUgKnN0YXRlKQo+ICB7Cj4gIAlpbnQgaTsK PiAKPiAtCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHN0YXRlLT5yaW5nKTsgaSsrKQo+ICsJ Zm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUoc3RhdGUtPnJpbmcpOyBpKyspIHsKPiAgCQlrdmZy ZWUoc3RhdGUtPnJpbmdbaV0uYm8uZGF0YSk7Cj4gKwkJa3ZmcmVlKHN0YXRlLT5yaW5nW2ldLmJv LmVuY29kZWQpOwo+ICsJfQo+IAo+IC0JZm9yIChpID0gMDsgc3RhdGUtPmJvcyAmJiBpIDwgc3Rh dGUtPm5yX2JvczsgaSsrKQo+ICsJZm9yIChpID0gMDsgc3RhdGUtPmJvcyAmJiBpIDwgc3RhdGUt Pm5yX2JvczsgaSsrKSB7Cj4gIAkJa3ZmcmVlKHN0YXRlLT5ib3NbaV0uZGF0YSk7Cj4gKwkJa3Zm cmVlKHN0YXRlLT5ib3NbaV0uZW5jb2RlZCk7Cj4gKwl9Cj4gCj4gIAlrZnJlZShzdGF0ZS0+Ym9z KTsKPiAgCWtmcmVlKHN0YXRlLT5jb21tKTsKPiBAQCAtNDcyLDM0ICs0NzYsNzAgQEAgaW50IGFk cmVub19ncHVfc3RhdGVfcHV0KHN0cnVjdCBtc21fZ3B1X3N0YXRlICpzdGF0ZSkKPiAKPiAgI2lm IGRlZmluZWQoQ09ORklHX0RFQlVHX0ZTKSB8fCBkZWZpbmVkKENPTkZJR19ERVZfQ09SRURVTVAp Cj4gCj4gLXN0YXRpYyB2b2lkIGFkcmVub19zaG93X29iamVjdChzdHJ1Y3QgZHJtX3ByaW50ZXIg KnAsIHUzMiAqcHRyLCBpbnQgbGVuKQo+ICtzdGF0aWMgY2hhciAqYWRyZW5vX2dwdV9hc2NpaTg1 X2VuY29kZSh1MzIgKnNyYywgc2l6ZV90IGxlbikKPiAgewo+IC0JY2hhciBvdXRbQVNDSUk4NV9C VUZTWl07Cj4gLQlsb25nIGwsIGRhdGFsZW4sIGk7Cj4gKwl2b2lkICpidWY7Cj4gKwlzaXplX3Qg YnVmX2l0ciA9IDA7Cj4gKwlsb25nIGksIGw7Cj4gCj4gLQlpZiAoIXB0ciB8fCAhbGVuKQo+IC0J CXJldHVybjsKPiArCWlmICghbGVuKQo+ICsJCXJldHVybiBOVUxMOwo+ICsKPiArCWwgPSBhc2Np aTg1X2VuY29kZV9sZW4obGVuKTsKPiAKPiAgCS8qCj4gLQkgKiBPbmx5IGR1bXAgdGhlIG5vbi16 ZXJvIHBhcnQgb2YgdGhlIGJ1ZmZlciAtIHJhcmVseSB3aWxsIGFueSBkYXRhCj4gLQkgKiBjb21w bGV0ZWx5IGZpbGwgdGhlIGVudGlyZSBhbGxvY2F0ZWQgc2l6ZSBvZiB0aGUgYnVmZmVyCj4gKwkg KiBhc2NpaTg1IG91dHB1dHMgZWl0aGVyIGEgNSBieXRlIHN0cmluZyBvciBhIDEgYnl0ZSBzdHJp bmcuIFNvIHdlCj4gKwkgKiBhY2NvdW50IGZvciB0aGUgd29yc3QgY2FzZSBvZiA1IGJ5dGVzIHBl ciBkd29yZCBwbHVzIHRoZSAxIGZvciAnXDAnCj4gIAkgKi8KPiAtCWZvciAoZGF0YWxlbiA9IDAs IGkgPSAwOyBpIDwgbGVuID4+IDI7IGkrKykgewo+IC0JCWlmIChwdHJbaV0pCj4gLQkJCWRhdGFs ZW4gPSAoaSA8PCAyKSArIDE7Cj4gKwlidWYgPSBrdm1hbGxvYygobCAqIDUpICsgMSwgR0ZQX0tF Uk5FTCk7Cj4gKwlpZiAoIWJ1ZikKPiArCQlyZXR1cm4gTlVMTDsKPiArCj4gKwlmb3IgKGkgPSAw OyBpIDwgbDsgaSsrKSB7Cj4gKwkJYXNjaWk4NV9lbmNvZGUoc3JjW2ldLCBidWYgKyBidWZfaXRy KTsKPiArCj4gKwkJaWYgKHNyY1tpXSA9PSAwKQo+ICsJCQlidWZfaXRyICs9IDE7Cj4gKwkJZWxz ZQo+ICsJCQlidWZfaXRyICs9IDU7Cj4gIAl9Cj4gCj4gLQkvKiBTa2lwIHByaW50aW5nIHRoZSBv YmplY3QgaWYgaXQgaXMgZW1wdHkgKi8KPiAtCWlmIChkYXRhbGVuID09IDApCj4gKwlyZXR1cm4g YnVmOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBhZHJlbm9fc2hvd19vYmplY3Qoc3RydWN0IGRy bV9wcmludGVyICpwLAo+ICsJCXN0cnVjdCBtc21fZ3B1X3N0YXRlX2JvICpibykKPiArewo+ICsJ aWYgKCghYm8tPmRhdGEgJiYgIWJvLT5lbmNvZGVkKSB8fCAhYm8tPnNpemUpCj4gIAkJcmV0dXJu Owo+IAo+IC0JbCA9IGFzY2lpODVfZW5jb2RlX2xlbihkYXRhbGVuKTsKPiArCWlmICghYm8tPmVu Y29kZWQpIHsKPiArCQlsb25nIGRhdGFsZW4sIGk7Cj4gKwkJdTMyICpidWYgPSBiby0+ZGF0YTsK PiArCj4gKwkJLyoKPiArCQkgKiBPbmx5IGR1bXAgdGhlIG5vbi16ZXJvIHBhcnQgb2YgdGhlIGJ1 ZmZlciAtIHJhcmVseSB3aWxsCj4gKwkJICogYW55IGRhdGEgY29tcGxldGVseSBmaWxsIHRoZSBl bnRpcmUgYWxsb2NhdGVkIHNpemUgb2YKPiArCQkgKiB0aGUgYnVmZmVyLgo+ICsJCSAqLwo+ICsJ CWZvciAoZGF0YWxlbiA9IDAsIGkgPSAwOyBpIDwgKGJvLT5zaXplKSA+PiAyOyBpKyspIHsKPiAr CQkJaWYgKGJ1ZltpXSkKPiArCQkJCWRhdGFsZW4gPSAoKGkgKyAxKSA8PCAyKTsKPiArCQl9Cj4g Kwo+ICsJCWJvLT5lbmNvZGVkID0gYWRyZW5vX2dwdV9hc2NpaTg1X2VuY29kZShidWYsIGRhdGFs ZW4pOwo+ICsKPiArCQlrdmZyZWUoYm8tPmRhdGEpOwo+ICsJCWJvLT5kYXRhID0gTlVMTDsKPiAr Cj4gKwkJaWYgKCFiby0+ZW5jb2RlZCkKPiArCQkJcmV0dXJuOwo+ICsJfQo+IAo+ICAJZHJtX3B1 dHMocCwgIiAgICBkYXRhOiAhIWFzY2lpODUgfFxuIik7Cj4gIAlkcm1fcHV0cyhwLCAiICAgICAi KTsKPiAKPiAtCWZvciAoaSA9IDA7IGkgPCBsOyBpKyspCj4gLQkJZHJtX3B1dHMocCwgYXNjaWk4 NV9lbmNvZGUocHRyW2ldLCBvdXQpKTsKPiArCWRybV9wdXRzKHAsIGJvLT5lbmNvZGVkKTsKPiAK PiAgCWRybV9wdXRzKHAsICJcbiIpOwo+ICB9Cj4gQEAgLTUzMSw4ICs1NzEsNyBAQCB2b2lkIGFk cmVub19zaG93KHN0cnVjdCBtc21fZ3B1ICpncHUsIHN0cnVjdCBtc21fZ3B1X3N0YXRlICpzdGF0 ZSwKPiAgCQlkcm1fcHJpbnRmKHAsICIgICAgd3B0cjogJWRcbiIsIHN0YXRlLT5yaW5nW2ldLndw dHIpOwo+ICAJCWRybV9wcmludGYocCwgIiAgICBzaXplOiAlZFxuIiwgTVNNX0dQVV9SSU5HQlVG RkVSX1NaKTsKPiAKPiAtCQlhZHJlbm9fc2hvd19vYmplY3QocCwgc3RhdGUtPnJpbmdbaV0uYm8u ZGF0YSwKPiAtCQkJc3RhdGUtPnJpbmdbaV0uYm8uc2l6ZSk7Cj4gKwkJYWRyZW5vX3Nob3dfb2Jq ZWN0KHAsICYoc3RhdGUtPnJpbmdbaV0uYm8pKTsKPiAgCX0KPiAKPiAgCWlmIChzdGF0ZS0+Ym9z KSB7Cj4gQEAgLTU0Myw4ICs1ODIsNyBAQCB2b2lkIGFkcmVub19zaG93KHN0cnVjdCBtc21fZ3B1 ICpncHUsIHN0cnVjdCBtc21fZ3B1X3N0YXRlICpzdGF0ZSwKPiAgCQkJCXN0YXRlLT5ib3NbaV0u aW92YSk7Cj4gIAkJCWRybV9wcmludGYocCwgIiAgICBzaXplOiAlemRcbiIsIHN0YXRlLT5ib3Nb aV0uc2l6ZSk7Cj4gCj4gLQkJCWFkcmVub19zaG93X29iamVjdChwLCBzdGF0ZS0+Ym9zW2ldLmRh dGEsCj4gLQkJCQlzdGF0ZS0+Ym9zW2ldLnNpemUpOwo+ICsJCQlhZHJlbm9fc2hvd19vYmplY3Qo cCwgJihzdGF0ZS0+Ym9zW2ldKSk7Cj4gIAkJfQo+ICAJfQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vbXNtL21zbV9ncHUuaCBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2dwdS5o Cj4gaW5kZXggYTNhNjM3MS4uNzM3YmY0NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v bXNtL21zbV9ncHUuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2dwdS5oCj4gQEAg LTE5MSw2ICsxOTEsNyBAQCBzdHJ1Y3QgbXNtX2dwdV9zdGF0ZV9ibyB7Cj4gIAl1NjQgaW92YTsK PiAgCXNpemVfdCBzaXplOwo+ICAJdm9pZCAqZGF0YTsKPiArCWNoYXIgKmVuY29kZWQ7Cj4gIH07 Cj4gCj4gIHN0cnVjdCBtc21fZ3B1X3N0YXRlIHsKPiAtLQo+IDEuOS4xCj4gCgotLSAKVGhlIFF1 YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIENvZGUgQXVyb3Jh IEZvcnVtLAphIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWlsaW5n IGxpc3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubwo=