[PATCH AUTOSEL 4.9 08/17] drm/edid: Add 6 bpc quirk for BOE panel.

[PATCH AUTOSEL 4.9 08/17] drm/edid: Add 6 bpc quirk for BOE panel.

[Sasha Levin]

From: "Lee, Shawn C" <shawn.c.lee@intel.com>

[ Upstream commit 922dceff8dc1fb4dafc9af78139ba65671408103 ]

BOE panel (ID: 0x0771) that reports "DFP 1.x compliant TMDS".
But it's 6bpc panel only instead of 8 bpc.

Add panel ID to edid quirk list and set 6 bpc as default to
work around this issue.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1540792173-7288-1-git-send-email-shawn.c.lee@intel.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/gpu/drm/drm_edid.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 83d2f43b5a2f..c93dcfedc219 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -116,6 +116,9 @@ static const struct edid_quirk {
 	/* SDC panel of Lenovo B50-80 reports 8 bpc, but is a 6 bpc panel */
 	{ "SDC", 0x3652, EDID_QUIRK_FORCE_6BPC },
 
+	/* BOE model 0x0771 reports 8 bpc, but is a 6 bpc panel */
+	{ "BOE", 0x0771, EDID_QUIRK_FORCE_6BPC },
+
 	/* Belinea 10 15 55 */
 	{ "MAX", 1516, EDID_QUIRK_PREFER_LARGE_60 },
 	{ "MAX", 0x77e, EDID_QUIRK_PREFER_LARGE_60 },
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH AUTOSEL 4.9 08/17] drm/edid: Add 6 bpc quirk for BOE panel.

[Daniel Vetter]

On Tue, Nov 13, 2018 at 12:52:14AM -0500, Sasha Levin wrote:
> From: "Lee, Shawn C" <shawn.c.lee@intel.com>
> 
> [ Upstream commit 922dceff8dc1fb4dafc9af78139ba65671408103 ]
> 
> BOE panel (ID: 0x0771) that reports "DFP 1.x compliant TMDS".
> But it's 6bpc panel only instead of 8 bpc.
> 
> Add panel ID to edid quirk list and set 6 bpc as default to
> work around this issue.
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Gustavo Padovan <gustavo@padovan.org>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Link: https://patchwork.freedesktop.org/patch/msgid/1540792173-7288-1-git-send-email-shawn.c.lee@intel.com
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Given that I'm not a fan of AUTOSEL at all: This one here is correctly
cherry-picked for stable, ack.
-Daniel

> ---
>  drivers/gpu/drm/drm_edid.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 83d2f43b5a2f..c93dcfedc219 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -116,6 +116,9 @@ static const struct edid_quirk {
>  	/* SDC panel of Lenovo B50-80 reports 8 bpc, but is a 6 bpc panel */
>  	{ "SDC", 0x3652, EDID_QUIRK_FORCE_6BPC },
>  
> +	/* BOE model 0x0771 reports 8 bpc, but is a 6 bpc panel */
> +	{ "BOE", 0x0771, EDID_QUIRK_FORCE_6BPC },
> +
>  	/* Belinea 10 15 55 */
>  	{ "MAX", 1516, EDID_QUIRK_PREFER_LARGE_60 },
>  	{ "MAX", 0x77e, EDID_QUIRK_PREFER_LARGE_60 },
> -- 
> 2.17.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH AUTOSEL 4.9 08/17] drm/edid: Add 6 bpc quirk for BOE panel.

[Daniel Vetter]

On Wed, Nov 21, 2018 at 10:31 AM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Tue, Nov 13, 2018 at 12:52:14AM -0500, Sasha Levin wrote:
> > From: "Lee, Shawn C" <shawn.c.lee@intel.com>
> >
> > [ Upstream commit 922dceff8dc1fb4dafc9af78139ba65671408103 ]
> >
> > BOE panel (ID: 0x0771) that reports "DFP 1.x compliant TMDS".
> > But it's 6bpc panel only instead of 8 bpc.
> >
> > Add panel ID to edid quirk list and set 6 bpc as default to
> > work around this issue.
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Gustavo Padovan <gustavo@padovan.org>
> > Cc: Cooper Chiou <cooper.chiou@intel.com>
> > Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Link: https://patchwork.freedesktop.org/patch/msgid/1540792173-7288-1-git-send-email-shawn.c.lee@intel.com
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> Given that I'm not a fan of AUTOSEL at all: This one here is correctly
> cherry-picked for stable, ack.

An idea that just crossed my mind: Could we integrate this into 0day
and suggest cc: stable before the patch even gets merged? Or is the
heuristics not good enough for that kind of automation?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH AUTOSEL 4.9 08/17] drm/edid: Add 6 bpc quirk for BOE panel.

[Sasha Levin]

On Wed, Nov 21, 2018 at 10:33:18AM +0100, Daniel Vetter wrote:
>On Wed, Nov 21, 2018 at 10:31 AM Daniel Vetter <daniel@ffwll.ch> wrote:
>>
>> On Tue, Nov 13, 2018 at 12:52:14AM -0500, Sasha Levin wrote:
>> > From: "Lee, Shawn C" <shawn.c.lee@intel.com>
>> >
>> > [ Upstream commit 922dceff8dc1fb4dafc9af78139ba65671408103 ]
>> >
>> > BOE panel (ID: 0x0771) that reports "DFP 1.x compliant TMDS".
>> > But it's 6bpc panel only instead of 8 bpc.
>> >
>> > Add panel ID to edid quirk list and set 6 bpc as default to
>> > work around this issue.
>> >
>> > Cc: Jani Nikula <jani.nikula@intel.com>
>> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> > Cc: Gustavo Padovan <gustavo@padovan.org>
>> > Cc: Cooper Chiou <cooper.chiou@intel.com>
>> > Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>>
>> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> > Link: https://patchwork.freedesktop.org/patch/msgid/1540792173-7288-1-git-send-email-shawn.c.lee@intel.com
>> > Signed-off-by: Sasha Levin <sashal@kernel.org>
>>
>> Given that I'm not a fan of AUTOSEL at all: This one here is correctly
>> cherry-picked for stable, ack.
>
>An idea that just crossed my mind: Could we integrate this into 0day
>and suggest cc: stable before the patch even gets merged? Or is the
>heuristics not good enough for that kind of automation?

Yes! I've actually tried it before but it seemed that the response rate
was quite low (even for commits that are obviously stable material) so I
turned it off to avoid spamming too much.

If you'd like to be the guinea pig for this, I could enable it for
drivers/gpu/drm/i915/ which I currently completely ignore. If at any
point you want it back off that's easy to do.

If this works well we can extend it to more subsystems where maintainers
might find it useful.