From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/fb-helper/generic: Only restore when in use Date: Mon, 26 Nov 2018 21:07:47 +0100 Message-ID: <20181126200747.GO4266@phenom.ffwll.local> References: <20181126153848.64966-1-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E10E89C60 for ; Mon, 26 Nov 2018 20:07:52 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id r27so17013363eda.0 for ; Mon, 26 Nov 2018 12:07:51 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181126153848.64966-1-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMjYsIDIwMTggYXQgMDQ6Mzg6NDhQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IE9uIGRybV9kcml2ZXItPmxhc3RfY2xvc2UgdGhlIGdlbmVyaWMgZmJkZXYgZW11 bGF0aW9uIHdpbGwgcmVzdG9yZSBmYmRldgo+IHJlZ2FyZGxlc3Mgb2YgaXQgYmVpbmcgdXNlZCBv ciBub3QuIFRoaXMgaXMgYSBwcm9ibGVtIGZvciBlLWluayBkaXNwbGF5cwo+IHdoaWNoIGRvbid0 IHdhbnQgdG8gYmUgb3ZlcndyaXR0ZW4gd2l0aCB6ZXJvZXMgd2hlbiBEUk0gdXNlcnNwYWNlIGNs b3Nlcy4KPiAKPiBBbWVuZCB0aGlzIGJ5IGFkZGluZyBhbiBvcGVuIGNvdW50ZXIgdG8gdHJhY2sg dXNlIGluIG9yZGVyIHRvIGtub3cgd2hlbgo+IHRvIHJlc3RvcmUuCj4gCj4gdjE6IEF2b2lkIHNw ZWNpYWwtY2FzaW5nIGFuZCBtb3ZlIHRoZSBjaGVjayB0byBkcm1fZmJkZXZfY2xpZW50X3Jlc3Rv cmUoKQo+ICAgICAoRGFuaWVsIFZldHRlcikKPiAKPiBTaWduZWQtb2ZmLWJ5OiBOb3JhbGYgVHLD uG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiAtLS0KPiAKPiBJIHdhcyB0aWVkIHVwIGluIG15 IHByZXZpb3VzIGF0dGVtcHQgdG8gc29sdmUgdGhpcyB3aGljaCBwcmVkYXRlZCB0aGUgCj4gZ2Vu ZXJpYyBlbXVsYXRpb24sIHNvIEkgZmFpbGVkIHRvIHNlZSB0aGF0IEkgY291bGQgc29sdmUgdGhp cyB3aXRoaW4KPiB0aGUgc2NvcGUgb2YgdGhlIGdlbmVyaWMgZmJkZXYuCgpTdGlsbCBraW5kYSBh bm5veWluZyB0aGF0IGJldHdlZW4gdGhpcyBhbmQgZHJtX2ZiX2hlbHBlcl9pc19ib3VuZCB3ZSds bApoYXZlIG11dGxpcGxlIHdheXMgdG8gZmlndXJlIG91dCB3aG8gb3ducyB0aGUgZmJkZXYuIEFu ZCB0aGUKc3BlY2lhbC1jYXNpbmcgaXMgc3RpbGwgdGhlcmUsIGl0J3MganVzdCBtb3ZlZCBhcm91 bmQgLSBpdCBzdGlsbCBvbmx5CndvcmtzIGZvciBkcml2ZXJzIHVzaW5nIHRoZSBuZXcgY2xpZW50 IGhlbHBlcnMuCgpUaGUgb3RoZXIgaXNzdWUgd2l0aCBub3QgcHV0dGluZyB0aGlzIGludG8gaXNf Ym91bmQoKSBpcyB0aGF0IHdlIG5vdyBoYXZlCmRpZmZlcmVudCBydWxlcyBiZXR3ZWVuIGhvdHBs dWcgYW5kIHJlc3RvcmUgKGxhc3RjbG9zZSBpcyBvbmx5IGNhbGxlZCB3aGVuCnRoZXJlJ3Mgbm90 IG1hc3RlciBhbmQgaGVuY2UgaXNfYm91bmQoKSB3aWxsIHJldHVybiB0cnVlKS4gU28gaWYgeW91 Cmxhc3RjbG9zZSwgaXQgd29uJ3QgYmUgcmVzdG9yZWQsIGJ1dCBpZiB5b3UgdGhlbiBwbHVnIHNv bWV0aGluZyBpdCwgaXQKd2lsbC4gU28gSSBzdGlsbCB0aGluayB3ZSBzaG91bGQgZml4IHRoaXMg Y29uc2lzdGVudGx5IGZvciBhbGwgZHJpdmVycwooYW5kIHllYWggdGhhdCBtZWFucyByb2xsaW5n IG91dCBmYl9vcGVuL3JlbGVhc2UgY2FsbGJhY2tzKSwgYW5kIGFsc28KY29uc2lzdGVudGx5IGJl dHdlZW4gaG90cGx1ZyBhbmQgbGFzdGNsb3NlLgotRGFuaWVsCgo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2ZiX2hlbHBlci5jIHwgMjQgKysrKysrKysrKysrKysrKysrKysrKystCj4gIGluY2x1ZGUv ZHJtL2RybV9mYl9oZWxwZXIuaCAgICAgfCAxMCArKysrKysrKysrCj4gIDIgZmlsZXMgY2hhbmdl ZCwgMzMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxw ZXIuYwo+IGluZGV4IDlhNjlhZDdlOWYzYi4uYmU5M2U3MzkzNzA0IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2ZiX2hlbHBlci5jCj4gQEAgLTI5NDIsMTYgKzI5NDIsMzIgQEAgRVhQT1JUX1NZTUJPTChkcm1f ZmJfaGVscGVyX291dHB1dF9wb2xsX2NoYW5nZWQpOwo+ICBzdGF0aWMgaW50IGRybV9mYmRldl9m Yl9vcGVuKHN0cnVjdCBmYl9pbmZvICppbmZvLCBpbnQgdXNlcikKPiAgewo+ICAJc3RydWN0IGRy bV9mYl9oZWxwZXIgKmZiX2hlbHBlciA9IGluZm8tPnBhcjsKPiArCXVuc2lnbmVkIGludCBmYl9v cGVuX2NvdW50Owo+ICAKPiAgCWlmICghdHJ5X21vZHVsZV9nZXQoZmJfaGVscGVyLT5kZXYtPmRy aXZlci0+Zm9wcy0+b3duZXIpKQo+ICAJCXJldHVybiAtRU5PREVWOwo+ICAKPiArCW11dGV4X2xv Y2soJmZiX2hlbHBlci0+bG9jayk7Cj4gKwlmYl9vcGVuX2NvdW50ID0gZmJfaGVscGVyLT5mYl9v cGVuX2NvdW50Kys7Cj4gKwltdXRleF91bmxvY2soJmZiX2hlbHBlci0+bG9jayk7Cj4gKwo+ICsJ aWYgKCFmYl9vcGVuX2NvdW50KQo+ICsJCWRybV9mYl9oZWxwZXJfYmxhbmsoRkJfQkxBTktfVU5C TEFOSywgaW5mbyk7Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgZHJt X2ZiZGV2X2ZiX3JlbGVhc2Uoc3RydWN0IGZiX2luZm8gKmluZm8sIGludCB1c2VyKQo+ICB7Cj4g IAlzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyID0gaW5mby0+cGFyOwo+ICsJdW5zaWdu ZWQgaW50IGZiX29wZW5fY291bnQ7Cj4gKwo+ICsJbXV0ZXhfbG9jaygmZmJfaGVscGVyLT5sb2Nr KTsKPiArCWZiX29wZW5fY291bnQgPSAtLWZiX2hlbHBlci0+ZmJfb3Blbl9jb3VudDsKPiArCW11 dGV4X3VubG9jaygmZmJfaGVscGVyLT5sb2NrKTsKPiArCj4gKwlpZiAoIWZiX29wZW5fY291bnQp Cj4gKwkJZHJtX2ZiX2hlbHBlcl9ibGFuayhGQl9CTEFOS19QT1dFUkRPV04sIGluZm8pOwo+ICAK PiAgCW1vZHVsZV9wdXQoZmJfaGVscGVyLT5kZXYtPmRyaXZlci0+Zm9wcy0+b3duZXIpOwo+ICAK PiBAQCAtMzE0Myw4ICszMTU5LDE0IEBAIHN0YXRpYyB2b2lkIGRybV9mYmRldl9jbGllbnRfdW5y ZWdpc3RlcihzdHJ1Y3QgZHJtX2NsaWVudF9kZXYgKmNsaWVudCkKPiAgc3RhdGljIGludCBkcm1f ZmJkZXZfY2xpZW50X3Jlc3RvcmUoc3RydWN0IGRybV9jbGllbnRfZGV2ICpjbGllbnQpCj4gIHsK PiAgCXN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIgPSBkcm1fZmJfaGVscGVyX2Zyb21f Y2xpZW50KGNsaWVudCk7Cj4gKwl1bnNpZ25lZCBpbnQgZmJfb3Blbl9jb3VudDsKPiAgCj4gLQlk cm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91bmxvY2tlZChmYl9oZWxwZXIpOwo+ICsJ bXV0ZXhfbG9jaygmZmJfaGVscGVyLT5sb2NrKTsKPiArCWZiX29wZW5fY291bnQgPSBmYl9oZWxw ZXItPmZiX29wZW5fY291bnQ7Cj4gKwltdXRleF91bmxvY2soJmZiX2hlbHBlci0+bG9jayk7Cj4g Kwo+ICsJaWYgKGZiX29wZW5fY291bnQpCj4gKwkJZHJtX2ZiX2hlbHBlcl9yZXN0b3JlX2ZiZGV2 X21vZGVfdW5sb2NrZWQoZmJfaGVscGVyKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQo+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmggYi9pbmNsdWRlL2RybS9kcm1fZmJf aGVscGVyLmgKPiBpbmRleCBiYjlhY2VhNjEzNjkuLmU2Y2ExMTE5ZDUyNCAxMDA2NDQKPiAtLS0g YS9pbmNsdWRlL2RybS9kcm1fZmJfaGVscGVyLmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fZmJf aGVscGVyLmgKPiBAQCAtMjQ3LDYgKzI0NywxNiBAQCBzdHJ1Y3QgZHJtX2ZiX2hlbHBlciB7Cj4g IAkgKiBTZWUgYWxzbzogQGRlZmVycmVkX3NldHVwCj4gIAkgKi8KPiAgCWludCBwcmVmZXJyZWRf YnBwOwo+ICsKPiArCS8qKgo+ICsJICogQGZiX29wZW5fY291bnQ6Cj4gKwkgKgo+ICsJICogVGhl IGdlbmVyaWMgZmJkZXYgZW11bGF0aW9uIHVzZXMgdGhpcyB0byB0cmFjayB1c2Vyc3BhY2UvZmJj b24gb3BlbnMKPiArCSAqIHRvIGtub3cgd2hlbiB0byByZXN0b3JlLgo+ICsJICoKPiArCSAqIFBy b3RlY3RlZCBieSBAbG9jay4KPiArCSAqLwo+ICsJdW5zaWduZWQgaW50IGZiX29wZW5fY291bnQ7 Cj4gIH07Cj4gIAo+ICBzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fZmJfaGVscGVyICoKPiAtLSAK PiAyLjE1LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK