From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 38/43] drm/sun4i: Move access control before setting the register as documented Date: Tue, 27 Nov 2018 10:26:34 +0100 Message-ID: <20181127092634.fq47rifbodtu7tk7@flea> References: <20181123092515.2511-1-paul.kocialkowski@bootlin.com> <20181123092515.2511-39-paul.kocialkowski@bootlin.com> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7zpweo5ev7pd4bed" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20181123092515.2511-39-paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Paul Kocialkowski Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Maarten Lankhorst , Sean Paul , David Airlie , Chen-Yu Tsai , Thomas Petazzoni , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org --7zpweo5ev7pd4bed Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Fri, Nov 23, 2018 at 10:25:10AM +0100, Paul Kocialkowski wrote: > From: Maxime Ripard > > Unlike what is currently being done, the ACCESS_CTRL bit documentation asks > that this bit should be set before modifying any register. The code in the > BSP also does this, so make sure we do this as well. > > Signed-off-by: Maxime Ripard This patch (and the subsequent ones) are missing your SoB. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --7zpweo5ev7pd4bed--