From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm: Move drm_mode_setcrtc() local re-init to failure path Date: Wed, 28 Nov 2018 09:29:48 +0100 Message-ID: <20181128082948.GJ4266@phenom.ffwll.local> References: <20181127224654.48331-1-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id C038689B8E for ; Wed, 28 Nov 2018 08:29:52 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id d3so21328345edx.7 for ; Wed, 28 Nov 2018 00:29:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181127224654.48331-1-sean@poorly.run> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Maxime Ripard , dri-devel@lists.freedesktop.org, David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMjcsIDIwMTggYXQgMDU6NDY6MzhQTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IEluc3RlYWQg b2YgYWx3YXlzIHJlLWluaXRpYWxpemluZyB0aGUgdmFyaWFibGVzIHdlIG5lZWQgdG8gY2xlYW4g dXAgb24KPiBvdXQsIG1vdmUgdGhlIHJlLWluaXRpYWxpemF0aW9uIGludG8gdGhlIGJyYW5jaCB0 aGF0IGdvZXMgYmFjayB0byByZXRyeQo+IGxhYmVsLgo+IAo+IFRoaXMgaXMgYSBsYXRlcmFsIG1v dmUgcmlnaHQgbm93LCBidXQgd2lsbCBhbGxvdyB1cyB0byBwdWxsIG91dCB0aGUKPiBtb2Rlc2V0 IGxvY2tpbmcgaW50byBjb21tb24gY29kZS4gSSBrZXB0IHRoaXMgY2hhbmdlIHNlcGFyYXRlIHRv IG1ha2UKPiB0aGluZ3MgZWFzaWVyIHRvIHJldmlldy4KPiAKPiBDYzogRGFuaWVsIFZldHRlciA8 ZGFuaWVsQGZmd2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hy b21pdW0ub3JnPgoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3 bGwuY2g+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyB8IDE2ICsrKysrKysr Ky0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2NydGMuYwo+IGluZGV4IDI2OGExODJhZTE4OTMuLmFmNGI5NGNlOGU5NDIg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2NydGMuYwo+IEBAIC01NzAsOSArNTcwLDkgQEAgaW50IGRybV9tb2RlX3Nl dGNydGMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXN0cnVjdCBkcm1f bW9kZV9jcnRjICpjcnRjX3JlcSA9IGRhdGE7Cj4gIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4g IAlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPiAtCXN0cnVjdCBkcm1fY29ubmVjdG9yICoqY29u bmVjdG9yX3NldCwgKmNvbm5lY3RvcjsKPiAtCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ IC0Jc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGU7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3Rv ciAqKmNvbm5lY3Rvcl9zZXQgPSBOVUxMLCAqY29ubmVjdG9yOwo+ICsJc3RydWN0IGRybV9mcmFt ZWJ1ZmZlciAqZmIgPSBOVUxMOwo+ICsJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPSBO VUxMOwo+ICAJc3RydWN0IGRybV9tb2RlX3NldCBzZXQ7Cj4gIAl1aW50MzJfdCBfX3VzZXIgKnNl dF9jb25uZWN0b3JzX3B0cjsKPiAgCXN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCBjdHg7 Cj4gQEAgLTYwMSwxMCArNjAxLDYgQEAgaW50IGRybV9tb2RlX3NldGNydGMoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCW11dGV4X2xvY2soJmNydGMtPmRldi0+bW9kZV9j b25maWcubXV0ZXgpOwo+ICAJZHJtX21vZGVzZXRfYWNxdWlyZV9pbml0KCZjdHgsIERSTV9NT0RF U0VUX0FDUVVJUkVfSU5URVJSVVBUSUJMRSk7Cj4gIHJldHJ5Ogo+IC0JY29ubmVjdG9yX3NldCA9 IE5VTEw7Cj4gLQlmYiA9IE5VTEw7Cj4gLQltb2RlID0gTlVMTDsKPiAtCj4gIAlyZXQgPSBkcm1f bW9kZXNldF9sb2NrX2FsbF9jdHgoY3J0Yy0+ZGV2LCAmY3R4KTsKPiAgCWlmIChyZXQpCj4gIAkJ Z290byBvdXQ7Cj4gQEAgLTc2Niw2ICs3NjIsMTIgQEAgaW50IGRybV9tb2RlX3NldGNydGMoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCX0KPiAgCWtmcmVlKGNvbm5lY3Rv cl9zZXQpOwo+ICAJZHJtX21vZGVfZGVzdHJveShkZXYsIG1vZGUpOwo+ICsKPiArCS8qIEluIGNh c2Ugd2UgbmVlZCB0byByZXRyeS4uLiAqLwo+ICsJY29ubmVjdG9yX3NldCA9IE5VTEw7Cj4gKwlm YiA9IE5VTEw7Cj4gKwltb2RlID0gTlVMTDsKPiArCj4gIAlpZiAocmV0ID09IC1FREVBRExLKSB7 Cj4gIAkJcmV0ID0gZHJtX21vZGVzZXRfYmFja29mZigmY3R4KTsKPiAgCQlpZiAoIXJldCkKPiAt LSAKPiBTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBPUwo+ IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=